From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1264DC433EF for ; Wed, 23 Mar 2022 10:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234699AbiCWKlS (ORCPT ); Wed, 23 Mar 2022 06:41:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbiCWKlS (ORCPT ); Wed, 23 Mar 2022 06:41:18 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 419F66210E for ; Wed, 23 Mar 2022 03:39:48 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id l20so1932248lfg.12 for ; Wed, 23 Mar 2022 03:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=yAkPXvHZVB3DXiA6lnV3OJs4l7boHKACGrx2zNN0q0WdW4bDDBFu/J4udxtyTi4LnD EW5GVcRjYXzEeDLkpqeGo1qdR36WyqvDgbQswBau6NJctIIV72R0Wo2Kj1TEosLVpGaq UvO0sdl+erB80ekBTDMX7IEdiKF3ft8qxVaWiecxxSgBJsWhhrQHl5YOnjDD05TZdcGP GDOInQ2USvHXmJkV5XU+7gTi59xIrI9Dv6xe++mHYqDqDI5n+u4nmlN8qRthsqM0DM33 fzmhSc0ONmXxs82ScbBBb79fjsbtQFhKXPJYW/HWmd9J56xvz4lQapq28hyricqZ/Ueu gp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=s9rUWF2a0Wz2UsQLFRQPopBDTHecMvHBytyYNQMFKCBF42AdceCZ5yDbkNVTfsSVlW 4MlVId8Yspr62VfcIloxp4EMfLH7IpoVZWAQxbfLdCWMHbPMZkS3y5FkjTHlqhXw5UAE O050ZrPt4jNHjmgy6h2eeaVOnmMJuqDgzlPh9Usf20THIiVmjVkfIedMc/i7ClfOkydW 0xrXEtSzXnPvSYXdPosa+DouWfe+yfjuJk092nfxzCAWfde0xV6qArC08h55Pbin0OVL JzbvDFIGVDn8RyE80j7Xj+nEu1cukhfTWVWGglGXXlV992YtD1mGKfjbyEh6HMaYOTHK bCXA== X-Gm-Message-State: AOAM532m/nnmY/gBw/IqCyAusgt9swCSGogflyLF+ErY6rKyOcpDI1fR vmeFPGNyJBUYqFlVck2VXMNMmg== X-Google-Smtp-Source: ABdhPJxdoE2MJzCwqFEPkOY+WggWU0jxIXl/lqXQbtd4rieBWf/meitV/U1e3m4J8NKMlt9q9m+iIA== X-Received: by 2002:a05:6512:34c7:b0:44a:37de:9d74 with SMTP id w7-20020a05651234c700b0044a37de9d74mr6436931lfr.314.1648031986613; Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id x33-20020a0565123fa100b00443d3cffd89sm2479850lfa.210.2022.03.23.03.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:39:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-GB To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Alex Deucher Cc: Maling list - DRI developers , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Emma Anholt , Neil Armstrong , Xinliang Liu , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , Chen Feng , Alain Volmat , Harry Wentland , Chun-Kuang Hu , Jonas Karlman , Leo Li , linux-arm-msm , Intel Graphics Development , Abhinav Kumar , Maxime Ripard , Nikola Cornij , John Stultz , Sean Paul , linux-arm-kernel , Tomi Valkeinen , Jyri Sarha , Sandy Huang , Robert Foss , Patrik Jakobsson , Rob Clark , Philipp Zabel , Alex Deucher , Tian Tao , freedreno , Laurent Pinchart References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 22/03/2022 01:37, Ville Syrjälä wrote: > On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >> wrote: >>> >>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>> drm: Add drm_mode_init() >>>> drm/bridge: Use drm_mode_copy() >>>> drm/imx: Use drm_mode_duplicate() >>>> drm/panel: Use drm_mode_duplicate() >>>> drm/vc4: Use drm_mode_copy() >>> These have been pushed to drm-misc-next. >>> >>>> drm/amdgpu: Remove pointless on stack mode copies >>>> drm/amdgpu: Use drm_mode_init() for on-stack modes >>>> drm/amdgpu: Use drm_mode_copy() >>> amdgpu ones are reviewed, but I'll leave them for the >>> AMD folks to push to whichever tree they prefer. >> >> I pulled patches 2, 4, 5 into my tree. > > Thanks. > >> For 3, I'm happy to have it >> land via drm-misc with the rest of the mode_init changes if you'd >> prefer. > > Either way works for me. I don't yet have reviews yet for > the other drivers, so I'll proably hold off for a bit more > at least. And the i915 patch I'll be merging via drm-intel. > >>>> drm/radeon: Use drm_mode_copy() >>>> drm/gma500: Use drm_mode_copy() >>>> drm/tilcdc: Use drm_mode_copy() >>>> drm/i915: Use drm_mode_copy() > > Those are now all in. > > Which leaves us with these stragglers: >>>> drm/hisilicon: Use drm_mode_init() for on-stack modes >>>> drm/msm: Nuke weird on stack mode copy >>>> drm/msm: Use drm_mode_init() for on-stack modes >>>> drm/msm: Use drm_mode_copy() These three patches went beneath my radar for some reason. I have just sent a replacement for the first patch ([1]). Other two patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next development cycle if that works for you. [1] https://patchwork.freedesktop.org/series/101682/ >>>> drm/mtk: Use drm_mode_init() for on-stack modes >>>> drm/rockchip: Use drm_mode_copy() >>>> drm/sti: Use drm_mode_copy() >>>> drm: Use drm_mode_init() for on-stack modes >>>> drm: Use drm_mode_copy() > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FA52C433F5 for ; Wed, 23 Mar 2022 10:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pofd75Um4B0ecO901T38YhYUJbAOrAEgH043IkpQZRU=; b=TZeyMNT/m5ontT POUWAZgKdj/aAYM+KpzseP8e/aCFI9vdvFPlP1rp8UARR3FH/iJRBkIRCzAAvgU9XOhwopAl/paHg PengJQCCKxRanhnY+vUy4OSpmfZtBPej7Ek3FQqtuhBQHu6iBRMwghkaFewuFqI32utxGJrw9ssgA tOmkHaAcfXZZmySxnRjAIP2exVGQqWNkA7j0k5jdR8PiNYpm8rhLg33FiSdLTDPGt2eEEKR+zFEoV CmVxv7bzKlt0JYc2ZOiHkJoV6ttafbTQQ2hJgAYENM85bpX2wffEhSJKPgemRmSkIANyo97+7PThq Qby+2H+u2wYHx+tSniHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWyPI-00DLgQ-V6; Wed, 23 Mar 2022 10:40:00 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWyP6-00DLeD-W3 for linux-rockchip@lists.infradead.org; Wed, 23 Mar 2022 10:39:50 +0000 Received: by mail-lf1-x129.google.com with SMTP id w7so1959053lfd.6 for ; Wed, 23 Mar 2022 03:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=yAkPXvHZVB3DXiA6lnV3OJs4l7boHKACGrx2zNN0q0WdW4bDDBFu/J4udxtyTi4LnD EW5GVcRjYXzEeDLkpqeGo1qdR36WyqvDgbQswBau6NJctIIV72R0Wo2Kj1TEosLVpGaq UvO0sdl+erB80ekBTDMX7IEdiKF3ft8qxVaWiecxxSgBJsWhhrQHl5YOnjDD05TZdcGP GDOInQ2USvHXmJkV5XU+7gTi59xIrI9Dv6xe++mHYqDqDI5n+u4nmlN8qRthsqM0DM33 fzmhSc0ONmXxs82ScbBBb79fjsbtQFhKXPJYW/HWmd9J56xvz4lQapq28hyricqZ/Ueu gp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=Sx63M86smi/GucO4Krl5Bt1eUUmhaYk7JDMqP4wts1hkhCqcE6IaUFvs8llJcvs0Tp vgDw+BElVbKxqrHaOHhMCWq2J1N5vHeLyRA1GZz83s+NXtNi1OWGHqwh5w1Bh6B0G/3N eejBsGBd3vM6o9ATvcD9L/jIgQrQRqH0g2yiZKilHI6qDakxLCUD6LJCuls1U9OCu1in 85eLMheleveoxCa5uR8rMd3xMKyX/WMRinCrCEosNXnkD55QACVwMxs4tVs7K6aY5J5e fH5ylxtYnb3EQkHwv4dcPn8d7MbOyH637+mmjQJme7TSqFwLct80LevszicTqlsgVqZ/ eRMA== X-Gm-Message-State: AOAM531KZAtso271y8YzLGOCtOrQXtQU9UQOYMEi/gXMgZzhaDikNgyV z6H1RDTVaGUdSAlDI3TUB0JHAw== X-Google-Smtp-Source: ABdhPJxdoE2MJzCwqFEPkOY+WggWU0jxIXl/lqXQbtd4rieBWf/meitV/U1e3m4J8NKMlt9q9m+iIA== X-Received: by 2002:a05:6512:34c7:b0:44a:37de:9d74 with SMTP id w7-20020a05651234c700b0044a37de9d74mr6436931lfr.314.1648031986613; Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id x33-20020a0565123fa100b00443d3cffd89sm2479850lfa.210.2022.03.23.03.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:39:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-GB To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Alex Deucher Cc: Maling list - DRI developers , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Emma Anholt , Neil Armstrong , Xinliang Liu , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , Chen Feng , Alain Volmat , Harry Wentland , Chun-Kuang Hu , Jonas Karlman , Leo Li , linux-arm-msm , Intel Graphics Development , Abhinav Kumar , Maxime Ripard , Nikola Cornij , John Stultz , Sean Paul , linux-arm-kernel , Tomi Valkeinen , Jyri Sarha , Sandy Huang , Robert Foss , Patrik Jakobsson , Rob Clark , Philipp Zabel , Alex Deucher , Tian Tao , freedreno , Laurent Pinchart References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_033949_038841_26FEFFC2 X-CRM114-Status: GOOD ( 18.44 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjIvMDMvMjAyMiAwMTozNywgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+IE9uIFR1ZSwgTWFy IDE1LCAyMDIyIGF0IDAyOjUyOjM4UE0gLTA0MDAsIEFsZXggRGV1Y2hlciB3cm90ZToKPj4gT24g TW9uLCBNYXIgMTQsIDIwMjIgYXQgNjoxMiBQTSBWaWxsZSBTeXJqw6Rsw6QKPj4gPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPj4+Cj4+PiBPbiBGcmksIEZlYiAxOCwgMjAy MiBhdCAxMjowMzo0MVBNICswMjAwLCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+Pj4+ICAgIGRybTog QWRkIGRybV9tb2RlX2luaXQoKQo+Pj4+ICAgIGRybS9icmlkZ2U6IFVzZSBkcm1fbW9kZV9jb3B5 KCkKPj4+PiAgICBkcm0vaW14OiBVc2UgZHJtX21vZGVfZHVwbGljYXRlKCkKPj4+PiAgICBkcm0v cGFuZWw6IFVzZSBkcm1fbW9kZV9kdXBsaWNhdGUoKQo+Pj4+ICAgIGRybS92YzQ6IFVzZSBkcm1f bW9kZV9jb3B5KCkKPj4+IFRoZXNlIGhhdmUgYmVlbiBwdXNoZWQgdG8gZHJtLW1pc2MtbmV4dC4K Pj4+Cj4+Pj4gICAgZHJtL2FtZGdwdTogUmVtb3ZlIHBvaW50bGVzcyBvbiBzdGFjayBtb2RlIGNv cGllcwo+Pj4+ICAgIGRybS9hbWRncHU6IFVzZSBkcm1fbW9kZV9pbml0KCkgZm9yIG9uLXN0YWNr IG1vZGVzCj4+Pj4gICAgZHJtL2FtZGdwdTogVXNlIGRybV9tb2RlX2NvcHkoKQo+Pj4gYW1kZ3B1 IG9uZXMgYXJlIHJldmlld2VkLCBidXQgSSdsbCBsZWF2ZSB0aGVtIGZvciB0aGUKPj4+IEFNRCBm b2xrcyB0byBwdXNoIHRvIHdoaWNoZXZlciB0cmVlIHRoZXkgcHJlZmVyLgo+Pgo+PiBJIHB1bGxl ZCBwYXRjaGVzIDIsIDQsIDUgaW50byBteSB0cmVlLgo+IAo+IFRoYW5rcy4KPiAKPj4gRm9yIDMs IEknbSBoYXBweSB0byBoYXZlIGl0Cj4+IGxhbmQgdmlhIGRybS1taXNjIHdpdGggdGhlIHJlc3Qg b2YgdGhlIG1vZGVfaW5pdCBjaGFuZ2VzIGlmIHlvdSdkCj4+IHByZWZlci4KPiAKPiBFaXRoZXIg d2F5IHdvcmtzIGZvciBtZS4gSSBkb24ndCB5ZXQgaGF2ZSByZXZpZXdzIHlldCBmb3IKPiB0aGUg b3RoZXIgZHJpdmVycywgc28gSSdsbCBwcm9hYmx5IGhvbGQgb2ZmIGZvciBhIGJpdCBtb3JlCj4g YXQgbGVhc3QuIEFuZCB0aGUgaTkxNSBwYXRjaCBJJ2xsIGJlIG1lcmdpbmcgdmlhIGRybS1pbnRl bC4KPiAKPj4+PiAgICBkcm0vcmFkZW9uOiBVc2UgZHJtX21vZGVfY29weSgpCj4+Pj4gICAgZHJt L2dtYTUwMDogVXNlIGRybV9tb2RlX2NvcHkoKQo+Pj4+ICAgIGRybS90aWxjZGM6IFVzZSBkcm1f bW9kZV9jb3B5KCkKPj4+PiAgICBkcm0vaTkxNTogVXNlIGRybV9tb2RlX2NvcHkoKQo+IAo+IFRo b3NlIGFyZSBub3cgYWxsIGluLgo+IAo+IFdoaWNoIGxlYXZlcyB1cyB3aXRoIHRoZXNlIHN0cmFn Z2xlcnM6Cj4+Pj4gICAgZHJtL2hpc2lsaWNvbjogVXNlIGRybV9tb2RlX2luaXQoKSBmb3Igb24t c3RhY2sgbW9kZXMKCj4+Pj4gICAgZHJtL21zbTogTnVrZSB3ZWlyZCBvbiBzdGFjayBtb2RlIGNv cHkKPj4+PiAgICBkcm0vbXNtOiBVc2UgZHJtX21vZGVfaW5pdCgpIGZvciBvbi1zdGFjayBtb2Rl cwo+Pj4+ICAgIGRybS9tc206IFVzZSBkcm1fbW9kZV9jb3B5KCkKClRoZXNlIHRocmVlIHBhdGNo ZXMgd2VudCBiZW5lYXRoIG15IHJhZGFyIGZvciBzb21lIHJlYXNvbi4KCkkgaGF2ZSBqdXN0IHNl bnQgYSByZXBsYWNlbWVudCBmb3IgdGhlIGZpcnN0IHBhdGNoIChbMV0pLiBPdGhlciB0d28gCnBh dGNoZXMgY2FuIGJlIHB1bGxlZCBpbiBtc20vbXNtLW5leHQgKG9yIG1zbS9tc20tZml4ZXMpIGR1 cmluZyB0aGUgbmV4dCAKZGV2ZWxvcG1lbnQgY3ljbGUgaWYgdGhhdCB3b3JrcyBmb3IgeW91LgoK WzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9zZXJpZXMvMTAxNjgyLwoKPj4+ PiAgICBkcm0vbXRrOiBVc2UgZHJtX21vZGVfaW5pdCgpIGZvciBvbi1zdGFjayBtb2Rlcwo+Pj4+ ICAgIGRybS9yb2NrY2hpcDogVXNlIGRybV9tb2RlX2NvcHkoKQo+Pj4+ICAgIGRybS9zdGk6IFVz ZSBkcm1fbW9kZV9jb3B5KCkKPj4+PiAgICBkcm06IFVzZSBkcm1fbW9kZV9pbml0KCkgZm9yIG9u LXN0YWNrIG1vZGVzCj4+Pj4gICAgZHJtOiBVc2UgZHJtX21vZGVfY29weSgpCj4gCgoKLS0gCldp dGggYmVzdCB3aXNoZXMKRG1pdHJ5CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2BEBC433F5 for ; Wed, 23 Mar 2022 10:39:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E055010E673; Wed, 23 Mar 2022 10:39:49 +0000 (UTC) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B36210E676 for ; Wed, 23 Mar 2022 10:39:48 +0000 (UTC) Received: by mail-lf1-x12b.google.com with SMTP id d5so1953030lfj.9 for ; Wed, 23 Mar 2022 03:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=yAkPXvHZVB3DXiA6lnV3OJs4l7boHKACGrx2zNN0q0WdW4bDDBFu/J4udxtyTi4LnD EW5GVcRjYXzEeDLkpqeGo1qdR36WyqvDgbQswBau6NJctIIV72R0Wo2Kj1TEosLVpGaq UvO0sdl+erB80ekBTDMX7IEdiKF3ft8qxVaWiecxxSgBJsWhhrQHl5YOnjDD05TZdcGP GDOInQ2USvHXmJkV5XU+7gTi59xIrI9Dv6xe++mHYqDqDI5n+u4nmlN8qRthsqM0DM33 fzmhSc0ONmXxs82ScbBBb79fjsbtQFhKXPJYW/HWmd9J56xvz4lQapq28hyricqZ/Ueu gp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=i9J18yOVNIy/GOcVh8jIfbqC/VO7PWvkIBsVClP1e1TADOrkDz9OEMC/tC31zcTHdu MOjPHUHFEXF7/AxK1QGWqo0ePIiP6iKooVHF65IZHrRNUYz5dgAkNvHZrpzoXwh7sWZ+ lrXVZpHgVlIMGyZY/3WvvaOFwDINfHxVKbGoZwvnwQCIEIYs/5cLMRfQSbzYRvTRQ6d1 aO/frGixC35hjC+WwCe82uI1Plm6CR/+TUXSdebW63vG3dAMzF7RpPGeMNxzfRXqIWCI QaxULLC7ytuvGew+tps3/vZ3hpOWo3SWcopY1KKGYdCdH8A17RDZmbiEFPBeyNkPtbpD K4Nw== X-Gm-Message-State: AOAM531FwaEdlFV7dQGzptmfkj0DsknHJOu52u1vmhv8hVmlLBqXEuQB 7NSgIwfdepYnWLpUSXqaAQeZYQ== X-Google-Smtp-Source: ABdhPJxdoE2MJzCwqFEPkOY+WggWU0jxIXl/lqXQbtd4rieBWf/meitV/U1e3m4J8NKMlt9q9m+iIA== X-Received: by 2002:a05:6512:34c7:b0:44a:37de:9d74 with SMTP id w7-20020a05651234c700b0044a37de9d74mr6436931lfr.314.1648031986613; Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id x33-20020a0565123fa100b00443d3cffd89sm2479850lfa.210.2022.03.23.03.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:39:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-GB To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Alex Deucher References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , linux-arm-msm , Alain Volmat , Chun-Kuang Hu , Jonas Karlman , Leo Li , Chen Feng , Intel Graphics Development , Abhinav Kumar , Nikola Cornij , Sean Paul , linux-arm-kernel , Tomi Valkeinen , freedreno , Sandy Huang , Robert Foss , Alex Deucher , Tian Tao , Jyri Sarha , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 22/03/2022 01:37, Ville Syrjälä wrote: > On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >> wrote: >>> >>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>> drm: Add drm_mode_init() >>>> drm/bridge: Use drm_mode_copy() >>>> drm/imx: Use drm_mode_duplicate() >>>> drm/panel: Use drm_mode_duplicate() >>>> drm/vc4: Use drm_mode_copy() >>> These have been pushed to drm-misc-next. >>> >>>> drm/amdgpu: Remove pointless on stack mode copies >>>> drm/amdgpu: Use drm_mode_init() for on-stack modes >>>> drm/amdgpu: Use drm_mode_copy() >>> amdgpu ones are reviewed, but I'll leave them for the >>> AMD folks to push to whichever tree they prefer. >> >> I pulled patches 2, 4, 5 into my tree. > > Thanks. > >> For 3, I'm happy to have it >> land via drm-misc with the rest of the mode_init changes if you'd >> prefer. > > Either way works for me. I don't yet have reviews yet for > the other drivers, so I'll proably hold off for a bit more > at least. And the i915 patch I'll be merging via drm-intel. > >>>> drm/radeon: Use drm_mode_copy() >>>> drm/gma500: Use drm_mode_copy() >>>> drm/tilcdc: Use drm_mode_copy() >>>> drm/i915: Use drm_mode_copy() > > Those are now all in. > > Which leaves us with these stragglers: >>>> drm/hisilicon: Use drm_mode_init() for on-stack modes >>>> drm/msm: Nuke weird on stack mode copy >>>> drm/msm: Use drm_mode_init() for on-stack modes >>>> drm/msm: Use drm_mode_copy() These three patches went beneath my radar for some reason. I have just sent a replacement for the first patch ([1]). Other two patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next development cycle if that works for you. [1] https://patchwork.freedesktop.org/series/101682/ >>>> drm/mtk: Use drm_mode_init() for on-stack modes >>>> drm/rockchip: Use drm_mode_copy() >>>> drm/sti: Use drm_mode_copy() >>>> drm: Use drm_mode_init() for on-stack modes >>>> drm: Use drm_mode_copy() > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD898C433F5 for ; Wed, 23 Mar 2022 10:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AZg8e6BjkhZEfZKX7O/Jav8Ik5wvPPtsRabTpWGm2tw=; b=AfjrnNHGxm+mUx HMdIYkwfiIBrSf9YBWaq3xjceGT0sWx8f7xCDCKFvq+2ar9itNDlA9tgEud0TfKxeE34KnTHOX1Fr K9pKhLqUQi7uWImXcdy7S0vX3UPGww1H8r3mgjbIH8kRPBbPJ9CHoonsGpD87HHzQicfFJ2F9cCI8 JRr1VojLbHWA1p7aoqVndox6wvV0ZEnLAYSh66Gz5LuCsGalm+JCi2tGt8WdZ8GT+wjfviRA/E44I ZzXcBTYdxXQO6tgaJGz1VBAN7ErIhgkRnjTcMER57UBFxdHPZ6DiS0DCbkNKZB2k8ZGpnPcafOBTn KzM0KYHFN8fW2ERYRpPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWyPA-00DLf9-Af; Wed, 23 Mar 2022 10:39:52 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWyP6-00DLeC-Hi for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 10:39:50 +0000 Received: by mail-lf1-x132.google.com with SMTP id bt26so1971456lfb.3 for ; Wed, 23 Mar 2022 03:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=yAkPXvHZVB3DXiA6lnV3OJs4l7boHKACGrx2zNN0q0WdW4bDDBFu/J4udxtyTi4LnD EW5GVcRjYXzEeDLkpqeGo1qdR36WyqvDgbQswBau6NJctIIV72R0Wo2Kj1TEosLVpGaq UvO0sdl+erB80ekBTDMX7IEdiKF3ft8qxVaWiecxxSgBJsWhhrQHl5YOnjDD05TZdcGP GDOInQ2USvHXmJkV5XU+7gTi59xIrI9Dv6xe++mHYqDqDI5n+u4nmlN8qRthsqM0DM33 fzmhSc0ONmXxs82ScbBBb79fjsbtQFhKXPJYW/HWmd9J56xvz4lQapq28hyricqZ/Ueu gp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=6NVRpBVE5bVQ0a4P0vwHeAfsdziamcQlxxhtqe+XrCNFjPwIR+uRfjtGeJs/H5xCBT PFY5CQ20DzJ7ZxuZ+yUDwW2BaqXJXDczLRUfh0tDUSaoyNQlhdqw9UshKBM85b55Wg9K gTeaudHv0OQgA5JsCq0OViZVd0ij2sNT0Kk7Q2xno+hPCpU1plr+M7+BYoltKkHFYNdT DWZ/b7ghvPwFAMjr+KfNVxCrBJgE4QJCVoMZxrM+P3xxmdGSH7ePZa9TU2BSglrnsUae M7SI7XVkjgmV6lHXlXjXKdyWfDTYv3C2C+aPjak5CCbe1+XLG2keyZi+j9yxer65Fli4 TjhA== X-Gm-Message-State: AOAM533rX1IyuWDFgVOrCSSC5mwPkXg9m3tSDl208VDsH2eSZI+JeTsJ ryCvvjHpv90s47HYDe1F7Z+sqw== X-Google-Smtp-Source: ABdhPJxdoE2MJzCwqFEPkOY+WggWU0jxIXl/lqXQbtd4rieBWf/meitV/U1e3m4J8NKMlt9q9m+iIA== X-Received: by 2002:a05:6512:34c7:b0:44a:37de:9d74 with SMTP id w7-20020a05651234c700b0044a37de9d74mr6436931lfr.314.1648031986613; Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id x33-20020a0565123fa100b00443d3cffd89sm2479850lfa.210.2022.03.23.03.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:39:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-GB To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Alex Deucher Cc: Maling list - DRI developers , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Emma Anholt , Neil Armstrong , Xinliang Liu , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , Chen Feng , Alain Volmat , Harry Wentland , Chun-Kuang Hu , Jonas Karlman , Leo Li , linux-arm-msm , Intel Graphics Development , Abhinav Kumar , Maxime Ripard , Nikola Cornij , John Stultz , Sean Paul , linux-arm-kernel , Tomi Valkeinen , Jyri Sarha , Sandy Huang , Robert Foss , Patrik Jakobsson , Rob Clark , Philipp Zabel , Alex Deucher , Tian Tao , freedreno , Laurent Pinchart References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_033948_659635_AE924BCA X-CRM114-Status: GOOD ( 19.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjIvMDMvMjAyMiAwMTozNywgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+IE9uIFR1ZSwgTWFy IDE1LCAyMDIyIGF0IDAyOjUyOjM4UE0gLTA0MDAsIEFsZXggRGV1Y2hlciB3cm90ZToKPj4gT24g TW9uLCBNYXIgMTQsIDIwMjIgYXQgNjoxMiBQTSBWaWxsZSBTeXJqw6Rsw6QKPj4gPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPj4+Cj4+PiBPbiBGcmksIEZlYiAxOCwgMjAy MiBhdCAxMjowMzo0MVBNICswMjAwLCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+Pj4+ICAgIGRybTog QWRkIGRybV9tb2RlX2luaXQoKQo+Pj4+ICAgIGRybS9icmlkZ2U6IFVzZSBkcm1fbW9kZV9jb3B5 KCkKPj4+PiAgICBkcm0vaW14OiBVc2UgZHJtX21vZGVfZHVwbGljYXRlKCkKPj4+PiAgICBkcm0v cGFuZWw6IFVzZSBkcm1fbW9kZV9kdXBsaWNhdGUoKQo+Pj4+ICAgIGRybS92YzQ6IFVzZSBkcm1f bW9kZV9jb3B5KCkKPj4+IFRoZXNlIGhhdmUgYmVlbiBwdXNoZWQgdG8gZHJtLW1pc2MtbmV4dC4K Pj4+Cj4+Pj4gICAgZHJtL2FtZGdwdTogUmVtb3ZlIHBvaW50bGVzcyBvbiBzdGFjayBtb2RlIGNv cGllcwo+Pj4+ICAgIGRybS9hbWRncHU6IFVzZSBkcm1fbW9kZV9pbml0KCkgZm9yIG9uLXN0YWNr IG1vZGVzCj4+Pj4gICAgZHJtL2FtZGdwdTogVXNlIGRybV9tb2RlX2NvcHkoKQo+Pj4gYW1kZ3B1 IG9uZXMgYXJlIHJldmlld2VkLCBidXQgSSdsbCBsZWF2ZSB0aGVtIGZvciB0aGUKPj4+IEFNRCBm b2xrcyB0byBwdXNoIHRvIHdoaWNoZXZlciB0cmVlIHRoZXkgcHJlZmVyLgo+Pgo+PiBJIHB1bGxl ZCBwYXRjaGVzIDIsIDQsIDUgaW50byBteSB0cmVlLgo+IAo+IFRoYW5rcy4KPiAKPj4gRm9yIDMs IEknbSBoYXBweSB0byBoYXZlIGl0Cj4+IGxhbmQgdmlhIGRybS1taXNjIHdpdGggdGhlIHJlc3Qg b2YgdGhlIG1vZGVfaW5pdCBjaGFuZ2VzIGlmIHlvdSdkCj4+IHByZWZlci4KPiAKPiBFaXRoZXIg d2F5IHdvcmtzIGZvciBtZS4gSSBkb24ndCB5ZXQgaGF2ZSByZXZpZXdzIHlldCBmb3IKPiB0aGUg b3RoZXIgZHJpdmVycywgc28gSSdsbCBwcm9hYmx5IGhvbGQgb2ZmIGZvciBhIGJpdCBtb3JlCj4g YXQgbGVhc3QuIEFuZCB0aGUgaTkxNSBwYXRjaCBJJ2xsIGJlIG1lcmdpbmcgdmlhIGRybS1pbnRl bC4KPiAKPj4+PiAgICBkcm0vcmFkZW9uOiBVc2UgZHJtX21vZGVfY29weSgpCj4+Pj4gICAgZHJt L2dtYTUwMDogVXNlIGRybV9tb2RlX2NvcHkoKQo+Pj4+ICAgIGRybS90aWxjZGM6IFVzZSBkcm1f bW9kZV9jb3B5KCkKPj4+PiAgICBkcm0vaTkxNTogVXNlIGRybV9tb2RlX2NvcHkoKQo+IAo+IFRo b3NlIGFyZSBub3cgYWxsIGluLgo+IAo+IFdoaWNoIGxlYXZlcyB1cyB3aXRoIHRoZXNlIHN0cmFn Z2xlcnM6Cj4+Pj4gICAgZHJtL2hpc2lsaWNvbjogVXNlIGRybV9tb2RlX2luaXQoKSBmb3Igb24t c3RhY2sgbW9kZXMKCj4+Pj4gICAgZHJtL21zbTogTnVrZSB3ZWlyZCBvbiBzdGFjayBtb2RlIGNv cHkKPj4+PiAgICBkcm0vbXNtOiBVc2UgZHJtX21vZGVfaW5pdCgpIGZvciBvbi1zdGFjayBtb2Rl cwo+Pj4+ICAgIGRybS9tc206IFVzZSBkcm1fbW9kZV9jb3B5KCkKClRoZXNlIHRocmVlIHBhdGNo ZXMgd2VudCBiZW5lYXRoIG15IHJhZGFyIGZvciBzb21lIHJlYXNvbi4KCkkgaGF2ZSBqdXN0IHNl bnQgYSByZXBsYWNlbWVudCBmb3IgdGhlIGZpcnN0IHBhdGNoIChbMV0pLiBPdGhlciB0d28gCnBh dGNoZXMgY2FuIGJlIHB1bGxlZCBpbiBtc20vbXNtLW5leHQgKG9yIG1zbS9tc20tZml4ZXMpIGR1 cmluZyB0aGUgbmV4dCAKZGV2ZWxvcG1lbnQgY3ljbGUgaWYgdGhhdCB3b3JrcyBmb3IgeW91LgoK WzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9zZXJpZXMvMTAxNjgyLwoKPj4+ PiAgICBkcm0vbXRrOiBVc2UgZHJtX21vZGVfaW5pdCgpIGZvciBvbi1zdGFjayBtb2Rlcwo+Pj4+ ICAgIGRybS9yb2NrY2hpcDogVXNlIGRybV9tb2RlX2NvcHkoKQo+Pj4+ICAgIGRybS9zdGk6IFVz ZSBkcm1fbW9kZV9jb3B5KCkKPj4+PiAgICBkcm06IFVzZSBkcm1fbW9kZV9pbml0KCkgZm9yIG9u LXN0YWNrIG1vZGVzCj4+Pj4gICAgZHJtOiBVc2UgZHJtX21vZGVfY29weSgpCj4gCgoKLS0gCldp dGggYmVzdCB3aXNoZXMKRG1pdHJ5CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5468DC433FE for ; Wed, 23 Mar 2022 11:02:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E015C10E697; Wed, 23 Mar 2022 11:02:20 +0000 (UTC) Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47BF910E673 for ; Wed, 23 Mar 2022 10:39:48 +0000 (UTC) Received: by mail-lf1-x12e.google.com with SMTP id e16so1920038lfc.13 for ; Wed, 23 Mar 2022 03:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=yAkPXvHZVB3DXiA6lnV3OJs4l7boHKACGrx2zNN0q0WdW4bDDBFu/J4udxtyTi4LnD EW5GVcRjYXzEeDLkpqeGo1qdR36WyqvDgbQswBau6NJctIIV72R0Wo2Kj1TEosLVpGaq UvO0sdl+erB80ekBTDMX7IEdiKF3ft8qxVaWiecxxSgBJsWhhrQHl5YOnjDD05TZdcGP GDOInQ2USvHXmJkV5XU+7gTi59xIrI9Dv6xe++mHYqDqDI5n+u4nmlN8qRthsqM0DM33 fzmhSc0ONmXxs82ScbBBb79fjsbtQFhKXPJYW/HWmd9J56xvz4lQapq28hyricqZ/Ueu gp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=MTOWXs91+w17g+WYkL+tIkEYKaMeOpW+Brce3y2p03Tik+F86EHIwkxWz1xEnKZUKm xo+67N7cFyoK4PKfrfbpEdXvTh7P17dpee2kmSVhanJeXy2wSC4trDG19xtFL22HBYYO YwDtpw5m0jIHJ/F6g+SUC7xscGJp/jFwfelvj/Q4kqbgxppJqs+E+blwUpCb++smYkF3 6rdGLOgn4A9Ri33LoERC3Fu+YWDtz8Dpe+7JP62O/4vdoyNX6GePB0QH8yh/n5SFTIfy pvJUoYpX1f/ovCpsU+GFa9TBPA50yb7tAiRubyt0tYsebODjZwkvIKG22Ysa6K/mwaAc LMIA== X-Gm-Message-State: AOAM533NV5Ee1sNcEdSjZxvdGvwV1qskkYe5twVX8uWr9XmRgu5L0n4j 50E4ApLZgldcdu/ZW3VqywpNMw== X-Google-Smtp-Source: ABdhPJxdoE2MJzCwqFEPkOY+WggWU0jxIXl/lqXQbtd4rieBWf/meitV/U1e3m4J8NKMlt9q9m+iIA== X-Received: by 2002:a05:6512:34c7:b0:44a:37de:9d74 with SMTP id w7-20020a05651234c700b0044a37de9d74mr6436931lfr.314.1648031986613; Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id x33-20020a0565123fa100b00443d3cffd89sm2479850lfa.210.2022.03.23.03.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:39:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-GB To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Alex Deucher References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 23 Mar 2022 11:02:20 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , linux-arm-msm , Alain Volmat , Harry Wentland , Chun-Kuang Hu , Jonas Karlman , Leo Li , Chen Feng , Intel Graphics Development , Abhinav Kumar , Maxime Ripard , Nikola Cornij , John Stultz , Sean Paul , linux-arm-kernel , Tomi Valkeinen , freedreno , Sandy Huang , Robert Foss , Patrik Jakobsson , Rob Clark , Philipp Zabel , Alex Deucher , Tian Tao , Jyri Sarha , Laurent Pinchart Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 22/03/2022 01:37, Ville Syrjälä wrote: > On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >> wrote: >>> >>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>> drm: Add drm_mode_init() >>>> drm/bridge: Use drm_mode_copy() >>>> drm/imx: Use drm_mode_duplicate() >>>> drm/panel: Use drm_mode_duplicate() >>>> drm/vc4: Use drm_mode_copy() >>> These have been pushed to drm-misc-next. >>> >>>> drm/amdgpu: Remove pointless on stack mode copies >>>> drm/amdgpu: Use drm_mode_init() for on-stack modes >>>> drm/amdgpu: Use drm_mode_copy() >>> amdgpu ones are reviewed, but I'll leave them for the >>> AMD folks to push to whichever tree they prefer. >> >> I pulled patches 2, 4, 5 into my tree. > > Thanks. > >> For 3, I'm happy to have it >> land via drm-misc with the rest of the mode_init changes if you'd >> prefer. > > Either way works for me. I don't yet have reviews yet for > the other drivers, so I'll proably hold off for a bit more > at least. And the i915 patch I'll be merging via drm-intel. > >>>> drm/radeon: Use drm_mode_copy() >>>> drm/gma500: Use drm_mode_copy() >>>> drm/tilcdc: Use drm_mode_copy() >>>> drm/i915: Use drm_mode_copy() > > Those are now all in. > > Which leaves us with these stragglers: >>>> drm/hisilicon: Use drm_mode_init() for on-stack modes >>>> drm/msm: Nuke weird on stack mode copy >>>> drm/msm: Use drm_mode_init() for on-stack modes >>>> drm/msm: Use drm_mode_copy() These three patches went beneath my radar for some reason. I have just sent a replacement for the first patch ([1]). Other two patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next development cycle if that works for you. [1] https://patchwork.freedesktop.org/series/101682/ >>>> drm/mtk: Use drm_mode_init() for on-stack modes >>>> drm/rockchip: Use drm_mode_copy() >>>> drm/sti: Use drm_mode_copy() >>>> drm: Use drm_mode_init() for on-stack modes >>>> drm: Use drm_mode_copy() > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5228C4332F for ; Wed, 23 Mar 2022 15:40:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47CE110E712; Wed, 23 Mar 2022 15:40:55 +0000 (UTC) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46F5C10E66B for ; Wed, 23 Mar 2022 10:39:48 +0000 (UTC) Received: by mail-lf1-x12f.google.com with SMTP id t25so1959083lfg.7 for ; Wed, 23 Mar 2022 03:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=yAkPXvHZVB3DXiA6lnV3OJs4l7boHKACGrx2zNN0q0WdW4bDDBFu/J4udxtyTi4LnD EW5GVcRjYXzEeDLkpqeGo1qdR36WyqvDgbQswBau6NJctIIV72R0Wo2Kj1TEosLVpGaq UvO0sdl+erB80ekBTDMX7IEdiKF3ft8qxVaWiecxxSgBJsWhhrQHl5YOnjDD05TZdcGP GDOInQ2USvHXmJkV5XU+7gTi59xIrI9Dv6xe++mHYqDqDI5n+u4nmlN8qRthsqM0DM33 fzmhSc0ONmXxs82ScbBBb79fjsbtQFhKXPJYW/HWmd9J56xvz4lQapq28hyricqZ/Ueu gp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=P6IIaSuFTS6oMdEuOHbQXA7Hi0FpW7sJscpbNy1aZbC4hPX+Psh8bM7NHX3OBJVTKs B9HDwVKQrlOL7bnUEAf6vW1PWaSiAaurtJxf2+YWwD/w+Yr0Q5tMZjF91Z7F6dzCO2c1 UobPW8PjACd/MvWdaYN41Q706mo2iXYVGbnFi2tvaUY1kRSGZG/sdh8IColL28FDM9Vy BbBW6rSSQIBT0EKLuVzubW2i6jOh03vMncQImk/wdrEgCxLK4gci2oAVERAUKhQxi+EA rGCBBqW+o9n+sDZzsVk21HZxV4O3ZqmszuMUWYqQin87P42Bo76sVhNfqjK5GuAf37mD zRCw== X-Gm-Message-State: AOAM532mjEYP6AdF/M4XfKDCz1ngi3qMzN+YPF2mrR9tQd7F/jaT0QwA 8Ur3nCRddn4V/JjHmfzmPicVOw== X-Google-Smtp-Source: ABdhPJxdoE2MJzCwqFEPkOY+WggWU0jxIXl/lqXQbtd4rieBWf/meitV/U1e3m4J8NKMlt9q9m+iIA== X-Received: by 2002:a05:6512:34c7:b0:44a:37de:9d74 with SMTP id w7-20020a05651234c700b0044a37de9d74mr6436931lfr.314.1648031986613; Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id x33-20020a0565123fa100b00443d3cffd89sm2479850lfa.210.2022.03.23.03.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:39:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-GB To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Alex Deucher References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 23 Mar 2022 15:40:20 +0000 Subject: Re: [Intel-gfx] [PATCH 00/22] drm: Review of mode copies X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , linux-arm-msm , Alain Volmat , Harry Wentland , Chun-Kuang Hu , Jonas Karlman , Leo Li , Chen Feng , Intel Graphics Development , Abhinav Kumar , Maxime Ripard , Nikola Cornij , John Stultz , linux-arm-kernel , Tomi Valkeinen , freedreno , Sandy Huang , Robert Foss , Philipp Zabel , Alex Deucher , Tian Tao , Jyri Sarha , Laurent Pinchart Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 22/03/2022 01:37, Ville Syrjälä wrote: > On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >> wrote: >>> >>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>> drm: Add drm_mode_init() >>>> drm/bridge: Use drm_mode_copy() >>>> drm/imx: Use drm_mode_duplicate() >>>> drm/panel: Use drm_mode_duplicate() >>>> drm/vc4: Use drm_mode_copy() >>> These have been pushed to drm-misc-next. >>> >>>> drm/amdgpu: Remove pointless on stack mode copies >>>> drm/amdgpu: Use drm_mode_init() for on-stack modes >>>> drm/amdgpu: Use drm_mode_copy() >>> amdgpu ones are reviewed, but I'll leave them for the >>> AMD folks to push to whichever tree they prefer. >> >> I pulled patches 2, 4, 5 into my tree. > > Thanks. > >> For 3, I'm happy to have it >> land via drm-misc with the rest of the mode_init changes if you'd >> prefer. > > Either way works for me. I don't yet have reviews yet for > the other drivers, so I'll proably hold off for a bit more > at least. And the i915 patch I'll be merging via drm-intel. > >>>> drm/radeon: Use drm_mode_copy() >>>> drm/gma500: Use drm_mode_copy() >>>> drm/tilcdc: Use drm_mode_copy() >>>> drm/i915: Use drm_mode_copy() > > Those are now all in. > > Which leaves us with these stragglers: >>>> drm/hisilicon: Use drm_mode_init() for on-stack modes >>>> drm/msm: Nuke weird on stack mode copy >>>> drm/msm: Use drm_mode_init() for on-stack modes >>>> drm/msm: Use drm_mode_copy() These three patches went beneath my radar for some reason. I have just sent a replacement for the first patch ([1]). Other two patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next development cycle if that works for you. [1] https://patchwork.freedesktop.org/series/101682/ >>>> drm/mtk: Use drm_mode_init() for on-stack modes >>>> drm/rockchip: Use drm_mode_copy() >>>> drm/sti: Use drm_mode_copy() >>>> drm: Use drm_mode_init() for on-stack modes >>>> drm: Use drm_mode_copy() > -- With best wishes Dmitry