From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB764C433ED for ; Fri, 14 May 2021 15:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDBB4613B9 for ; Fri, 14 May 2021 15:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234827AbhENPzL (ORCPT ); Fri, 14 May 2021 11:55:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233914AbhENPzJ (ORCPT ); Fri, 14 May 2021 11:55:09 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B8E2C061574; Fri, 14 May 2021 08:53:56 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id di13so35230301edb.2; Fri, 14 May 2021 08:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=f5pKrku0e6EM6tOZFoRr8i5ryGCMprW/ArJmi1G1tF1P3P7TB/vGZt6eUZBeYX1OGP 4onTfNm+56vE+G3yKyyomtIVL/0TNH+IF3DEnOwqDIJ0EUpf+yDjVYVMnXLC0j8N9vlB 0LablOmpCVmnbJPG82EWGdqqbeH62hmqq9UT7wSqc5XZut/4D2/BTlqC4eYe0rLabD2v OFQOhntIB1I9aLkzF8xewSXdLpLPngab91x9DAK63/E85M4PiX9uswAdiBkxJTD159me eg2D15l8+0Xts9zanmFZyE/89732PpRS0TuLEsgtcyKUJAca/Yq+j0vuZGPanW1zZSNI 9gOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=iBxSHTFSUkdblwtojqoFYQHFQyg29m6VLtqRfilNWXdi11BjuqAqEYhAcBSRT/4WZe K2Z5oqYRzDeOEcW5DT9sYYVZDf+/msQtRijZ3GAcxPcJaMOsJqqIu+tqDKhOEFWS/q54 zsA0MOOpNLYLOJYgAsROZsmecTHHPGWv7TVXTvUZWzRfzzc6aypxNcdpv4RTzB2ehVkk /yawg4bkKkvLWxApl5CMp9B5m0Jqd2LF9UHJQqlkBb0aUUjNJJPJ+yrHGIdcJaC0UVwn I/qebaDkvS+YbR7YBtQ3Xn+jE61FQh92hPesU4iLPLCdVdhqFTyVXma+K2IHYIIMgLXY yQ+g== X-Gm-Message-State: AOAM533mMctgnnb+S3nr/kskna/Rgmc1stPyZuDpir9g+HMnfE4Po0gg QBYOXu3fgw6b4NF2NN+IwiTGZiqkCFU= X-Google-Smtp-Source: ABdhPJxiEhDApEu75kJdXXESrqi6t2oBygLR+znc2KM99z8D4A006a1c0919pGQoeo6o0GXD+663Ew== X-Received: by 2002:a05:6402:2753:: with SMTP id z19mr56769103edd.158.1621007635210; Fri, 14 May 2021 08:53:55 -0700 (PDT) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id ks10sm3911610ejb.41.2021.05.14.08.53.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 08:53:54 -0700 (PDT) Subject: Re: [PATCH v2 4/5] dt-bindings: soc: rockchip: grf: add compatible for RK3308 USB grf To: Tobias Schramm , linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org Cc: Rob Herring , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210514150044.2099298-1-t.schramm@manjaro.org> <20210514150044.2099298-5-t.schramm@manjaro.org> From: Johan Jonker Message-ID: Date: Fri, 14 May 2021 17:53:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210514150044.2099298-5-t.schramm@manjaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tobias, The grf serie is currently still under review. So things can change. Must add a change log below a "---" in the commit message for rob+dt. Maybe add a patch that fixes the reg size of "rockchip,rk3308-grf" as well? Johan On 5/14/21 5:00 PM, Tobias Schramm wrote: > The RK3308 has a USB GRF. > This patch adds a compatible string for it. > > Signed-off-by: Tobias Schramm > --- > Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > index 84bdaf88d5a6..df77bd2e6752 100644 > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > @@ -30,6 +30,7 @@ properties: > - rockchip,rk3288-grf > - rockchip,rk3308-core-grf > - rockchip,rk3308-detect-grf > + - rockchip,rk3308-usb2phy-grf > - rockchip,rk3308-grf Sort alphabetically. > - rockchip,rk3328-grf > - rockchip,rk3328-usb2phy-grf > Also allow usb2-phy as sub nodes name. + - if: + properties: + compatible: + contains: + enum: + - rockchip,px30-usb2phy-grf + - rockchip,rk3228-grf - rockchip,rk3308-usb2phy-grf + - rockchip,rk3328-usb2phy-grf + - rockchip,rk3399-grf + - rockchip,rv1108-grf + + then: + required: + - "#address-cells" + - "#size-cells" + + patternProperties: + "usb2-phy@[0-9a-f]+$": + type: object + + $ref: "/schemas/phy/phy-rockchip-inno-usb2.yaml#" + + unevaluatedProperties: false === Heiko's sort rules: compatible reg interrupts [alphabetical] status [if needed] === Sort #phy-cells below interrupt-names. + #phy-cells = <0>; + interrupts = ; + interrupt-names = "linestate"; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51139C433B4 for ; Fri, 14 May 2021 15:54:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAAEA613B9 for ; Fri, 14 May 2021 15:54:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAAEA613B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qVyur082Jo51GSG9+nUKPm+2IXpAOGBHNobbDqDYtRU=; b=SVsiCXjovC/acuu+SwshY7W/h 3mk0GfcWsVBEnFyBk9nIhPY3Iei4lm5nqiiBKfQ/MCM2XTlcOmRv8vLuuZ8eCPKxDAhJJoUjTfj0x YfFPOV2ju87aQ0FqazYCY7tmN709DnHWeRZZSlI3Jwgd6n1HXH4EoThc7LR9+W38nwno7OZuOk4Lx j7i1yEP1V0fGhn2u/QrzzUmEexNRLPnWdcCf2ThWix+p3aezma4k428+dAyv2PjnRlAMd5hysdpdb MtMXX59wc/xBHeG0JYraFVHNOZHBRO6GT9e2GQUOhU9lFgDkVAo1bb4oabE6erKw+ZsVWzZbKACkQ B4i81zO1w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lha8m-008Qyb-D6; Fri, 14 May 2021 15:54:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lha8a-008Qxt-Ez; Fri, 14 May 2021 15:54:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=lYy3GtbVUJISR8ZbLoKmOavLT7 YMoH9yFCmZLb+DDyFRpoGqb/BfItkdmtViL6iRSlxKemTS5/nGqaK2ublAZZ2CxqVRJZymPPdxoiX uxwplpxOeFe12IiAPJyTXBDY90p/iOIxEfN4KxY5HvYTrX913DclBSH3JbGeSA7Hrl46dI6sEakDp v2K/f2UaVCjS6LQrgAHaKSOKRb98jxSV4wW6N00tar4DUKhzx2dzNCZRWzIXOLubuz5hYhf3DjH2p 8kloga1bPpLiuM9+kCEAQSbFc+IwyRnjWg+xpRMZXNkp1XJNx6ZIlNvSxn6gaseYeHXaHC7tiZFQn EL1Pldwg==; Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lha8T-00C5wr-Pu; Fri, 14 May 2021 15:53:59 +0000 Received: by mail-ed1-x532.google.com with SMTP id r11so11179478edt.13; Fri, 14 May 2021 08:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=f5pKrku0e6EM6tOZFoRr8i5ryGCMprW/ArJmi1G1tF1P3P7TB/vGZt6eUZBeYX1OGP 4onTfNm+56vE+G3yKyyomtIVL/0TNH+IF3DEnOwqDIJ0EUpf+yDjVYVMnXLC0j8N9vlB 0LablOmpCVmnbJPG82EWGdqqbeH62hmqq9UT7wSqc5XZut/4D2/BTlqC4eYe0rLabD2v OFQOhntIB1I9aLkzF8xewSXdLpLPngab91x9DAK63/E85M4PiX9uswAdiBkxJTD159me eg2D15l8+0Xts9zanmFZyE/89732PpRS0TuLEsgtcyKUJAca/Yq+j0vuZGPanW1zZSNI 9gOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=jmzHiPshS+e8UmluN/7fXkrWZXgn0nPgMXw1myDReaKv9eerba98Kh7C/c1Dks5NCV DMxThERGp2g1YYMmYaTliEK3uIlA9A3nZAgCI5RUew5Rsp+ibKF4OsSK0VqlUB5jnQas +zzsYAGJyGH56SPsuxUY3DWJwWmR2jRtjjhxOaFggCBXR4HdjNtv7eEEgnxANvbjQ2N+ yANdhzRUA9d259DhKrPmdddKyds1M/uFv1tp+V9IydDu4+79RpIWXOKufGE211U+9kSh 2bjCGXYBnV7K8GwOO6Ed81WJLMR7dkvCXr907TLumFpwSr9i9liRrjnZ4mPmGrFXm0Rm 90cA== X-Gm-Message-State: AOAM5325ENJBQ08eJtUIx8bseYTkWf2HXkT3YyREb18TWf/TYtLE6Szo tBNvrJedXOwxrI+NgvqN3XE= X-Google-Smtp-Source: ABdhPJxiEhDApEu75kJdXXESrqi6t2oBygLR+znc2KM99z8D4A006a1c0919pGQoeo6o0GXD+663Ew== X-Received: by 2002:a05:6402:2753:: with SMTP id z19mr56769103edd.158.1621007635210; Fri, 14 May 2021 08:53:55 -0700 (PDT) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id ks10sm3911610ejb.41.2021.05.14.08.53.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 08:53:54 -0700 (PDT) Subject: Re: [PATCH v2 4/5] dt-bindings: soc: rockchip: grf: add compatible for RK3308 USB grf To: Tobias Schramm , linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org Cc: Rob Herring , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210514150044.2099298-1-t.schramm@manjaro.org> <20210514150044.2099298-5-t.schramm@manjaro.org> From: Johan Jonker Message-ID: Date: Fri, 14 May 2021 17:53:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210514150044.2099298-5-t.schramm@manjaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_085357_875068_F0F750F0 X-CRM114-Status: GOOD ( 18.70 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Tobias, The grf serie is currently still under review. So things can change. Must add a change log below a "---" in the commit message for rob+dt. Maybe add a patch that fixes the reg size of "rockchip,rk3308-grf" as well? Johan On 5/14/21 5:00 PM, Tobias Schramm wrote: > The RK3308 has a USB GRF. > This patch adds a compatible string for it. > > Signed-off-by: Tobias Schramm > --- > Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > index 84bdaf88d5a6..df77bd2e6752 100644 > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > @@ -30,6 +30,7 @@ properties: > - rockchip,rk3288-grf > - rockchip,rk3308-core-grf > - rockchip,rk3308-detect-grf > + - rockchip,rk3308-usb2phy-grf > - rockchip,rk3308-grf Sort alphabetically. > - rockchip,rk3328-grf > - rockchip,rk3328-usb2phy-grf > Also allow usb2-phy as sub nodes name. + - if: + properties: + compatible: + contains: + enum: + - rockchip,px30-usb2phy-grf + - rockchip,rk3228-grf - rockchip,rk3308-usb2phy-grf + - rockchip,rk3328-usb2phy-grf + - rockchip,rk3399-grf + - rockchip,rv1108-grf + + then: + required: + - "#address-cells" + - "#size-cells" + + patternProperties: + "usb2-phy@[0-9a-f]+$": + type: object + + $ref: "/schemas/phy/phy-rockchip-inno-usb2.yaml#" + + unevaluatedProperties: false === Heiko's sort rules: compatible reg interrupts [alphabetical] status [if needed] === Sort #phy-cells below interrupt-names. + #phy-cells = <0>; + interrupts = ; + interrupt-names = "linestate"; _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1EBCC433ED for ; Fri, 14 May 2021 15:56:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4300F61444 for ; Fri, 14 May 2021 15:56:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4300F61444 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2/5IG6i9HrLobzQY3tcsOWYMzd78vNheh1WEpdhaYpo=; b=i9ojwlFLOWtVU1vemVLepR55I RK4OqCycs0X8JqGq6b/7Qz6fM5zHIl7DV3GqrKONQcTcBj/zzvQadILA6p9WU/e53UFal9D/9cDQI SGzzzk7JzaGeYUyo/7lOpTp6CYZiZj9FRJC9Sw+15RcAIddefY/ORlV2tQus/fQ4abHiSobSDyEG6 HEdctVEqtF6taBKVz/9qhuwHhO6LoU1cy8E9x9SGGPFPCKJWp2kAmf+EgSm5Am9JfsW/K03OLrbH1 IsKTTNklzMzS7I0W7L/OieeEhFxqxXnCAmRWsZAOx6YDwZGA+0vCdWYjBftg86sR2EhJiw2Y+uCVR +HVAv3EKg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lha8d-008QyI-9I; Fri, 14 May 2021 15:54:07 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lha8a-008Qxt-Ez; Fri, 14 May 2021 15:54:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=lYy3GtbVUJISR8ZbLoKmOavLT7 YMoH9yFCmZLb+DDyFRpoGqb/BfItkdmtViL6iRSlxKemTS5/nGqaK2ublAZZ2CxqVRJZymPPdxoiX uxwplpxOeFe12IiAPJyTXBDY90p/iOIxEfN4KxY5HvYTrX913DclBSH3JbGeSA7Hrl46dI6sEakDp v2K/f2UaVCjS6LQrgAHaKSOKRb98jxSV4wW6N00tar4DUKhzx2dzNCZRWzIXOLubuz5hYhf3DjH2p 8kloga1bPpLiuM9+kCEAQSbFc+IwyRnjWg+xpRMZXNkp1XJNx6ZIlNvSxn6gaseYeHXaHC7tiZFQn EL1Pldwg==; Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lha8T-00C5wr-Pu; Fri, 14 May 2021 15:53:59 +0000 Received: by mail-ed1-x532.google.com with SMTP id r11so11179478edt.13; Fri, 14 May 2021 08:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=f5pKrku0e6EM6tOZFoRr8i5ryGCMprW/ArJmi1G1tF1P3P7TB/vGZt6eUZBeYX1OGP 4onTfNm+56vE+G3yKyyomtIVL/0TNH+IF3DEnOwqDIJ0EUpf+yDjVYVMnXLC0j8N9vlB 0LablOmpCVmnbJPG82EWGdqqbeH62hmqq9UT7wSqc5XZut/4D2/BTlqC4eYe0rLabD2v OFQOhntIB1I9aLkzF8xewSXdLpLPngab91x9DAK63/E85M4PiX9uswAdiBkxJTD159me eg2D15l8+0Xts9zanmFZyE/89732PpRS0TuLEsgtcyKUJAca/Yq+j0vuZGPanW1zZSNI 9gOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=jmzHiPshS+e8UmluN/7fXkrWZXgn0nPgMXw1myDReaKv9eerba98Kh7C/c1Dks5NCV DMxThERGp2g1YYMmYaTliEK3uIlA9A3nZAgCI5RUew5Rsp+ibKF4OsSK0VqlUB5jnQas +zzsYAGJyGH56SPsuxUY3DWJwWmR2jRtjjhxOaFggCBXR4HdjNtv7eEEgnxANvbjQ2N+ yANdhzRUA9d259DhKrPmdddKyds1M/uFv1tp+V9IydDu4+79RpIWXOKufGE211U+9kSh 2bjCGXYBnV7K8GwOO6Ed81WJLMR7dkvCXr907TLumFpwSr9i9liRrjnZ4mPmGrFXm0Rm 90cA== X-Gm-Message-State: AOAM5325ENJBQ08eJtUIx8bseYTkWf2HXkT3YyREb18TWf/TYtLE6Szo tBNvrJedXOwxrI+NgvqN3XE= X-Google-Smtp-Source: ABdhPJxiEhDApEu75kJdXXESrqi6t2oBygLR+znc2KM99z8D4A006a1c0919pGQoeo6o0GXD+663Ew== X-Received: by 2002:a05:6402:2753:: with SMTP id z19mr56769103edd.158.1621007635210; Fri, 14 May 2021 08:53:55 -0700 (PDT) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id ks10sm3911610ejb.41.2021.05.14.08.53.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 08:53:54 -0700 (PDT) Subject: Re: [PATCH v2 4/5] dt-bindings: soc: rockchip: grf: add compatible for RK3308 USB grf To: Tobias Schramm , linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org Cc: Rob Herring , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210514150044.2099298-1-t.schramm@manjaro.org> <20210514150044.2099298-5-t.schramm@manjaro.org> From: Johan Jonker Message-ID: Date: Fri, 14 May 2021 17:53:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210514150044.2099298-5-t.schramm@manjaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_085357_875068_F0F750F0 X-CRM114-Status: GOOD ( 18.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tobias, The grf serie is currently still under review. So things can change. Must add a change log below a "---" in the commit message for rob+dt. Maybe add a patch that fixes the reg size of "rockchip,rk3308-grf" as well? Johan On 5/14/21 5:00 PM, Tobias Schramm wrote: > The RK3308 has a USB GRF. > This patch adds a compatible string for it. > > Signed-off-by: Tobias Schramm > --- > Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > index 84bdaf88d5a6..df77bd2e6752 100644 > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > @@ -30,6 +30,7 @@ properties: > - rockchip,rk3288-grf > - rockchip,rk3308-core-grf > - rockchip,rk3308-detect-grf > + - rockchip,rk3308-usb2phy-grf > - rockchip,rk3308-grf Sort alphabetically. > - rockchip,rk3328-grf > - rockchip,rk3328-usb2phy-grf > Also allow usb2-phy as sub nodes name. + - if: + properties: + compatible: + contains: + enum: + - rockchip,px30-usb2phy-grf + - rockchip,rk3228-grf - rockchip,rk3308-usb2phy-grf + - rockchip,rk3328-usb2phy-grf + - rockchip,rk3399-grf + - rockchip,rv1108-grf + + then: + required: + - "#address-cells" + - "#size-cells" + + patternProperties: + "usb2-phy@[0-9a-f]+$": + type: object + + $ref: "/schemas/phy/phy-rockchip-inno-usb2.yaml#" + + unevaluatedProperties: false === Heiko's sort rules: compatible reg interrupts [alphabetical] status [if needed] === Sort #phy-cells below interrupt-names. + #phy-cells = <0>; + interrupts = ; + interrupt-names = "linestate"; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1050BC433B4 for ; Fri, 14 May 2021 15:54:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FB9661446 for ; Fri, 14 May 2021 15:54:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FB9661446 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hziBtGnkzPN280/L6w9oA8rGRdTKCe4YcihqRgU/m9I=; b=EQwLUT5T6zBLBe8Du7ND15mXC 0+eV2C4XtiLaOrhCCKtkmw6H4kuLZPsv6c+BfuzVawomeNogehD/oLToLOYeuJHVYh10OtwNbIgZY Mq8y5qbCBAiLHmSK5ZxnqqSvaQKEFQNwdT1SKok478uukKNBuF0RRN7D/3dyrnoWOJzd7o7ND0S9h DPr2I9jAMvOvgEPgbczkO3+edPIJXFmbV5DP72tp/f52wp87lESQmQN85+PIBhf8P/C+2gnQnfKLL sJcicMF/Zpvl/dRNUyq/Sb+W0kNwXHh0MAv/pdX1rQILe5Vt+IHHTPQIksS16458Urvx6tCkipHD0 DNr24PDsg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lha8m-008QyW-1z; Fri, 14 May 2021 15:54:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lha8a-008Qxt-Ez; Fri, 14 May 2021 15:54:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=lYy3GtbVUJISR8ZbLoKmOavLT7 YMoH9yFCmZLb+DDyFRpoGqb/BfItkdmtViL6iRSlxKemTS5/nGqaK2ublAZZ2CxqVRJZymPPdxoiX uxwplpxOeFe12IiAPJyTXBDY90p/iOIxEfN4KxY5HvYTrX913DclBSH3JbGeSA7Hrl46dI6sEakDp v2K/f2UaVCjS6LQrgAHaKSOKRb98jxSV4wW6N00tar4DUKhzx2dzNCZRWzIXOLubuz5hYhf3DjH2p 8kloga1bPpLiuM9+kCEAQSbFc+IwyRnjWg+xpRMZXNkp1XJNx6ZIlNvSxn6gaseYeHXaHC7tiZFQn EL1Pldwg==; Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lha8T-00C5wr-Pu; Fri, 14 May 2021 15:53:59 +0000 Received: by mail-ed1-x532.google.com with SMTP id r11so11179478edt.13; Fri, 14 May 2021 08:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=f5pKrku0e6EM6tOZFoRr8i5ryGCMprW/ArJmi1G1tF1P3P7TB/vGZt6eUZBeYX1OGP 4onTfNm+56vE+G3yKyyomtIVL/0TNH+IF3DEnOwqDIJ0EUpf+yDjVYVMnXLC0j8N9vlB 0LablOmpCVmnbJPG82EWGdqqbeH62hmqq9UT7wSqc5XZut/4D2/BTlqC4eYe0rLabD2v OFQOhntIB1I9aLkzF8xewSXdLpLPngab91x9DAK63/E85M4PiX9uswAdiBkxJTD159me eg2D15l8+0Xts9zanmFZyE/89732PpRS0TuLEsgtcyKUJAca/Yq+j0vuZGPanW1zZSNI 9gOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nJjqUh+eedhnbrR//6OaBv5/ZsdN4XZOU4mhcsRuoyg=; b=jmzHiPshS+e8UmluN/7fXkrWZXgn0nPgMXw1myDReaKv9eerba98Kh7C/c1Dks5NCV DMxThERGp2g1YYMmYaTliEK3uIlA9A3nZAgCI5RUew5Rsp+ibKF4OsSK0VqlUB5jnQas +zzsYAGJyGH56SPsuxUY3DWJwWmR2jRtjjhxOaFggCBXR4HdjNtv7eEEgnxANvbjQ2N+ yANdhzRUA9d259DhKrPmdddKyds1M/uFv1tp+V9IydDu4+79RpIWXOKufGE211U+9kSh 2bjCGXYBnV7K8GwOO6Ed81WJLMR7dkvCXr907TLumFpwSr9i9liRrjnZ4mPmGrFXm0Rm 90cA== X-Gm-Message-State: AOAM5325ENJBQ08eJtUIx8bseYTkWf2HXkT3YyREb18TWf/TYtLE6Szo tBNvrJedXOwxrI+NgvqN3XE= X-Google-Smtp-Source: ABdhPJxiEhDApEu75kJdXXESrqi6t2oBygLR+znc2KM99z8D4A006a1c0919pGQoeo6o0GXD+663Ew== X-Received: by 2002:a05:6402:2753:: with SMTP id z19mr56769103edd.158.1621007635210; Fri, 14 May 2021 08:53:55 -0700 (PDT) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id ks10sm3911610ejb.41.2021.05.14.08.53.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 08:53:54 -0700 (PDT) Subject: Re: [PATCH v2 4/5] dt-bindings: soc: rockchip: grf: add compatible for RK3308 USB grf To: Tobias Schramm , linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org Cc: Rob Herring , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210514150044.2099298-1-t.schramm@manjaro.org> <20210514150044.2099298-5-t.schramm@manjaro.org> From: Johan Jonker Message-ID: Date: Fri, 14 May 2021 17:53:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210514150044.2099298-5-t.schramm@manjaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_085357_875068_F0F750F0 X-CRM114-Status: GOOD ( 18.70 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Tobias, The grf serie is currently still under review. So things can change. Must add a change log below a "---" in the commit message for rob+dt. Maybe add a patch that fixes the reg size of "rockchip,rk3308-grf" as well? Johan On 5/14/21 5:00 PM, Tobias Schramm wrote: > The RK3308 has a USB GRF. > This patch adds a compatible string for it. > > Signed-off-by: Tobias Schramm > --- > Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > index 84bdaf88d5a6..df77bd2e6752 100644 > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > @@ -30,6 +30,7 @@ properties: > - rockchip,rk3288-grf > - rockchip,rk3308-core-grf > - rockchip,rk3308-detect-grf > + - rockchip,rk3308-usb2phy-grf > - rockchip,rk3308-grf Sort alphabetically. > - rockchip,rk3328-grf > - rockchip,rk3328-usb2phy-grf > Also allow usb2-phy as sub nodes name. + - if: + properties: + compatible: + contains: + enum: + - rockchip,px30-usb2phy-grf + - rockchip,rk3228-grf - rockchip,rk3308-usb2phy-grf + - rockchip,rk3328-usb2phy-grf + - rockchip,rk3399-grf + - rockchip,rv1108-grf + + then: + required: + - "#address-cells" + - "#size-cells" + + patternProperties: + "usb2-phy@[0-9a-f]+$": + type: object + + $ref: "/schemas/phy/phy-rockchip-inno-usb2.yaml#" + + unevaluatedProperties: false === Heiko's sort rules: compatible reg interrupts [alphabetical] status [if needed] === Sort #phy-cells below interrupt-names. + #phy-cells = <0>; + interrupts = ; + interrupt-names = "linestate"; -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy