Re: [PATCH v2 3/3] mmc: Add driver for LiteX's LiteSDCard interface

From: Randy Dunlap <rdunlap@infradead.org>
To: Gabriel Somlo <gsomlo@gmail.com>, linux-kernel@vger.kernel.org
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
	ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
	kgugala@antmicro.com, mholenko@antmicro.com,
	krakoczy@antmicro.com, mdudek@internships.antmicro.com,
	paulus@ozlabs.org, joel@jms.id.au, shorne@gmail.com,
	geert@linux-m68k.org, david.abdurachmanov@sifive.com,
	florent@enjoy-digital.fr
Subject: Re: [PATCH v2 3/3] mmc: Add driver for LiteX's LiteSDCard interface
Date: Sat, 4 Dec 2021 12:57:32 -0800	[thread overview]
Message-ID: <e99ad542-14f6-2a06-a83e-c5f4e945303c@infradead.org> (raw)
In-Reply-To: <20211204204121.2367127-4-gsomlo@gmail.com>

Hi Gabriel--

On 12/4/21 12:41, Gabriel Somlo wrote:
> +MODULE_DESCRIPTION("LiteX SDCard driver");
> +MODULE_AUTHOR("Antmicro <www.antmicro.com>");

Admittedly it's not documented, but we would prefer to have some contact info
in MODULE_AUTHOR(), like an email address or a person's name.

<linux/module.h> says:

/*
 * Author(s), use "Name <email>" or just "Name", for multiple
 * authors use multiple MODULE_AUTHOR() statements/lines.
 */
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)

> +MODULE_LICENSE("GPL v2");

Also, it's up to the MMC maintainer (Ulf), but the function signature
style that is used in this driver is not the preferred style.

E.g.:

+static int
+litex_set_bus_width(struct litex_mmc_host *host)
+{

should be

+static int litex_set_bus_width(struct litex_mmc_host *host)
+{

thanks.
-- 
~Randy