From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH v1 2/9] mfd: wm8994: Add support for MCLKn clock control Date: Wed, 18 Sep 2019 15:36:55 +0200 Message-ID: References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-3-s.nawrocki@samsung.com> <49ef7282-3765-9149-285d-a4025417eb58@samsung.com> <20190918125435.GF10204@ediswmail.ad.cirrus.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190918125435.GF10204@ediswmail.ad.cirrus.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Charles Keepax Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, broonie@kernel.org, lgirdwood@gmail.com, krzk@kernel.org, robh+dt@kernel.org, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com List-Id: devicetree@vger.kernel.org On 9/18/19 14:54, Charles Keepax wrote: >>> + ret = devm_clk_bulk_get_optional(wm8994->dev, ARRAY_SIZE(wm8994->mclk), >>> + wm8994->mclk); >>> + if (ret != 0) >>> + return ret; > > Would be nice to print a message here as well, make it clear what > failed in the log. Apart from that minor nit: Thanks for reviewing, I will add that modification for v2. -- Regards, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F805C4CEC9 for ; Wed, 18 Sep 2019 13:38:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB9AF20856 for ; Wed, 18 Sep 2019 13:37:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ZZ1dnGLT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="iirerxl9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB9AF20856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EFA921677; Wed, 18 Sep 2019 15:37:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EFA921677 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568813877; bh=InK8cWdLsw5NV4xPJClMTm2wUBbdQyr92IZoq49lerY=; h=To:From:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZZ1dnGLTXUcyJUz/4JPi7rySRu1H6WkymWhQVZjbHgVh4QxLkcPymVkG6M7uzOlFp 3ymA5wYwDZ43tpoTC+6kjbJtPSETf9bWRih9sMQIAaeHPxVQkvQU6uizWlS3tJlah6 lUyllpnDVWQPt6dhnxu+cD7k4epK/v51IjUcJWoM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 830BCF804FF; Wed, 18 Sep 2019 15:37:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 63E55F80506; Wed, 18 Sep 2019 15:37:04 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9B918F80146 for ; Wed, 18 Sep 2019 15:37:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9B918F80146 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="iirerxl9" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190918133659euoutp011cca23750d842158ca53706f12ef8e26~Fi9tA9Jnw1183311833euoutp01i for ; Wed, 18 Sep 2019 13:36:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190918133659euoutp011cca23750d842158ca53706f12ef8e26~Fi9tA9Jnw1183311833euoutp01i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1568813819; bh=YwlvZ5lX/q4VkLEO16j7x4girsc6K66AK26JC0JlpFo=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=iirerxl9UKrAyOMptZQviuMceGE91F+/gedY9Y38rhd8eisugbHEj4p8nOHvUtcNE be3+8T/TPlCHVP4I24DwBe4332H7eZU5jIzAiB0/eR6g/l9k5njQMmq/6j39NifKX/ bRqTAbvyPBsCWgXVikyASdYLjJyW9PM7lu/BcNgs= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190918133658eucas1p11f720977a321b39d052268296184b6aa~Fi9sethIz1988419884eucas1p1o; Wed, 18 Sep 2019 13:36:58 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id D2.8D.04374.AF2328D5; Wed, 18 Sep 2019 14:36:58 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190918133657eucas1p27e58bdca99c69c824fc04b036300a127~Fi9rsJCbQ2092820928eucas1p2x; Wed, 18 Sep 2019 13:36:57 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190918133657eusmtrp2388a1c07e51b9b64131e748bee829b64~Fi9rcDJWk3244532445eusmtrp2T; Wed, 18 Sep 2019 13:36:57 +0000 (GMT) X-AuditID: cbfec7f5-4f7ff70000001116-d8-5d8232fa5c9e Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C4.4D.04166.9F2328D5; Wed, 18 Sep 2019 14:36:57 +0100 (BST) Received: from [106.120.51.75] (unknown [106.120.51.75]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190918133656eusmtip2d0e86b1d2bce3fc84646bc9522cca37d~Fi9qu70bx2274022740eusmtip2U; Wed, 18 Sep 2019 13:36:56 +0000 (GMT) To: Charles Keepax From: Sylwester Nawrocki Message-ID: Date: Wed, 18 Sep 2019 15:36:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190918125435.GF10204@ediswmail.ad.cirrus.com> Content-Language: en-GB X-Brightmail-Tracker: H4sIAAAAAAAAA01SbUhTYRjtvR+7d6vpdSo+mBmMLJKy/IAufUhRP64QFfSnjJUzryap0101 NUJZVH5rQWrLWpGgDaptzdJKK3UtDVwDsfUhGopIoaXOsqzM7Rr57zznOec9z4GXxhUDZDCd mpHNazPUaUqJjHjw4kfvxp9ROtXmqT6K7XN2YKy57h7JXv44ImH7zlkQa+jqJVmHw0SxgzM2 xH7rK8ZYy3A/ydY52jH2TtcAxU5/eUqy59q6KNbZ5MZ2+nCmaZ2Ea9UPUJzFWCLhPvQ/kXD3 Gwq52vp5xFVajYibtoQeoONl25P4tNRcXrspNkF2Ys48RWRW4Xk/P1+iilALVoqkNDAxYHY5 JKVIRiuYJgQNJj0pDm4E1pleShymERgaDeifpbtm1osVTCOCuYfxomgcQcn1OcKz8Gf2wuWi PxIPDmCiYNL+DvOIcMaFwQVnqTdcwkRCha3S+5KciYXmRrPXTDBh0HT1Ju7BgcwhmBrqJEWN H3RfGfFqpMwO0D23eQNwJgh07tukiFfDw/F63BMGzG8K7t6axMWz98A3m3OxtT98slspEYfA fKsBEw1nEZQ/fk+JQzWCQfuNxdLboNPuXIigFyLWw71Hm0R6F/RUujAPDYwPuMb9xCN84NKD Wlyk5VB8XiGq18CcsXbxhGAoG5knqpFSv6Safkkd/ZI6+v+5NxBhREF8jpCewgvRGfypCEGd LuRkpEQc16Rb0MKne/XHPtOC2n8ldiCGRsoV8tl1OpWCVOcK+ekdCGhcGSA/cKZQpZAnqfML eK3mmDYnjRc60EqaUAbJTy8bOqJgUtTZ/Emez+S1/7YYLQ0uQn6qrTVEfM/Fg/Wr9r1NGLWx E7LAhisxYVkBY3Wu1kRN+3B5m+Zk6evVjqSjccmV4XlbEqsq9rt93zS/SpX2PLtwKN80xoWO 3vx92D1qfZncVtA9FLihN1JfFjYUqyQL2qQTWc7vX90hEWsjQ6M5zR1ZRNzsNl9/n2utvmsa dhcuVxLCCXVkOK4V1H8BGp1arnADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsVy+t/xe7o/jZpiDXo38lpcuXiIyWLjjPWs FlMfPmGzuNK6idFi/pFzrBbnz29gt7j/9SijxbcrHUwWmx5fY7WYcX4fk8XaI3fZLT6/389q 0br3CLvFxRVfmBz4PDZ8bmLz2DnrLrvHplWdbB53ru1h89i8pN5j+pz/jB59W1YxenzeJBfA EaVnU5RfWpKqkJFfXGKrFG1oYaRnaGmhZ2RiqWdobB5rZWSqpG9nk5Kak1mWWqRvl6CX8Xvj J5aCfuaKX68nsTcw7mDqYuTkkBAwkTg57QdjFyMXh5DAUkaJziNzWbsYOYASUhLzW5QgaoQl /lzrYoOoec0o0bV6NiNIQljAR2Jqwz82EFtEwEji4/FbTCBFzAI3mCSmLLsPNXUlk8SstZ1g HWwChhK9R/vAbF4BO4mtyzeygNgsAqoSK2YvZAaxRQUiJA7vmAVVIyhxcuYTsBpOAVuJpoNH wbYxC6hL/Jl3iRnCFpdo+rKSFcKWl9j+dg7zBEahWUjaZyFpmYWkZRaSlgWMLKsYRVJLi3PT c4sN9YoTc4tL89L1kvNzNzECI3vbsZ+bdzBe2hh8iFGAg1GJh/eHelOsEGtiWXFl7iFGCQ5m JRHegNr6WCHelMTKqtSi/Pii0pzU4kOMpkDPTWSWEk3OByadvJJ4Q1NDcwtLQ3Njc2MzCyVx 3g6BgzFCAumJJanZqakFqUUwfUwcnFINjB2OwXu78oTzi/nNhB96VXKLSehfYApgvORpZ7Cz 4kU8+9uMI7WTb7XG/Qntlsp48KR5m1Pjmu32xdwlaiLuotbTDtq2uukll9voP5w4Oc9R0+yK 2TExAbY9Zz2Sc4IubLNrjLN+Z9In4maypDGr5+W8fSYsbUIns3Kemj44xBZ0fsNfh3IlluKM REMt5qLiRABLjxF4AgMAAA== X-CMS-MailID: 20190918133657eucas1p27e58bdca99c69c824fc04b036300a127 X-Msg-Generator: CA X-RootMTR: 20190918104656eucas1p1d9cad1394b08d05a99151c4fbc9425ce X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190918104656eucas1p1d9cad1394b08d05a99151c4fbc9425ce References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-3-s.nawrocki@samsung.com> <49ef7282-3765-9149-285d-a4025417eb58@samsung.com> <20190918125435.GF10204@ediswmail.ad.cirrus.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, broonie@kernel.org, lgirdwood@gmail.com, krzk@kernel.org, robh+dt@kernel.org, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Subject: Re: [alsa-devel] [PATCH v1 2/9] mfd: wm8994: Add support for MCLKn clock control X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 9/18/19 14:54, Charles Keepax wrote: >>> + ret = devm_clk_bulk_get_optional(wm8994->dev, ARRAY_SIZE(wm8994->mclk), >>> + wm8994->mclk); >>> + if (ret != 0) >>> + return ret; > > Would be nice to print a message here as well, make it clear what > failed in the log. Apart from that minor nit: Thanks for reviewing, I will add that modification for v2. -- Regards, Sylwester _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C02C4CEC4 for ; Wed, 18 Sep 2019 13:37:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1FBD20856 for ; Wed, 18 Sep 2019 13:37:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="swkeYG5z"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="iirerxl9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1FBD20856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:MIME-Version: Date:Message-ID:From:To:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9yEiXIMHDMzbmZFYMk6pYrJHu1KxrPode1cadSQ/gzs=; b=swkeYG5zOKYifF k1devBvoMdz8DBadKmrSsZxoNdky32jjiqExOgl6WIQcE+JJ5eyEllk1qpSGvHd035TvsyWI+YakJ s28lw1X9Q9epMiGaLIijF7hk97UQkUIEjQlREe30f7nnwgauIWAZVzusZBBDKY/jwzENGy37QEqNF AhStDHUOH6OJub0KHvK4dkx6lZSJhJ2e46z1EtvJQ0ds7HmGblFqsmwh/oDFAJl9rw2AfXZxvg/2i P0ncxOLTpAM2U2qrR0sKhCOoQ29iVwjZTP7nP09xlOq/kpHauGVyujrDAhR7t3fbNtudgwI1RVTVH S5qJ+Fnz0T+L0yvB76Ug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAa8m-0004zq-Ot; Wed, 18 Sep 2019 13:37:04 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAa8j-0004zM-SO for linux-arm-kernel@lists.infradead.org; Wed, 18 Sep 2019 13:37:03 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190918133659euoutp01cae1de5367e3cc5837e2504b88005a7b~Fi9tI3npJ1202312023euoutp01J for ; Wed, 18 Sep 2019 13:36:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190918133659euoutp01cae1de5367e3cc5837e2504b88005a7b~Fi9tI3npJ1202312023euoutp01J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1568813819; bh=YwlvZ5lX/q4VkLEO16j7x4girsc6K66AK26JC0JlpFo=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=iirerxl9UKrAyOMptZQviuMceGE91F+/gedY9Y38rhd8eisugbHEj4p8nOHvUtcNE be3+8T/TPlCHVP4I24DwBe4332H7eZU5jIzAiB0/eR6g/l9k5njQMmq/6j39NifKX/ bRqTAbvyPBsCWgXVikyASdYLjJyW9PM7lu/BcNgs= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190918133658eucas1p11f720977a321b39d052268296184b6aa~Fi9sethIz1988419884eucas1p1o; Wed, 18 Sep 2019 13:36:58 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id D2.8D.04374.AF2328D5; Wed, 18 Sep 2019 14:36:58 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190918133657eucas1p27e58bdca99c69c824fc04b036300a127~Fi9rsJCbQ2092820928eucas1p2x; Wed, 18 Sep 2019 13:36:57 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190918133657eusmtrp2388a1c07e51b9b64131e748bee829b64~Fi9rcDJWk3244532445eusmtrp2T; Wed, 18 Sep 2019 13:36:57 +0000 (GMT) X-AuditID: cbfec7f5-4f7ff70000001116-d8-5d8232fa5c9e Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C4.4D.04166.9F2328D5; Wed, 18 Sep 2019 14:36:57 +0100 (BST) Received: from [106.120.51.75] (unknown [106.120.51.75]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190918133656eusmtip2d0e86b1d2bce3fc84646bc9522cca37d~Fi9qu70bx2274022740eusmtip2U; Wed, 18 Sep 2019 13:36:56 +0000 (GMT) Subject: Re: [PATCH v1 2/9] mfd: wm8994: Add support for MCLKn clock control To: Charles Keepax From: Sylwester Nawrocki Message-ID: Date: Wed, 18 Sep 2019 15:36:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190918125435.GF10204@ediswmail.ad.cirrus.com> Content-Language: en-GB X-Brightmail-Tracker: H4sIAAAAAAAAA01SbUhTYRjtvR+7d6vpdSo+mBmMLJKy/IAufUhRP64QFfSnjJUzryap0101 NUJZVH5rQWrLWpGgDaptzdJKK3UtDVwDsfUhGopIoaXOsqzM7Rr57zznOec9z4GXxhUDZDCd mpHNazPUaUqJjHjw4kfvxp9ROtXmqT6K7XN2YKy57h7JXv44ImH7zlkQa+jqJVmHw0SxgzM2 xH7rK8ZYy3A/ydY52jH2TtcAxU5/eUqy59q6KNbZ5MZ2+nCmaZ2Ea9UPUJzFWCLhPvQ/kXD3 Gwq52vp5xFVajYibtoQeoONl25P4tNRcXrspNkF2Ys48RWRW4Xk/P1+iilALVoqkNDAxYHY5 JKVIRiuYJgQNJj0pDm4E1pleShymERgaDeifpbtm1osVTCOCuYfxomgcQcn1OcKz8Gf2wuWi PxIPDmCiYNL+DvOIcMaFwQVnqTdcwkRCha3S+5KciYXmRrPXTDBh0HT1Ju7BgcwhmBrqJEWN H3RfGfFqpMwO0D23eQNwJgh07tukiFfDw/F63BMGzG8K7t6axMWz98A3m3OxtT98slspEYfA fKsBEw1nEZQ/fk+JQzWCQfuNxdLboNPuXIigFyLWw71Hm0R6F/RUujAPDYwPuMb9xCN84NKD Wlyk5VB8XiGq18CcsXbxhGAoG5knqpFSv6Safkkd/ZI6+v+5NxBhREF8jpCewgvRGfypCEGd LuRkpEQc16Rb0MKne/XHPtOC2n8ldiCGRsoV8tl1OpWCVOcK+ekdCGhcGSA/cKZQpZAnqfML eK3mmDYnjRc60EqaUAbJTy8bOqJgUtTZ/Emez+S1/7YYLQ0uQn6qrTVEfM/Fg/Wr9r1NGLWx E7LAhisxYVkBY3Wu1kRN+3B5m+Zk6evVjqSjccmV4XlbEqsq9rt93zS/SpX2PLtwKN80xoWO 3vx92D1qfZncVtA9FLihN1JfFjYUqyQL2qQTWc7vX90hEWsjQ6M5zR1ZRNzsNl9/n2utvmsa dhcuVxLCCXVkOK4V1H8BGp1arnADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsVy+t/xe7o/jZpiDXo38lpcuXiIyWLjjPWs FlMfPmGzuNK6idFi/pFzrBbnz29gt7j/9SijxbcrHUwWmx5fY7WYcX4fk8XaI3fZLT6/389q 0br3CLvFxRVfmBz4PDZ8bmLz2DnrLrvHplWdbB53ru1h89i8pN5j+pz/jB59W1YxenzeJBfA EaVnU5RfWpKqkJFfXGKrFG1oYaRnaGmhZ2RiqWdobB5rZWSqpG9nk5Kak1mWWqRvl6CX8Xvj J5aCfuaKX68nsTcw7mDqYuTkkBAwkTg57QdjFyMXh5DAUkaJziNzWbsYOYASUhLzW5QgaoQl /lzrYoOoec0o0bV6NiNIQljAR2Jqwz82EFtEwEji4/FbTCBFzAI3mCSmLLsPNXUlk8SstZ1g HWwChhK9R/vAbF4BO4mtyzeygNgsAqoSK2YvZAaxRQUiJA7vmAVVIyhxcuYTsBpOAVuJpoNH wbYxC6hL/Jl3iRnCFpdo+rKSFcKWl9j+dg7zBEahWUjaZyFpmYWkZRaSlgWMLKsYRVJLi3PT c4sN9YoTc4tL89L1kvNzNzECI3vbsZ+bdzBe2hh8iFGAg1GJh/eHelOsEGtiWXFl7iFGCQ5m JRHegNr6WCHelMTKqtSi/Pii0pzU4kOMpkDPTWSWEk3OByadvJJ4Q1NDcwtLQ3Njc2MzCyVx 3g6BgzFCAumJJanZqakFqUUwfUwcnFINjB2OwXu78oTzi/nNhB96VXKLSehfYApgvORpZ7Cz 4kU8+9uMI7WTb7XG/Qntlsp48KR5m1Pjmu32xdwlaiLuotbTDtq2uukll9voP5w4Oc9R0+yK 2TExAbY9Zz2Sc4IubLNrjLN+Z9In4maypDGr5+W8fSYsbUIns3Kemj44xBZ0fsNfh3IlluKM REMt5qLiRABLjxF4AgMAAA== X-CMS-MailID: 20190918133657eucas1p27e58bdca99c69c824fc04b036300a127 X-Msg-Generator: CA X-RootMTR: 20190918104656eucas1p1d9cad1394b08d05a99151c4fbc9425ce X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190918104656eucas1p1d9cad1394b08d05a99151c4fbc9425ce References: <20190918104634.15216-1-s.nawrocki@samsung.com> <20190918104634.15216-3-s.nawrocki@samsung.com> <49ef7282-3765-9149-285d-a4025417eb58@samsung.com> <20190918125435.GF10204@ediswmail.ad.cirrus.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190918_063702_296841_4132F4EF X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, sbkim73@samsung.com, patches@opensource.cirrus.com, broonie@kernel.org, lgirdwood@gmail.com, krzk@kernel.org, robh+dt@kernel.org, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/18/19 14:54, Charles Keepax wrote: >>> + ret = devm_clk_bulk_get_optional(wm8994->dev, ARRAY_SIZE(wm8994->mclk), >>> + wm8994->mclk); >>> + if (ret != 0) >>> + return ret; > > Would be nice to print a message here as well, make it clear what > failed in the log. Apart from that minor nit: Thanks for reviewing, I will add that modification for v2. -- Regards, Sylwester _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel