From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN in exported functions Date: Tue, 10 Jul 2018 17:19:34 +0100 Message-ID: References: <20180707110526.35822-1-paul.durrant@citrix.com> <20180707110526.35822-4-paul.durrant@citrix.com> <0aecf1d4bca04e88958af7f81e35496f@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fcvMZ-0000AZ-Aj for xen-devel@lists.xenproject.org; Tue, 10 Jul 2018 16:19:39 +0000 In-Reply-To: <0aecf1d4bca04e88958af7f81e35496f@AMSPEX02CL03.citrite.net> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant , "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Stefano Stabellini , Wei Liu , Jun Nakajima , Andrew Cooper , "Tim (Xen.org)" , Julien Grall , Jan Beulich , Ian Jackson List-Id: xen-devel@lists.xenproject.org T24gMDcvMTAvMjAxOCAwNToxOCBQTSwgUGF1bCBEdXJyYW50IHdyb3RlOgo+PiAtLS0tLU9yaWdp bmFsIE1lc3NhZ2UtLS0tLQo+PiBGcm9tOiBHZW9yZ2UgRHVubGFwIFttYWlsdG86Z2VvcmdlLmR1 bmxhcEBjaXRyaXguY29tXQo+PiBTZW50OiAxMCBKdWx5IDIwMTggMTc6MTMKPj4gVG86IFBhdWwg RHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcKPj4gQ2M6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT47IEFuZHJldyBD b29wZXIKPj4gPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVubGFwCj4+IDxH ZW9yZ2UuRHVubGFwQGNpdHJpeC5jb20+OyBJYW4gSmFja3NvbiA8SWFuLkphY2tzb25AY2l0cml4 LmNvbT47IEtvbnJhZAo+PiBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT47 IFN0ZWZhbm8gU3RhYmVsbGluaQo+PiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEp1bGllbiBH cmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+OyBUaW0gKFhlbi5vcmcpCj4+IDx0aW1AeGVuLm9y Zz47IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+OyBKdW4gTmFrYWppbWEKPj4gPGp1bi5u YWthamltYUBpbnRlbC5jb20+OyBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KPj4g U3ViamVjdDogUmU6IFtQQVRDSCB2MiAwMy8xM10gaW9tbXU6IG1ha2UgdXNlIG9mIHR5cGUtc2Fm ZSBCRk4gYW5kIE1GTgo+PiBpbiBleHBvcnRlZCBmdW5jdGlvbnMKPj4KPj4gT24gMDcvMDcvMjAx OCAxMjowNSBQTSwgUGF1bCBEdXJyYW50IHdyb3RlOgo+Pj4gVGhpcyBwYXRjaCBtb2RpZmllcyB0 aGUgZGVjbGFyYXRpb24gb2YgdGhlIGVudHJ5IHBvaW50cyB0byB0aGUgSU9NTVUKPj4+IHN1Yi1z eXN0ZW0gdG8gdXNlIGJmbl90IGFuZCBtZm5fdCBpbiBwbGFjZSBvZiB1bnNpZ25lZCBsb25nLiBB Cj4+IHN1YnNlcXVlbnQKPj4+IHBhdGNoIHdpbGwgc2ltaWxhcmx5IG1vZGlmeSB0aGUgbWV0aG9k cyBpbiB0aGUgaW9tbXVfb3BzIHN0cnVjdHVyZS4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBQYXVs IER1cnJhbnQgPHBhdWwuZHVycmFudEBjaXRyaXguY29tPgo+Pj4gLS0tCj4+PiBDYzogSmFuIEJl dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+Pj4gQ2M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+Cj4+PiBDYzogR2VvcmdlIER1bmxhcCA8R2VvcmdlLkR1bmxhcEBl dS5jaXRyaXguY29tPgo+Pj4gQ2M6IElhbiBKYWNrc29uIDxpYW4uamFja3NvbkBldS5jaXRyaXgu Y29tPgo+Pj4gQ2M6IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNv bT4KPj4+IENjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4+ PiBDYzogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPj4+IENjOiBUaW0gRGVl Z2FuIDx0aW1AeGVuLm9yZz4KPj4+IENjOiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+ Pj4gQ2M6IEp1biBOYWthamltYSA8anVuLm5ha2FqaW1hQGludGVsLmNvbT4KPj4+IENjOiBLZXZp biBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KPj4+IENjOiBHZW9yZ2UgRHVubGFwIDxnZW9y Z2UuZHVubGFwQGV1LmNpdHJpeC5jb20+Cj4+Pgo+Pj4gdjI6Cj4+PiAgLSBBZGRyZXNzZWQgY29t bWVudHMgZnJvbSBKYW4uCj4+PiAgLSBVc2UgaW50ZXJtZWRpYXRlICdmcmFtZScgdmFyaWFibGUg dG8gYXZvaWQgZGlyZWN0bHkgZW5jYXBzdWxhdGluZwo+Pj4gICAgbWZuIG9yIGdmbiB2YWx1ZXMg YXMgYmZucy4KPj4KPj4gQSBjb3VwbGUgb2YgY29tbWVudHMgb24gcGFydGljdWxhciBpbnN0YW5j ZXMuLi4KPj4KPj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvbW0vcDJtLmMgYi94ZW4vYXJj aC94ODYvbW0vcDJtLmMKPj4+IGluZGV4IGM1M2NhYjQ0ZDkuLmNlMTJiY2ZmNDIgMTAwNjQ0Cj4+ PiAtLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLmMKPj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9w Mm0uYwo+Pj4gQEAgLTcxNCw5ICs3MTQsMTIgQEAgcDJtX3JlbW92ZV9wYWdlKHN0cnVjdCBwMm1f ZG9tYWluICpwMm0sCj4+IHVuc2lnbmVkIGxvbmcgZ2ZuX2wsIHVuc2lnbmVkIGxvbmcgbWZuLAo+ Pj4KPj4+ICAgICAgICAgIGlmICggbmVlZF9pb21tdShwMm0tPmRvbWFpbikgKQo+Pj4gICAgICAg ICAgewo+Pj4gKyAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZnJhbWUgPSBtZm47Cj4+PiArICAg ICAgICAgICAgYmZuX3QgYmZuID0gX2JmbihmcmFtZSk7Cj4+PiArCj4+PiAgICAgICAgICAgICAg Zm9yICggaSA9IDA7IGkgPCAoMSA8PCBwYWdlX29yZGVyKTsgaSsrICkKPj4+ICAgICAgICAgICAg ICB7Cj4+PiAtICAgICAgICAgICAgICAgIGludCByZXQgPSBpb21tdV91bm1hcF9wYWdlKHAybS0+ ZG9tYWluLCBtZm4gKyBpKTsKPj4+ICsgICAgICAgICAgICAgICAgaW50IHJldCA9IGlvbW11X3Vu bWFwX3BhZ2UocDJtLT5kb21haW4sIGJmbl9hZGQoYmZuLCBpKSk7Cj4+Cj4+IEhhdmluZyBhICdi Zm4nIHZhcmlhYmxlIGhlcmUgbWFrZXMgc29tZSBzZW5zZSwgYmVjYXVzZSBvdGhlcndpc2UsIGlm IG1mbgo+PiBldmVyIGdldHMgdGhlIG1mbl90IHR5cGUsIHlvdSdsbCBoYXZlCj4+Cj4+ICAgaW9t bXVfdW5tYXBfcGFnZSguLi4gX2JmbihtZm5feChtZm4pK2kpKTsKPj4KPj4gYmVpbmcgYWJsZSB0 byB1c2UgYmZuX2FkZCgpIGlzIG11Y2ggY2xlYW5lci4gIEkgZG9uJ3QgdGhpbmsgdGhlCj4+IGlu dGVybWVkaWF0ZSAnZnJhbWUnIHZhcmlhYmxlIGluIHRoZSBjYXNlLCByZWFsbHkgYWRkcyBhbnl0 aGluZy4KPj4KPj4+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMgYi94ZW4v Y29tbW9uL2dyYW50X3RhYmxlLmMKPj4+IGluZGV4IGQyNjEwZTMyMGMuLmQwOTI2ZDEzZTAgMTAw NjQ0Cj4+PiAtLS0gYS94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKPj4+ICsrKyBiL3hlbi9jb21t b24vZ3JhbnRfdGFibGUuYwo+Pj4gQEAgLTExMzIsNiArMTEzMiw4IEBAIG1hcF9ncmFudF9yZWYo Cj4+PiAgICAgIG5lZWRfaW9tbXUgPSBnbnR0YWJfbmVlZF9pb21tdV9tYXBwaW5nKGxkKTsKPj4+ ICAgICAgaWYgKCBuZWVkX2lvbW11ICkKPj4+ICAgICAgewo+Pj4gKyAgICAgICAgdW5zaWduZWQg bG9uZyBmcmFtZSA9IG1mbl94KG1mbik7Cj4+PiArICAgICAgICBiZm5fdCBiZm4gPSBfYmZuKGZy YW1lKTsKPj4+ICAgICAgICAgIHVuc2lnbmVkIGludCBraW5kOwo+Pj4gICAgICAgICAgaW50IGVy ciA9IDA7Cj4+Pgo+Pj4gQEAgLTExNDQsMTQgKzExNDYsMTMgQEAgbWFwX2dyYW50X3JlZigKPj4+ ICAgICAgICAgICAgICAgIShvbGRfcGluICYgKEdOVFBJTl9oc3R3X21hc2t8R05UUElOX2Rldndf bWFzaykpICkKPj4+ICAgICAgICAgIHsKPj4+ICAgICAgICAgICAgICBpZiAoICEoa2luZCAmIE1B UEtJTkRfV1JJVEUpICkKPj4+IC0gICAgICAgICAgICAgICAgZXJyID0gaW9tbXVfbWFwX3BhZ2Uo bGQsIG1mbl94KG1mbiksIG1mbl94KG1mbiksCj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIElPTU1VRl9yZWFkYWJsZXxJT01NVUZfd3JpdGFibGUpOwo+Pj4gKyAgICAg ICAgICAgICAgICBlcnIgPSBpb21tdV9tYXBfcGFnZShsZCwgYmZuLCBtZm4sCj4+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElPTU1VRl9yZWFkYWJsZSB8IElPTU1VRl93 cml0YWJsZSk7Cj4+PiAgICAgICAgICB9Cj4+PiAgICAgICAgICBlbHNlIGlmICggYWN0X3BpbiAm JiAhb2xkX3BpbiApCj4+PiAgICAgICAgICB7Cj4+PiAgICAgICAgICAgICAgaWYgKCAha2luZCAp Cj4+PiAtICAgICAgICAgICAgICAgIGVyciA9IGlvbW11X21hcF9wYWdlKGxkLCBtZm5feChtZm4p LCBtZm5feChtZm4pLAo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJ T01NVUZfcmVhZGFibGUpOwo+Pj4gKyAgICAgICAgICAgICAgICBlcnIgPSBpb21tdV9tYXBfcGFn ZShsZCwgYmZuLCBtZm4sIElPTU1VRl9yZWFkYWJsZSk7Cj4+Cj4+IEhlcmUncyBhbiBleGFtcGxl IHdoZXJlIEkgdGhpbmsgaGF2aW5nIGFuIGV4dHJhIHZhcmlhYmxlIGlzIHNvbWV3aGF0Cj4+IGRh bmdlcm91cy4gIEJlZm9yZSB0aGlzIGNoYW5nZSwgaXQncyBvYnZpb3VzIHRoYXQgeW91IGhhdmUg YSAxOjEKPj4gbWFwcGluZzsgbm93LCBsb29raW5nIGp1c3QgYXQgdGhpcyBsaW5lLCBpdCdzIG5v dCBvYnZpb3VzIHRoYXQgYmZuID09Cj4+IG1mbi4gIFdvcnNlLCB0aGVyZSdzIGEgcmlzayB0aGF0 IHRoZXJlIHdpbGwgYmUgc29tZSBzb3J0IG9mIGJ1Zwo+PiBpbnRyb2R1Y2VkIHdoaWNoIGNoYW5n ZXMgYmZuLCBzdWNoIHRoYXQgYmZuICE9IG1mbiBhbnltb3JlLgo+Pgo+PiBJZiB5b3UgaGF2ZSB0 byB1c2UgYW4gaW50ZXJtZWRpYXRlIHZhcmlhYmxlIGhlcmUsIHRoaXMgc2hvdWxkIGJlCj4+Cj4+ ICAgaW9tbXVfbWFwX3BhZ2UoLi4uLCBfYmZuKGZyYW1lKSwgX21mbihmcmFtZSksIC4uLik7Cj4+ Cj4+IEJ1dCBJIHJlYWxseSB0aGluawo+Pgo+PiAgIGlvbW11X21hcF9wYWdlKC4uLiwgX2Jmbiht Zm5feChtZm4pKSwgbWZuLCAuLi4pOwo+Pgo+PiBtYWtlcyB0aGUgbW9zdCBzZW5zZSBoZXJlLgo+ IAo+IEhvdyBhYm91dDoKPiAKPiAjZGVmaW5lIG1mbl90b19iZm4obWZuKSAoX2JmbihtZm5feCht Zm4pKQo+IAo+IGlvbW11X21hcF9wYWdlKC4uLiwgbWZuX3RvX2JmbihtZm4pLCBtZm4sIC4uLik7 Cj4gCj4gPwo+IAo+IEkgY2FuIHNpbWlsYXJseSBkZWZpbmUgZ2ZuX3RvX2JmbigpIGZvciBwbGFj ZXMgd2hlcmUgaXQgaXMgbmVlZGVkLgoKVGhhdCB3b3JrcyBmb3IgbWUuCgogLUdlb3JnZQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==