From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Rob Clark <robdclark@gmail.com>,
Archit Taneja <architt@codeaurora.org>
Cc: Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Jonathan Marek <jonathan@marek.ca>,
Yangtao Li <tiny.windzz@gmail.com>,
Nicolas Boichat <drinkcat@chromium.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] drm/msm/dsi: fix off by one in dsi_bus_clk_enable error handling
Date: Sat, 2 Oct 2021 01:47:42 +0300 [thread overview]
Message-ID: <e9aea681-c27a-d3fd-2c2b-1a0486173dbc@linaro.org> (raw)
In-Reply-To: <20211001123409.GG2283@kili>
On 01/10/2021 15:34, Dan Carpenter wrote:
> This disables a lock which wasn't enabled and it does not disable
> the first lock in the array.
>
> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
We should probably switch this to bulk clk api.
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index e269df285136..c86b5090fae6 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -451,7 +451,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host)
>
> return 0;
> err:
> - for (; i > 0; i--)
> + while (--i >= 0)
> clk_disable_unprepare(msm_host->bus_clks[i]);
>
> return ret;
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2021-10-01 22:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 12:33 [PATCH 1/3] drm/msm/dsi: Fix an error code in msm_dsi_modeset_init() Dan Carpenter
2021-10-01 12:34 ` [PATCH 2/3] drm/msm/dsi: fix off by one in dsi_bus_clk_enable error handling Dan Carpenter
2021-10-01 22:47 ` Dmitry Baryshkov [this message]
2021-10-01 12:36 ` [PATCH 3/3] drm/msm/dsi: fix signedness bug in msm_dsi_host_cmd_rx() Dan Carpenter
2021-10-01 22:59 ` Dmitry Baryshkov
2021-10-04 6:18 ` Dan Carpenter
2021-10-04 6:45 ` Dan Carpenter
2021-10-01 22:45 ` [PATCH 1/3] drm/msm/dsi: Fix an error code in msm_dsi_modeset_init() Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9aea681-c27a-d3fd-2c2b-1a0486173dbc@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=tiny.windzz@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.