From mboxrd@z Thu Jan  1 00:00:00 1970
From: kgunda@codeaurora.org
Subject: Re: [PATCH V1 11/15] spmi: spmi-pmic-arb: enable the SPMI interrupt
 as a wakeup source
Date: Thu, 08 Jun 2017 17:00:33 +0530
Message-ID: <e9ce737f3a57f5005e5ca1b53c029d48@codeaurora.org>
References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org>
 <1496147943-25822-12-git-send-email-kgunda@codeaurora.org>
 <20170531171358.GC20170@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from smtp.codeaurora.org ([198.145.29.96]:47692 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750914AbdFHLae (ORCPT
        <rfc822;linux-arm-msm@vger.kernel.org>);
        Thu, 8 Jun 2017 07:30:34 -0400
In-Reply-To: <20170531171358.GC20170@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Abhijeet Dharmapurikar <adharmap@codeaurora.org>, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, David Collins <collinsd@codeaurora.org>, Subbaraman Narayanamurthy <subbaram@codeaurora.org>, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com, Nicholas Troast <ntroast@codeaurora.org>, linux-arm-msm-owner@vger.kernel.org

On 2017-05-31 22:43, Stephen Boyd wrote:
> On 05/30, Kiran Gunda wrote:
>> Currently the SPMI interrupt will not wake the device. Enable this
>> interrupt as a wakeup source.
>> 
>> Signed-off-by: Nicholas Troast <ntroast@codeaurora.org>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>>  drivers/spmi/spmi-pmic-arb.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/spmi/spmi-pmic-arb.c 
>> b/drivers/spmi/spmi-pmic-arb.c
>> index 0deac33..2afe359 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -1140,6 +1140,7 @@ static int spmi_pmic_arb_probe(struct 
>> platform_device *pdev)
>>  	}
>> 
>>  	irq_set_chained_handler_and_data(pa->irq, pmic_arb_chained_irq, pa);
>> +	enable_irq_wake(pa->irq);
> 
> Why don't we do this through an irq_set_wake callback in the
> irqchip? That way, we don't mark this irq as wakeup if any child
> irqs aren't marked as wakeup.
Yes. This looks cleaner. Will change it in the subsequent patch.