From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etv3g-0000li-9n for qemu-devel@nongnu.org; Thu, 08 Mar 2018 07:54:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etv3c-0007fw-95 for qemu-devel@nongnu.org; Thu, 08 Mar 2018 07:54:08 -0500 Received: from smtp.eu.citrix.com ([185.25.65.24]:21463) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1etv3b-0007dE-Vx for qemu-devel@nongnu.org; Thu, 08 Mar 2018 07:54:04 -0500 From: Paul Durrant Date: Thu, 8 Mar 2018 12:53:47 +0000 Message-ID: References: <1520513551-19851-1-git-send-email-igor.druzhinin@citrix.com> In-Reply-To: <1520513551-19851-1-git-send-email-igor.druzhinin@citrix.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Druzhinin , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" Cc: "sstabellini@kernel.org" , Anthony Perard , "mst@redhat.com" , "pbonzini@redhat.com" > -----Original Message----- > From: Igor Druzhinin [mailto:igor.druzhinin@citrix.com] > Sent: 08 March 2018 12:53 > To: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org > Cc: sstabellini@kernel.org; Paul Durrant ; Antho= ny > Perard ; mst@redhat.com; > pbonzini@redhat.com; Igor Druzhinin > Subject: [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save > state >=20 > This should help to avoid problems with accessing the device after > migration/resume without PV drivers. Older systems will acquire > the new record when migrated which should not change their state for > worse. >=20 > Signed-off-by: Igor Druzhinin Reviewed-by: Paul Durrant > --- > hw/i386/xen/xen_pvdevice.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/hw/i386/xen/xen_pvdevice.c b/hw/i386/xen/xen_pvdevice.c > index c093b34..ef22a03 100644 > --- a/hw/i386/xen/xen_pvdevice.c > +++ b/hw/i386/xen/xen_pvdevice.c > @@ -71,6 +71,16 @@ static const MemoryRegionOps xen_pv_mmio_ops =3D { > .endianness =3D DEVICE_LITTLE_ENDIAN, > }; >=20 > +static const VMStateDescription vmstate_xen_pvdevice =3D { > + .name =3D "xen-pvdevice", > + .version_id =3D 1, > + .minimum_version_id =3D 1, > + .fields =3D (VMStateField[]) { > + VMSTATE_PCI_DEVICE(parent_obj, XenPVDevice), > + VMSTATE_END_OF_LIST() > + } > +}; > + > static void xen_pv_realize(PCIDevice *pci_dev, Error **errp) > { > XenPVDevice *d =3D XEN_PV_DEVICE(pci_dev); > @@ -120,6 +130,7 @@ static void xen_pv_class_init(ObjectClass *klass, voi= d > *data) > k->class_id =3D PCI_CLASS_SYSTEM_OTHER; > dc->desc =3D "Xen PV Device"; > dc->props =3D xen_pv_props; > + dc->vmsd =3D &vmstate_xen_pvdevice; > } >=20 > static const TypeInfo xen_pv_type_info =3D { > -- > 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save state Date: Thu, 8 Mar 2018 12:53:47 +0000 Message-ID: References: <1520513551-19851-1-git-send-email-igor.druzhinin@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etv3e-0005Ck-Mx for xen-devel@lists.xenproject.org; Thu, 08 Mar 2018 12:54:06 +0000 In-Reply-To: <1520513551-19851-1-git-send-email-igor.druzhinin@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , "pbonzini@redhat.com" , Igor Druzhinin , "sstabellini@kernel.org" , "mst@redhat.com" List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IElnb3IgRHJ1emhpbmluIFttYWls dG86aWdvci5kcnV6aGluaW5AY2l0cml4LmNvbV0KPiBTZW50OiAwOCBNYXJjaCAyMDE4IDEyOjUz Cj4gVG86IHFlbXUtZGV2ZWxAbm9uZ251Lm9yZzsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnCj4gQ2M6IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc7IFBhdWwgRHVycmFudCA8UGF1bC5EdXJy YW50QGNpdHJpeC5jb20+OyBBbnRob255Cj4gUGVyYXJkIDxhbnRob255LnBlcmFyZEBjaXRyaXgu Y29tPjsgbXN0QHJlZGhhdC5jb207Cj4gcGJvbnppbmlAcmVkaGF0LmNvbTsgSWdvciBEcnV6aGlu aW4gPGlnb3IuZHJ1emhpbmluQGNpdHJpeC5jb20+Cj4gU3ViamVjdDogW1BBVENIXSB4ZW4tcHZk ZXZpY2U6IEludHJvZHVjZSBhIHNpbXBsaXN0aWMgeGVuLXB2ZGV2aWNlIHNhdmUKPiBzdGF0ZQo+ IAo+IFRoaXMgc2hvdWxkIGhlbHAgdG8gYXZvaWQgcHJvYmxlbXMgd2l0aCBhY2Nlc3NpbmcgdGhl IGRldmljZSBhZnRlcgo+IG1pZ3JhdGlvbi9yZXN1bWUgd2l0aG91dCBQViBkcml2ZXJzLiBPbGRl ciBzeXN0ZW1zIHdpbGwgYWNxdWlyZQo+IHRoZSBuZXcgcmVjb3JkIHdoZW4gbWlncmF0ZWQgd2hp Y2ggc2hvdWxkIG5vdCBjaGFuZ2UgdGhlaXIgc3RhdGUgZm9yCj4gd29yc2UuCj4gCj4gU2lnbmVk LW9mZi1ieTogSWdvciBEcnV6aGluaW4gPGlnb3IuZHJ1emhpbmluQGNpdHJpeC5jb20+CgpSZXZp ZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KCj4gLS0tCj4g IGh3L2kzODYveGVuL3hlbl9wdmRldmljZS5jIHwgMTEgKysrKysrKysrKysKPiAgMSBmaWxlIGNo YW5nZWQsIDExIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvaHcvaTM4Ni94ZW4veGVu X3B2ZGV2aWNlLmMgYi9ody9pMzg2L3hlbi94ZW5fcHZkZXZpY2UuYwo+IGluZGV4IGMwOTNiMzQu LmVmMjJhMDMgMTAwNjQ0Cj4gLS0tIGEvaHcvaTM4Ni94ZW4veGVuX3B2ZGV2aWNlLmMKPiArKysg Yi9ody9pMzg2L3hlbi94ZW5fcHZkZXZpY2UuYwo+IEBAIC03MSw2ICs3MSwxNiBAQCBzdGF0aWMg Y29uc3QgTWVtb3J5UmVnaW9uT3BzIHhlbl9wdl9tbWlvX29wcyA9IHsKPiAgICAgIC5lbmRpYW5u ZXNzID0gREVWSUNFX0xJVFRMRV9FTkRJQU4sCj4gIH07Cj4gCj4gK3N0YXRpYyBjb25zdCBWTVN0 YXRlRGVzY3JpcHRpb24gdm1zdGF0ZV94ZW5fcHZkZXZpY2UgPSB7Cj4gKyAgICAubmFtZSA9ICJ4 ZW4tcHZkZXZpY2UiLAo+ICsgICAgLnZlcnNpb25faWQgPSAxLAo+ICsgICAgLm1pbmltdW1fdmVy c2lvbl9pZCA9IDEsCj4gKyAgICAuZmllbGRzID0gKFZNU3RhdGVGaWVsZFtdKSB7Cj4gKyAgICAg ICAgVk1TVEFURV9QQ0lfREVWSUNFKHBhcmVudF9vYmosIFhlblBWRGV2aWNlKSwKPiArICAgICAg ICBWTVNUQVRFX0VORF9PRl9MSVNUKCkKPiArICAgIH0KPiArfTsKPiArCj4gIHN0YXRpYyB2b2lk IHhlbl9wdl9yZWFsaXplKFBDSURldmljZSAqcGNpX2RldiwgRXJyb3IgKiplcnJwKQo+ICB7Cj4g ICAgICBYZW5QVkRldmljZSAqZCA9IFhFTl9QVl9ERVZJQ0UocGNpX2Rldik7Cj4gQEAgLTEyMCw2 ICsxMzAsNyBAQCBzdGF0aWMgdm9pZCB4ZW5fcHZfY2xhc3NfaW5pdChPYmplY3RDbGFzcyAqa2xh c3MsIHZvaWQKPiAqZGF0YSkKPiAgICAgIGstPmNsYXNzX2lkID0gUENJX0NMQVNTX1NZU1RFTV9P VEhFUjsKPiAgICAgIGRjLT5kZXNjID0gIlhlbiBQViBEZXZpY2UiOwo+ICAgICAgZGMtPnByb3Bz ID0geGVuX3B2X3Byb3BzOwo+ICsgICAgZGMtPnZtc2QgPSAmdm1zdGF0ZV94ZW5fcHZkZXZpY2U7 Cj4gIH0KPiAKPiAgc3RhdGljIGNvbnN0IFR5cGVJbmZvIHhlbl9wdl90eXBlX2luZm8gPSB7Cj4g LS0KPiAyLjcuNAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn Cmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=