From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 599CE21138AA1 for ; Thu, 27 Sep 2018 13:04:12 -0700 (PDT) Subject: Re: [RFC workqueue/driver-core PATCH 2/5] async: Add support for queueing on specific NUMA node References: <20180926214433.13512.30289.stgit@localhost.localdomain> <20180926215143.13512.56522.stgit@localhost.localdomain> From: Alexander Duyck Message-ID: Date: Thu, 27 Sep 2018 13:03:11 -0700 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: "Brown, Len" , Linux-pm mailing list , Greg KH , linux-nvdimm , jiangshanlai@gmail.com, Linux Kernel Mailing List , zwisler@kernel.org, Pavel Machek , Tejun Heo , Andrew Morton , "Rafael J. Wysocki" List-ID: On 9/27/2018 12:48 PM, Dan Williams wrote: > On Thu, Sep 27, 2018 at 8:24 AM Alexander Duyck > wrote: > [..] >>>> - * Returns an async_cookie_t that may be used for checkpointing later. >>>> - * @domain may be used in the async_synchronize_*_domain() functions to >>>> - * wait within a certain synchronization domain rather than globally. A >>>> - * synchronization domain is specified via @domain. Note: This function >>>> - * may be called from atomic or non-atomic contexts. >>>> + * Device specific version of async_schedule_near_domain that provides some >>>> + * NUMA awareness based on the device node. >>>> + */ >>>> +async_cookie_t async_schedule_dev_domain(async_func_t func, struct device *dev, >>>> + struct async_domain *domain) >>>> +{ >>>> + return async_schedule_near_domain(func, dev, dev_to_node(dev), domain); >>>> +} >>>> +EXPORT_SYMBOL_GPL(async_schedule_dev_domain); >>> >>> This seems unnecessary and restrictive. Callers may want to pass >>> something other than dev as the parameter to the async function, and >>> dev_to_node() is not on onerous burden to place on callers. >> >> >> That is what async_schedule_near_domain is for, they can call that. The >> "dev" versions of the calls as just supposed to be helpers since one of >> the most common parameters to the async_schedule calls is a device, so I >> thought I would just put together a function that takes care of all this >> for us so I could drop an argument and avoid having to use dev_to_node >> everywhere. > > Yeah, makes sense, I guess I was reacting to the fact that this > expands the number of exports unnecessarily. The other async routines > are exported because they hide internal implementation details of the > async implementation. The async_schedule_dev* helpers can just be > static inline wrappers. I can do them as inline wrappers for the next patch set. Shouldn't be too much of an issue. Thanks. - Alex _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B6DBC43382 for ; Thu, 27 Sep 2018 20:04:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAFF9216E3 for ; Thu, 27 Sep 2018 20:04:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAFF9216E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728272AbeI1CYJ (ORCPT ); Thu, 27 Sep 2018 22:24:09 -0400 Received: from mga03.intel.com ([134.134.136.65]:3626 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727265AbeI1CYJ (ORCPT ); Thu, 27 Sep 2018 22:24:09 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2018 13:04:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,312,1534834800"; d="scan'208";a="87276646" Received: from ahduyck-mobl.amr.corp.intel.com (HELO [10.7.198.153]) ([10.7.198.153]) by orsmga003.jf.intel.com with ESMTP; 27 Sep 2018 13:03:12 -0700 Subject: Re: [RFC workqueue/driver-core PATCH 2/5] async: Add support for queueing on specific NUMA node To: Dan Williams Cc: linux-nvdimm , Greg KH , Linux-pm mailing list , Linux Kernel Mailing List , Tejun Heo , Andrew Morton , "Brown, Len" , Dave Jiang , "Rafael J. Wysocki" , Vishal L Verma , jiangshanlai@gmail.com, Pavel Machek , zwisler@kernel.org References: <20180926214433.13512.30289.stgit@localhost.localdomain> <20180926215143.13512.56522.stgit@localhost.localdomain> From: Alexander Duyck Message-ID: Date: Thu, 27 Sep 2018 13:03:11 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/27/2018 12:48 PM, Dan Williams wrote: > On Thu, Sep 27, 2018 at 8:24 AM Alexander Duyck > wrote: > [..] >>>> - * Returns an async_cookie_t that may be used for checkpointing later. >>>> - * @domain may be used in the async_synchronize_*_domain() functions to >>>> - * wait within a certain synchronization domain rather than globally. A >>>> - * synchronization domain is specified via @domain. Note: This function >>>> - * may be called from atomic or non-atomic contexts. >>>> + * Device specific version of async_schedule_near_domain that provides some >>>> + * NUMA awareness based on the device node. >>>> + */ >>>> +async_cookie_t async_schedule_dev_domain(async_func_t func, struct device *dev, >>>> + struct async_domain *domain) >>>> +{ >>>> + return async_schedule_near_domain(func, dev, dev_to_node(dev), domain); >>>> +} >>>> +EXPORT_SYMBOL_GPL(async_schedule_dev_domain); >>> >>> This seems unnecessary and restrictive. Callers may want to pass >>> something other than dev as the parameter to the async function, and >>> dev_to_node() is not on onerous burden to place on callers. >> >> >> That is what async_schedule_near_domain is for, they can call that. The >> "dev" versions of the calls as just supposed to be helpers since one of >> the most common parameters to the async_schedule calls is a device, so I >> thought I would just put together a function that takes care of all this >> for us so I could drop an argument and avoid having to use dev_to_node >> everywhere. > > Yeah, makes sense, I guess I was reacting to the fact that this > expands the number of exports unnecessarily. The other async routines > are exported because they hide internal implementation details of the > async implementation. The async_schedule_dev* helpers can just be > static inline wrappers. I can do them as inline wrappers for the next patch set. Shouldn't be too much of an issue. Thanks. - Alex