From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29041C433F5 for ; Mon, 20 Sep 2021 17:23:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7549632B4 for ; Mon, 20 Sep 2021 17:23:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D7549632B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:52888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSN1G-00037u-0I for qemu-devel@archiver.kernel.org; Mon, 20 Sep 2021 13:23:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSMwk-0005gK-J0 for qemu-devel@nongnu.org; Mon, 20 Sep 2021 13:19:14 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:36845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSMwj-0007o5-5F for qemu-devel@nongnu.org; Mon, 20 Sep 2021 13:19:14 -0400 Received: by mail-pf1-x432.google.com with SMTP id m26so16907630pff.3 for ; Mon, 20 Sep 2021 10:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=woJgHZi7N6rYoD2Ae814uyqjx/dO79FR/f7QzPar1zU=; b=LUTSNWWGPonY2AR2lbZFdBiL6VzSGuB/HkgjNi81XJqs50IOclOIjjsr4IIe/wew1e vg5kXLYk4kjDluSiWQdMfG2sHh90ONoZcPTic6u4PqWq+N1PGPyw55vzYVTx8+j66BVw S2X+vYgETkQp8LVl/ka8CqoA5VKFPiqphAUTpp5scqautH9Puw6GSUWtqKsM+eiZCQX4 LZFxnxfdE1SOR8kB8pfSd53yiLO3ePyt+O00E7KkFtM9OMV5lTTN0FAB5js02ZCLpTJD a5T1klUjfMLQcS9VNi1BL3zqQnNp7l9ewr4A99Az+Z8EI1GhdMtDpIRJwaFXfqvpu8Wb Fq7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=woJgHZi7N6rYoD2Ae814uyqjx/dO79FR/f7QzPar1zU=; b=JiV5Bv/QJfCIt6q0TTh3r1XhjePWiDTKW+piDzIDBtl38Bq5kjRE98JtK8lVtYhbI2 BwMgM13yD/uifbdUGQ2XEb+Z6mNCqeYQgTpzzzUc60fbN50Xqxld44n3becC464nOlx1 BVPJxVINEWUlDzdEMDqUv2kni7dIqb7bKjj0G44albPo5fjFOfDfMBNE+l63O0hqXgS1 n+/ZeIokwk5V9oSs6zL8oMAiUGeoN3Y3ac5frrD+x9db/SxRhS/jx0YE1d66LSM/JB6O rkEIihGLwr4IwAC2omvrchWuzFt60pJpjEr4c8VfIKtteXVZoj+TFpGI6b4PebQsTxnc 6ruQ== X-Gm-Message-State: AOAM530+fw9ZoNTwO6/rhjUm2xYRvIy8ZWnF6/FQuT4F6XSnndF58iLW 9w5pgyx8zKdJReCcrgVzvJb58wpqJXenyg== X-Google-Smtp-Source: ABdhPJxZeejS/CYWKZToQiltKKPpoOQqBzbWCw/1bdo1c77XAb5mendfkESpxYy9nhSBJDokv39Jgw== X-Received: by 2002:a63:8c50:: with SMTP id q16mr10820334pgn.315.1632158351677; Mon, 20 Sep 2021 10:19:11 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id q12sm368831pgv.26.2021.09.20.10.19.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 10:19:11 -0700 (PDT) Subject: Re: [PATCH 26/30] tcg/loongarch: Implement tcg_target_init To: WANG Xuerui , qemu-devel@nongnu.org References: <20210920080451.408655-1-git@xen0n.name> <20210920080451.408655-27-git@xen0n.name> From: Richard Henderson Message-ID: Date: Mon, 20 Sep 2021 10:19:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920080451.408655-27-git@xen0n.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/20/21 1:04 AM, WANG Xuerui wrote: > +static void tcg_target_init(TCGContext *s) > +{ > + tcg_target_available_regs[TCG_TYPE_I32] = 0xffffffff; > + if (TCG_TARGET_REG_BITS == 64) { > + tcg_target_available_regs[TCG_TYPE_I64] = 0xffffffff; > + } > + > + tcg_target_call_clobber_regs = -1u; In all 3 places, use your ALL_GENERAL_REGS constant. Otherwise, Reviewed-by: Richard Henderson r~