From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D9C2C433E0 for ; Sun, 7 Feb 2021 16:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D42C064E3A for ; Sun, 7 Feb 2021 16:32:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229623AbhBGQcT (ORCPT ); Sun, 7 Feb 2021 11:32:19 -0500 Received: from smtprelay0232.hostedemail.com ([216.40.44.232]:40882 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229506AbhBGQcP (ORCPT ); Sun, 7 Feb 2021 11:32:15 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 1333C18029123; Sun, 7 Feb 2021 16:31:34 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: owl08_28053bd275f7 X-Filterd-Recvd-Size: 4600 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Sun, 7 Feb 2021 16:31:32 +0000 (UTC) Message-ID: Subject: Re: [PATCH] staging: gasket: fix indentation and lines ending with open parenthesis From: Joe Perches To: Mahak Gupta , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, rcy@google.com, benchan@chromium.org, toddpoynor@google.com, rspringer@google.com Date: Sun, 07 Feb 2021 08:31:31 -0800 In-Reply-To: <20210207140928.11029-1-gmahak1@gmail.com> References: <20210207140928.11029-1-gmahak1@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2021-02-07 at 19:39 +0530, Mahak Gupta wrote: > This patch fixes warnings of 'checkpatch.pl'. According to > Linux coding guidelines, code should be aligned properly to > match with open parenthesis and lines should not end with > open parenthesis. > > Signed-off-by: Mahak Gupta > --- >  drivers/staging/gasket/gasket_ioctl.c | 18 ++++++++---------- >  1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c > index e3047d36d8db..a966231bad42 100644 > --- a/drivers/staging/gasket/gasket_ioctl.c > +++ b/drivers/staging/gasket/gasket_ioctl.c > @@ -40,7 +40,7 @@ static int gasket_set_event_fd(struct gasket_dev *gasket_dev, >   > >  /* Read the size of the page table. */ >  static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) >  { >   int ret = 0; >   struct gasket_page_table_ioctl ibuf; > @@ -51,8 +51,7 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, >   if (ibuf.page_table_index >= gasket_dev->num_page_tables) >   return -EFAULT; >   > > - ibuf.size = gasket_page_table_num_entries( > - gasket_dev->page_table[ibuf.page_table_index]); > + ibuf.size = gasket_page_table_num_entries(gasket_dev->page_table[ibuf.page_table_index]); >   > >   trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size, >   ibuf.host_address, > @@ -66,7 +65,7 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, >   > >  /* Read the size of the simple page table. */ >  static int gasket_read_simple_page_table_size(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) >  { >   int ret = 0; >   struct gasket_page_table_ioctl ibuf; > @@ -92,7 +91,7 @@ static int gasket_read_simple_page_table_size(struct gasket_dev *gasket_dev, >   > >  /* Set the boundary between the simple and extended page tables. */ >  static int gasket_partition_page_table(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) >  { >   int ret; >   struct gasket_page_table_ioctl ibuf; > @@ -107,8 +106,8 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev, >   > >   if (ibuf.page_table_index >= gasket_dev->num_page_tables) >   return -EFAULT; > - max_page_table_size = gasket_page_table_max_size( > - gasket_dev->page_table[ibuf.page_table_index]); > + max_page_table_size = gasket_page_table_max_size > + (gasket_dev->page_table[ibuf.page_table_index]); >   > >   if (ibuf.size > max_page_table_size) { >   dev_dbg(gasket_dev->dev, > @@ -119,8 +118,7 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev, >   > >   mutex_lock(&gasket_dev->mutex); >   > > - ret = gasket_page_table_partition( > - gasket_dev->page_table[ibuf.page_table_index], ibuf.size); > + ret = gasket_page_table_partition(gasket_dev->page_table[ibuf.page_table_index], ibuf.size); >   mutex_unlock(&gasket_dev->mutex); >   > >   return ret; > @@ -183,7 +181,7 @@ static int gasket_unmap_buffers(struct gasket_dev *gasket_dev, >   * corresponding memory. >   */ >  static int gasket_config_coherent_allocator(struct gasket_dev *gasket_dev, > - struct gasket_coherent_alloc_config_ioctl __user *argp) > + struct gasket_coherent_alloc_config_ioctl __user *argp) >  { >   int ret; >   struct gasket_coherent_alloc_config_ioctl ibuf; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 832ADC433DB for ; Sun, 7 Feb 2021 16:48:47 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D112664E42 for ; Sun, 7 Feb 2021 16:48:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D112664E42 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6DAF120431; Sun, 7 Feb 2021 16:48:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C6un0v5hGmeS; Sun, 7 Feb 2021 16:48:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id EDBB0203E4; Sun, 7 Feb 2021 16:48:43 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id DE6871BF334 for ; Sun, 7 Feb 2021 16:48:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id DAC2384B91 for ; Sun, 7 Feb 2021 16:48:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1rNomnHS0OOQ for ; Sun, 7 Feb 2021 16:48:42 +0000 (UTC) X-Greylist: delayed 01:23:07 by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by fraxinus.osuosl.org (Postfix) with ESMTPS id E7B8584ABB for ; Sun, 7 Feb 2021 16:48:41 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave05.hostedemail.com (Postfix) with ESMTP id BC11818016C93 for ; Sun, 7 Feb 2021 16:31:36 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 1333C18029123; Sun, 7 Feb 2021 16:31:34 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: owl08_28053bd275f7 X-Filterd-Recvd-Size: 4600 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Sun, 7 Feb 2021 16:31:32 +0000 (UTC) Message-ID: Subject: Re: [PATCH] staging: gasket: fix indentation and lines ending with open parenthesis From: Joe Perches To: Mahak Gupta , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, rcy@google.com, benchan@chromium.org, toddpoynor@google.com, rspringer@google.com Date: Sun, 07 Feb 2021 08:31:31 -0800 In-Reply-To: <20210207140928.11029-1-gmahak1@gmail.com> References: <20210207140928.11029-1-gmahak1@gmail.com> User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, 2021-02-07 at 19:39 +0530, Mahak Gupta wrote: > This patch fixes warnings of 'checkpatch.pl'. According to > Linux coding guidelines, code should be aligned properly to > match with open parenthesis and lines should not end with > open parenthesis. > = > Signed-off-by: Mahak Gupta > --- > =A0drivers/staging/gasket/gasket_ioctl.c | 18 ++++++++---------- > =A01 file changed, 8 insertions(+), 10 deletions(-) > = > diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gask= et/gasket_ioctl.c > index e3047d36d8db..a966231bad42 100644 > --- a/drivers/staging/gasket/gasket_ioctl.c > +++ b/drivers/staging/gasket/gasket_ioctl.c > @@ -40,7 +40,7 @@ static int gasket_set_event_fd(struct gasket_dev *gaske= t_dev, > =A0 > = > =A0/* Read the size of the page table. */ > =A0static int gasket_read_page_table_size(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) > =A0{ > =A0 int ret =3D 0; > =A0 struct gasket_page_table_ioctl ibuf; > @@ -51,8 +51,7 @@ static int gasket_read_page_table_size(struct gasket_de= v *gasket_dev, > =A0 if (ibuf.page_table_index >=3D gasket_dev->num_page_tables) > =A0 return -EFAULT; > =A0 > = > - ibuf.size =3D gasket_page_table_num_entries( > - gasket_dev->page_table[ibuf.page_table_index]); > + ibuf.size =3D gasket_page_table_num_entries(gasket_dev->page_table[ibuf= .page_table_index]); > =A0 > = > =A0 trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size, > =A0 ibuf.host_address, > @@ -66,7 +65,7 @@ static int gasket_read_page_table_size(struct gasket_de= v *gasket_dev, > =A0 > = > =A0/* Read the size of the simple page table. */ > =A0static int gasket_read_simple_page_table_size(struct gasket_dev *gaske= t_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) > =A0{ > =A0 int ret =3D 0; > =A0 struct gasket_page_table_ioctl ibuf; > @@ -92,7 +91,7 @@ static int gasket_read_simple_page_table_size(struct ga= sket_dev *gasket_dev, > =A0 > = > =A0/* Set the boundary between the simple and extended page tables. */ > =A0static int gasket_partition_page_table(struct gasket_dev *gasket_dev, > - struct gasket_page_table_ioctl __user *argp) > + struct gasket_page_table_ioctl __user *argp) > =A0{ > =A0 int ret; > =A0 struct gasket_page_table_ioctl ibuf; > @@ -107,8 +106,8 @@ static int gasket_partition_page_table(struct gasket_= dev *gasket_dev, > =A0 > = > =A0 if (ibuf.page_table_index >=3D gasket_dev->num_page_tables) > =A0 return -EFAULT; > - max_page_table_size =3D gasket_page_table_max_size( > - gasket_dev->page_table[ibuf.page_table_index]); > + max_page_table_size =3D gasket_page_table_max_size > + (gasket_dev->page_table[ibuf.page_table_index]); > =A0 > = > =A0 if (ibuf.size > max_page_table_size) { > =A0 dev_dbg(gasket_dev->dev, > @@ -119,8 +118,7 @@ static int gasket_partition_page_table(struct gasket_= dev *gasket_dev, > =A0 > = > =A0 mutex_lock(&gasket_dev->mutex); > =A0 > = > - ret =3D gasket_page_table_partition( > - gasket_dev->page_table[ibuf.page_table_index], ibuf.size); > + ret =3D gasket_page_table_partition(gasket_dev->page_table[ibuf.page_ta= ble_index], ibuf.size); > =A0 mutex_unlock(&gasket_dev->mutex); > =A0 > = > =A0 return ret; > @@ -183,7 +181,7 @@ static int gasket_unmap_buffers(struct gasket_dev *ga= sket_dev, > =A0=A0* corresponding memory. > =A0=A0*/ > =A0static int gasket_config_coherent_allocator(struct gasket_dev *gasket_= dev, > - struct gasket_coherent_alloc_config_ioctl __user *argp) > + struct gasket_coherent_alloc_config_ioctl __user *argp) > =A0{ > =A0 int ret; > =A0 struct gasket_coherent_alloc_config_ioctl ibuf; _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel