From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F01C433EF for ; Wed, 4 May 2022 10:52:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348400AbiEDKzx (ORCPT ); Wed, 4 May 2022 06:55:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348365AbiEDKzw (ORCPT ); Wed, 4 May 2022 06:55:52 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B76A42655B; Wed, 4 May 2022 03:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651661537; x=1683197537; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yaE0UXo00bqoLBw5jvLJF+P3poG7RKFAaSkpydqWat8=; b=ENL2NA3aEIRwxWpXG0jx2NqAqE18PxYxzgQ6WNX2GfG6pk/8iVosJ73l C0EuTzn9skdErqERjEwi4v5eZ36/Rh8QKZLaEjei32jR61A4bVDhovz23 6vXIICefbcDRMyDivHmLriy3MJS1yb0x7LK5DSx5vkFTIYHe3r8bmMixq Y=; Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 04 May 2022 03:52:16 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2022 03:52:15 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 4 May 2022 03:52:15 -0700 Received: from [10.50.60.188] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 4 May 2022 03:52:12 -0700 Message-ID: Date: Wed, 4 May 2022 16:22:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] soc: qcom: socinfo: Add another ID for sc7180 Content-Language: en-US To: Doug Anderson CC: Bjorn Andersson , , Stephen Boyd , Andy Gross , linux-arm-msm , LKML References: <20220502173338.1.I26eca1856f99e6160d30de6d50ecab60e6226354@changeid> <13819b2d-26f0-14f4-9cb9-affb6b18f13d@quicinc.com> From: Sai Prakash Ranjan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On 5/4/2022 9:00 AM, Doug Anderson wrote: > Hi, > > On Tue, May 3, 2022 at 7:14 PM Sai Prakash Ranjan > wrote: >> Hi, >> >> On 5/3/2022 6:03 AM, Douglas Anderson wrote: >>> It appears the some sc7180 devices, like the one in my >>> sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add >>> another ID into the list. >>> >>> Signed-off-by: Douglas Anderson >>> --- >>> >>> drivers/soc/qcom/socinfo.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c >>> index cee579a267a6..2ef1dc2a1dd3 100644 >>> --- a/drivers/soc/qcom/socinfo.c >>> +++ b/drivers/soc/qcom/socinfo.c >>> @@ -318,6 +318,7 @@ static const struct soc_id soc_id[] = { >>> { 396, "IPQ8071A" }, >>> { 402, "IPQ6018" }, >>> { 403, "IPQ6028" }, >>> + { 407, "SC7180" }, >>> { 421, "IPQ6000" }, >>> { 422, "IPQ6010" }, >>> { 425, "SC7180" }, >> Hmm, this ID maps to SM6250 which is a mobile variant. Not sure we should >> use it for SC7180 which already has 425 ID assigned, perks of marketing :) > That's super weird. Any idea why my strongbad reports 407 then? Is it > a firmware bug, or someone misprogrammed something? What can we do to > make the CPU recognized in strongbad? Let me check with coretech folks as to why the ID is reused. > ...and just for extra info, I believe strongbad actually has the > slightly faster version of sc7180. It has a higher GPU/CPU speed. In > some places I've heard it called sc7185, but in other places I've > heard it called just sc7180 with a faster clock speed... The only other variant of SC7180 I see in the document is SC7180P which has 495 soc_id and is an APQ variant. Thanks, Sai