From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2C1C64ED8 for ; Thu, 23 Feb 2023 09:21:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233157AbjBWJVh (ORCPT ); Thu, 23 Feb 2023 04:21:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbjBWJVh (ORCPT ); Thu, 23 Feb 2023 04:21:37 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F74E521C6 for ; Thu, 23 Feb 2023 01:21:35 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id l25so9689547wrb.3 for ; Thu, 23 Feb 2023 01:21:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eJSCygSyqymwVM3qv58bXIOQ/QMwS9A0T2gOwos2ANI=; b=fegQtyEWhTqmEAd0iw7X7HKpXLywzYFPBBzCm5qOIC8lDXtvSvWPLxRK1SHoHx4D8F cX9nYfRK96054nl3FKHZATG+FapB5e23HntdNfvK5fJTrpOIQaNkPh/xOf2q2H/h43Se U8P0v8yKtozY/YP3KYye8WS9wsVTR5g4NxnbpZFKLDDujNez4IvzyNE8MDGdtipvuMQS QGoU+osQ2ysbPKou87uCJADJSCZH3B8NHlV4LoKYB+YXGLZL07eCv71HXiKC1ZUz4wsZ G9TUCri7cQOq+twOG6pqmE/sgiTL2VcQhWorwnarYl22GecZP4GL0w3WTLmc7eegOgEH Aq2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eJSCygSyqymwVM3qv58bXIOQ/QMwS9A0T2gOwos2ANI=; b=Ue0NPhcTRnrJlF0i4rpBfY4f3S+oF2IC3szT1DfIToShdR++eQZVYPnaVmIabhPzKt a8ROYzJ9hDuXzV3nlTnvift3vfgXRtqfdKeWVMkGa6lJ5aV3NVFWDS6GP4jXrZ/9uvH8 saKJkTqoge08HU47Y0f2OSGMFsF+BDx+PS1r7Uz5AZaqKV6gam0N8OScdXFKvQXCtRIZ x/JwI9RfDTTRuxRXBKBb0hQdVsV3LZdgRWTRTGqHjgj26DoC2EQqplk5mftoB0XoODhY JAbxZtcGm+1kuGlhnISo7JxGgXmL6YylmCd3GBJPFOwF4FIHCwgTWZhNPAn8ektBGb90 5VCw== X-Gm-Message-State: AO0yUKVEqx2JjMJKwrEnzhtRHi9c/Xg3ITjhPLQoCobps0sbZvDWPV3Q 3cUt1xB/zuhSzchyElODZw8Ukw== X-Google-Smtp-Source: AK7set+KT38k5JXdqB9gWpe020J1FzMkLGn2pF7mw7ss+GUQRXzcwUsyPn/SBCWmwFh5a4SSTvcWZA== X-Received: by 2002:a5d:6a03:0:b0:2c7:84e:1cfa with SMTP id m3-20020a5d6a03000000b002c7084e1cfamr5709487wru.40.1677144093790; Thu, 23 Feb 2023 01:21:33 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id v17-20020adff691000000b002c70e60eb40sm2038217wrp.11.2023.02.23.01.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 01:21:32 -0800 (PST) Message-ID: Date: Thu, 23 Feb 2023 09:21:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 13/26] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Content-Language: en-US To: Elliot Berman , Alex Elder , Prakruthi Deepak Heragu Cc: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Bagas Sanjaya , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230214211229.3239350-1-quic_eberman@quicinc.com> <20230214212427.3316544-1-quic_eberman@quicinc.com> <1080339c-608e-6df8-8eee-b8f3bb7f396d@linaro.org> <320d42a0-9889-43ae-5d62-0c4cab3434c5@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <320d42a0-9889-43ae-5d62-0c4cab3434c5@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/02/2023 00:50, Elliot Berman wrote: >>> >>> + >>> +    mem_handle = mapping->parcel.mem_handle; >>> +    dtb_offset = ghvm->dtb_config.gpa - mapping->guest_phys_addr; >>> + >>> +    ret = gh_rm_vm_configure(ghvm->rm, ghvm->vmid, ghvm->auth, >>> mem_handle, >> >> where is authentication mechanism (auth) comming from? Who is supposed >> to set this value? >> >> Should it come from userspace? if so I do not see any UAPI facility to >> do that via VM_START ioctl. >> > > Right, we are only adding the support for unauthenticated VMs for now. > There would be further UAPI facilities to set the authentication type. We have to be careful, please note that you can not change an existing UAPI to accommodate new features. There are two ways to do this properly: 1. Design UAPI to accommodate features that will be part of this in very soon or in future. This way the UAPI is stable and does not change over time when we add support this feature in driver. In this particular case, vm authentication type is one that needs to come from user, rather than kernel assuming it, so definitely this need to be properly addressed by passing this info from userspace. Or rename this IOCTl to something like VM_START_UNAUTH_VM to make this more explicit. 2. For each feature add new UAPI as and when its required, which is really the only option when we failed to design UAPIs correctly in the first place. --srini > >> >>> +                0, 0, dtb_offset, ghvm->dtb_config.size); >>> +    if (ret) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D0F8C61DA4 for ; Thu, 23 Feb 2023 09:22:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aK3YTRrh7yZjS/RzJQE033ciSmnNwwW473F3kW9wqpw=; b=aQP852BrKQ/9br tHYs0kQCQHNC7dm8dAT4tqBsiPhUIxbnWgF3pDkosJaiXz8HZbpWjAqEYjMcwxX3HBdPmsAJRKXCB Au/Ms17ivHaW1tfvX+86N1mGfIIiPiFJZCD2PH9X7C4W8xAu2PLbBQTCU2a4Nyk95rHtOhSDdfiGs fbRhoJ2MTn7josmyoNOLykxGg5ikDwe2huKkftJk2CDs3ssF1QAQqZxlwa8+IC9sLSp8DFvN39C0C +uLeeYR+Lt5pF3Ea0R/tljylDtJLN7gkoD3SyLn7HzkSjsEsIEf4xPmjO5HJChu33fISH8qsNneUb wMvMHT1YmzPFeb16950g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pV7nH-00Fg7N-Tj; Thu, 23 Feb 2023 09:21:40 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pV7nE-00Fg5v-OZ for linux-arm-kernel@lists.infradead.org; Thu, 23 Feb 2023 09:21:38 +0000 Received: by mail-wr1-x432.google.com with SMTP id bo30so9527721wrb.0 for ; Thu, 23 Feb 2023 01:21:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eJSCygSyqymwVM3qv58bXIOQ/QMwS9A0T2gOwos2ANI=; b=fegQtyEWhTqmEAd0iw7X7HKpXLywzYFPBBzCm5qOIC8lDXtvSvWPLxRK1SHoHx4D8F cX9nYfRK96054nl3FKHZATG+FapB5e23HntdNfvK5fJTrpOIQaNkPh/xOf2q2H/h43Se U8P0v8yKtozY/YP3KYye8WS9wsVTR5g4NxnbpZFKLDDujNez4IvzyNE8MDGdtipvuMQS QGoU+osQ2ysbPKou87uCJADJSCZH3B8NHlV4LoKYB+YXGLZL07eCv71HXiKC1ZUz4wsZ G9TUCri7cQOq+twOG6pqmE/sgiTL2VcQhWorwnarYl22GecZP4GL0w3WTLmc7eegOgEH Aq2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eJSCygSyqymwVM3qv58bXIOQ/QMwS9A0T2gOwos2ANI=; b=nIJ9sF4iVpKqyXyB3PakYL51eAUucEkZf7fNhg1jyshnX0MxG8kFy6rlV9Qcd6UNap rkj0dfYO1UmP+W1NGP2w1RhAdFaoPpfmWSaA0Y2FvQqXpKAkCWq335Mf4KaIq8kn4WGf dKAPjqkX/gL29hI3y5wztth21zfV0TbAgXTlJbUj6wGZU8dEcWG/HyJAxWUdm7c8fG8L B8b5EUFDX2iDmZri2/V0kHxFMeA4wwliv53KA1wblOk7/uVwlI/tna85oXoyupl/inrI gEmHYNrDsoLRJiRQsNgWsgxBqSb345nsxodW6thv68WAPiu3TRzp8Hwvu68YpKlWWZj0 nBTg== X-Gm-Message-State: AO0yUKUV/uFAMvp94hSwB080f2XdwIX18A0+9P56I/wk5xhR/WLYvbH1 bHaxzrDTTyTlAn1RerrLk5sdGQ== X-Google-Smtp-Source: AK7set+KT38k5JXdqB9gWpe020J1FzMkLGn2pF7mw7ss+GUQRXzcwUsyPn/SBCWmwFh5a4SSTvcWZA== X-Received: by 2002:a5d:6a03:0:b0:2c7:84e:1cfa with SMTP id m3-20020a5d6a03000000b002c7084e1cfamr5709487wru.40.1677144093790; Thu, 23 Feb 2023 01:21:33 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id v17-20020adff691000000b002c70e60eb40sm2038217wrp.11.2023.02.23.01.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 01:21:32 -0800 (PST) Message-ID: Date: Thu, 23 Feb 2023 09:21:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 13/26] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Content-Language: en-US To: Elliot Berman , Alex Elder , Prakruthi Deepak Heragu Cc: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Bagas Sanjaya , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230214211229.3239350-1-quic_eberman@quicinc.com> <20230214212427.3316544-1-quic_eberman@quicinc.com> <1080339c-608e-6df8-8eee-b8f3bb7f396d@linaro.org> <320d42a0-9889-43ae-5d62-0c4cab3434c5@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <320d42a0-9889-43ae-5d62-0c4cab3434c5@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230223_012136_823111_D4B098F6 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMy8wMi8yMDIzIDAwOjUwLCBFbGxpb3QgQmVybWFuIHdyb3RlOgo+Pj4KPj4+ICsKPj4+ ICvCoMKgwqAgbWVtX2hhbmRsZSA9IG1hcHBpbmctPnBhcmNlbC5tZW1faGFuZGxlOwo+Pj4gK8Kg wqDCoCBkdGJfb2Zmc2V0ID0gZ2h2bS0+ZHRiX2NvbmZpZy5ncGEgLSBtYXBwaW5nLT5ndWVzdF9w aHlzX2FkZHI7Cj4+PiArCj4+PiArwqDCoMKgIHJldCA9IGdoX3JtX3ZtX2NvbmZpZ3VyZShnaHZt LT5ybSwgZ2h2bS0+dm1pZCwgZ2h2bS0+YXV0aCwgCj4+PiBtZW1faGFuZGxlLAo+Pgo+PiB3aGVy ZSBpcyBhdXRoZW50aWNhdGlvbiBtZWNoYW5pc20gKGF1dGgpIGNvbW1pbmcgZnJvbT8gV2hvIGlz IHN1cHBvc2VkIAo+PiB0byBzZXQgdGhpcyB2YWx1ZT8KPj4KPj4gU2hvdWxkIGl0IGNvbWUgZnJv bSB1c2Vyc3BhY2U/IGlmIHNvIEkgZG8gbm90IHNlZSBhbnkgVUFQSSBmYWNpbGl0eSB0byAKPj4g ZG8gdGhhdCB2aWEgVk1fU1RBUlQgaW9jdGwuCj4+Cj4gCj4gUmlnaHQsIHdlIGFyZSBvbmx5IGFk ZGluZyB0aGUgc3VwcG9ydCBmb3IgdW5hdXRoZW50aWNhdGVkIFZNcyBmb3Igbm93LiAKPiBUaGVy ZSB3b3VsZCBiZSBmdXJ0aGVyIFVBUEkgZmFjaWxpdGllcyB0byBzZXQgdGhlIGF1dGhlbnRpY2F0 aW9uIHR5cGUuCldlIGhhdmUgdG8gYmUgY2FyZWZ1bCwgcGxlYXNlIG5vdGUgdGhhdCB5b3UgY2Fu IG5vdCBjaGFuZ2UgYW4gZXhpc3RpbmcgClVBUEkgdG8gYWNjb21tb2RhdGUgbmV3IGZlYXR1cmVz LgoKVGhlcmUgYXJlIHR3byB3YXlzIHRvIGRvIHRoaXMgcHJvcGVybHk6CgoxLiBEZXNpZ24gVUFQ SSB0byBhY2NvbW1vZGF0ZSBmZWF0dXJlcyB0aGF0IHdpbGwgYmUgcGFydCBvZiB0aGlzIGluIHZl cnkgCiAgc29vbiBvciBpbiBmdXR1cmUuIFRoaXMgd2F5IHRoZSBVQVBJIGlzIHN0YWJsZSBhbmQg ZG9lcyBub3QgY2hhbmdlIApvdmVyIHRpbWUgd2hlbiB3ZSBhZGQgc3VwcG9ydCB0aGlzIGZlYXR1 cmUgaW4gZHJpdmVyLgoKSW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UsIHZtIGF1dGhlbnRpY2F0aW9u IHR5cGUgaXMgb25lIHRoYXQgbmVlZHMgdG8gCmNvbWUgZnJvbSB1c2VyLCByYXRoZXIgdGhhbiBr ZXJuZWwgYXNzdW1pbmcgaXQsIHNvIGRlZmluaXRlbHkgdGhpcyBuZWVkIAp0byBiZSBwcm9wZXJs eSBhZGRyZXNzZWQgYnkgcGFzc2luZyB0aGlzIGluZm8gZnJvbSB1c2Vyc3BhY2UuCk9yIHJlbmFt ZSB0aGlzIElPQ1RsIHRvIHNvbWV0aGluZyBsaWtlIFZNX1NUQVJUX1VOQVVUSF9WTSB0byBtYWtl IHRoaXMgCm1vcmUgZXhwbGljaXQuCgoKMi4gRm9yIGVhY2ggZmVhdHVyZSBhZGQgbmV3IFVBUEkg YXMgYW5kIHdoZW4gaXRzIHJlcXVpcmVkLCB3aGljaCBpcyAKcmVhbGx5IHRoZSBvbmx5IG9wdGlv biB3aGVuIHdlIGZhaWxlZCB0byBkZXNpZ24gVUFQSXMgY29ycmVjdGx5IGluIHRoZSAKZmlyc3Qg cGxhY2UuCgotLXNyaW5pCgoKPiAKPj4KPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgMCwgMCwgZHRiX29mZnNldCwgZ2h2bS0+ZHRiX2NvbmZpZy5zaXplKTsKPj4+ICvCoMKgwqAg aWYgKHJldCkgeyAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK