Re: [Buildroot] package/aravis: new package

[marc.chalain@mailoo.org]

[-- Attachment #1.1: Type: text/plain, Size: 2903 bytes --]

Thank for all,

I will send a new version quickly, but some questions first:



> +ARAVIS_VERSION = 0.8.16

Aravis project is moving fast, there is a new version 0.8.20 already.
I'm fine with this version since it was released recently:
https://github.com/AravisProject/aravis/releases/tag/0.8.16


The 0.8.16 is available from June 2021. I had clearly well tested this version with several kernel configuration. What is it better ? the last version or the most tested version ?

To send 0.8.20 I will need few weeks, to test.



> +ARAVIS_SITE = $(call github,AravisProject,aravis,$(ARAVIS_VERSION))
> +ARAVIS_DEPENDENCIES = \
> +    host-pkgconf \
> +    libglib2 \
> +    libxml2

There is a list of dependencies in the Readme:

https://github.com/AravisProject/aravis/blob/main/README.md#install-dependencies-on-ubuntu-2004

especially gstreamer and plugins etc..


This rules is just for GigE Camera and not USB3Vision. I haven't tested this feature. The gstreamer is not mandator, it is only for the viewer. I am focused on Embeded system without any kind of display.

If the gstreamer or libusb3 are availables, meson is able to detect and add them during the configuration process.

To add as dependencies, forces to build the optionals features.

What's the best ?



Thank you., best regards,

Marc.







De : Thomas Petazzoni <thomas.petazzoni@bootlin.com>
À : Romain Naour <romain.naour@smile.fr>
Sujet : Re: [Buildroot] package/aravis: new package
Date : 06/01/2022 10:37:59 Europe/Paris
Copie à : marc.chalain@mailoo.org;
   buildroot@buildroot.org;
   Eric Le Bihan <eric.le.bihan.dev@free.fr>;
   Marc Chalain <marc.chalain@gmail.com>

Hello,

On Thu, 6 Jan 2022 10:24:53 +0100
Romain Naour <romain.naour@smile.fr> wrote:

> > diff --git a/package/aravis/Config.in b/package/aravis/Config.in
> > new file mode 100644
> > index 0000000000..02c71c44da
> > --- /dev/null
> > +++ b/package/aravis/Config.in
> > @@ -0,0 +1,16 @@
> > +config BR2_PACKAGE_ARAVIS
> > +    bool "aravis - GigE Camera"

Just:

bool "aravis"

> > +    depends on BR2_USE_WCHAR
> > +    depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> > +    depends on BR2_PACKAGE_PCRE_16
> > +    depends on BR2_PACKAGE_PCRE_32

Please use "select" for pcre.

> > +ARAVIS_LICENSE_FILES = COPYING
> > +ARAVIS_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS) 
> 
> Is gettext a mandatory dependency ?
> At least gettext should be in ARAVIS_DEPENDENCIES when NLS support is enabled.

No, don't add gettext directly, use $(TARGET_NLS_DEPENDENCIES), which
will automatically add (or not) host-gettext and/or gettext to the
dependencies, depending on when it's needed or not.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com


[-- Attachment #1.2: Type: text/html, Size: 4353 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot