* [PATCH] pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang
@ 2021-04-21 16:33 Thomas Huth
2021-04-21 16:37 ` Philippe Mathieu-Daudé
2021-04-21 16:37 ` Christian Borntraeger
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2021-04-21 16:33 UTC (permalink / raw)
To: qemu-s390x, Cornelia Huck, Christian Borntraeger; +Cc: qemu-devel
When compiling the s390-ccw bios with Clang, the compiler complains:
pc-bios/s390-ccw/bootmap.c:302:9: warning: logical not is only applied
to the left hand side of this comparison [-Wlogical-not-parentheses]
if (!mbr->dev_type == DEV_TYPE_ECKD) {
^ ~~
The code works (more or less by accident), since dev_type can only be
0 or 1, but it's better of course to use the intended != operator here
instead.
Fixes: 5dc739f343 ("Allow booting in case the first virtio-blk disk is bad")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/bootmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
index 44df7d16af..e4b2e5a1b0 100644
--- a/pc-bios/s390-ccw/bootmap.c
+++ b/pc-bios/s390-ccw/bootmap.c
@@ -299,7 +299,7 @@ static void ipl_eckd_cdl(void)
sclp_print("Bad block size in zIPL section of IPL2 record.\n");
return;
}
- if (!mbr->dev_type == DEV_TYPE_ECKD) {
+ if (mbr->dev_type != DEV_TYPE_ECKD) {
sclp_print("Non-ECKD device type in zIPL section of IPL2 record.\n");
return;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang
2021-04-21 16:33 [PATCH] pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang Thomas Huth
@ 2021-04-21 16:37 ` Philippe Mathieu-Daudé
2021-04-21 16:37 ` Christian Borntraeger
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-21 16:37 UTC (permalink / raw)
To: Thomas Huth, qemu-s390x, Cornelia Huck, Christian Borntraeger; +Cc: qemu-devel
On 4/21/21 6:33 PM, Thomas Huth wrote:
> When compiling the s390-ccw bios with Clang, the compiler complains:
>
> pc-bios/s390-ccw/bootmap.c:302:9: warning: logical not is only applied
> to the left hand side of this comparison [-Wlogical-not-parentheses]
> if (!mbr->dev_type == DEV_TYPE_ECKD) {
> ^ ~~
>
> The code works (more or less by accident), since dev_type can only be
> 0 or 1, but it's better of course to use the intended != operator here
> instead.
>
> Fixes: 5dc739f343 ("Allow booting in case the first virtio-blk disk is bad")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/bootmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang
2021-04-21 16:33 [PATCH] pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang Thomas Huth
2021-04-21 16:37 ` Philippe Mathieu-Daudé
@ 2021-04-21 16:37 ` Christian Borntraeger
1 sibling, 0 replies; 3+ messages in thread
From: Christian Borntraeger @ 2021-04-21 16:37 UTC (permalink / raw)
To: Thomas Huth, qemu-s390x, Cornelia Huck; +Cc: qemu-devel
On 21.04.21 18:33, Thomas Huth wrote:
> When compiling the s390-ccw bios with Clang, the compiler complains:
>
> pc-bios/s390-ccw/bootmap.c:302:9: warning: logical not is only applied
> to the left hand side of this comparison [-Wlogical-not-parentheses]
> if (!mbr->dev_type == DEV_TYPE_ECKD) {
> ^ ~~
>
> The code works (more or less by accident), since dev_type can only be
> 0 or 1, but it's better of course to use the intended != operator here
> instead.
>
> Fixes: 5dc739f343 ("Allow booting in case the first virtio-blk disk is bad")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> pc-bios/s390-ccw/bootmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
> index 44df7d16af..e4b2e5a1b0 100644
> --- a/pc-bios/s390-ccw/bootmap.c
> +++ b/pc-bios/s390-ccw/bootmap.c
> @@ -299,7 +299,7 @@ static void ipl_eckd_cdl(void)
> sclp_print("Bad block size in zIPL section of IPL2 record.\n");
> return;
> }
> - if (!mbr->dev_type == DEV_TYPE_ECKD) {
> + if (mbr->dev_type != DEV_TYPE_ECKD) {
> sclp_print("Non-ECKD device type in zIPL section of IPL2 record.\n");
> return;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-21 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 16:33 [PATCH] pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang Thomas Huth
2021-04-21 16:37 ` Philippe Mathieu-Daudé
2021-04-21 16:37 ` Christian Borntraeger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.