All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations
@ 2009-01-28  5:17 Manish Katiyar
  2009-01-28  5:21 ` Manish Katiyar
  0 siblings, 1 reply; 7+ messages in thread
From: Manish Katiyar @ 2009-01-28  5:17 UTC (permalink / raw)
  To: Theodore Ts'o, ext4; +Cc: mkatiyar

Below patch removes the following warning during compilation :

  CC [M]  fs/ext4/super.o
fs/ext4/super.c:949: warning: initialization from incompatible pointer type
  LD [M]  fs/ext4/ext4.o


Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
---
 fs/ext4/ext4.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 3ab1a41..0164866 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1088,7 +1088,7 @@ extern int ext4_chunk_trans_blocks(struct inode
*, int nrblocks);
 extern int ext4_block_truncate_page(handle_t *handle,
 		struct address_space *mapping, loff_t from);
 extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page);
-extern unsigned long long ext4_get_reserved_space(struct inode *inode);
+extern qsize_t ext4_get_reserved_space(struct inode *inode);

 /* ioctl.c */
 extern long ext4_ioctl(struct file *, unsigned int, unsigned long);
-- 
1.5.4.3


Thanks -
Manish

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations
  2009-01-28  5:17 [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations Manish Katiyar
@ 2009-01-28  5:21 ` Manish Katiyar
  2009-01-30 15:00   ` Manish Katiyar
  2009-02-02 16:10   ` Jan Kara
  0 siblings, 2 replies; 7+ messages in thread
From: Manish Katiyar @ 2009-01-28  5:21 UTC (permalink / raw)
  To: Theodore Ts'o, ext4; +Cc: mkatiyar

On Wed, Jan 28, 2009 at 10:47 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> Below patch removes the following warning during compilation :
>
>  CC [M]  fs/ext4/super.o
> fs/ext4/super.c:949: warning: initialization from incompatible pointer type
>  LD [M]  fs/ext4/ext4.o

Sorry,

Tha correct patch is here.

Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
---
 fs/ext4/ext4.h  |    2 +-
 fs/ext4/inode.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 3ab1a41..0164866 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1088,7 +1088,7 @@ extern int ext4_chunk_trans_blocks(struct inode
*, int nrblocks);
 extern int ext4_block_truncate_page(handle_t *handle,
 		struct address_space *mapping, loff_t from);
 extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page);
-extern unsigned long long ext4_get_reserved_space(struct inode *inode);
+extern qsize_t ext4_get_reserved_space(struct inode *inode);

 /* ioctl.c */
 extern long ext4_ioctl(struct file *, unsigned int, unsigned long);
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 6a316ec..6be09be 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -973,9 +973,9 @@ out:
 	return err;
 }

-unsigned long long ext4_get_reserved_space(struct inode *inode)
+qsize_t ext4_get_reserved_space(struct inode *inode)
 {
-	unsigned long long total;
+	qsize_t total;

 	spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
 	total = EXT4_I(inode)->i_reserved_data_blocks +
-- 
1.5.4.3

Thanks -
Manish

>
>
> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
> ---
>  fs/ext4/ext4.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 3ab1a41..0164866 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1088,7 +1088,7 @@ extern int ext4_chunk_trans_blocks(struct inode
> *, int nrblocks);
>  extern int ext4_block_truncate_page(handle_t *handle,
>                struct address_space *mapping, loff_t from);
>  extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page);
> -extern unsigned long long ext4_get_reserved_space(struct inode *inode);
> +extern qsize_t ext4_get_reserved_space(struct inode *inode);
>
>  /* ioctl.c */
>  extern long ext4_ioctl(struct file *, unsigned int, unsigned long);
> --
> 1.5.4.3
>
>
> Thanks -
> Manish
>

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations
  2009-01-28  5:21 ` Manish Katiyar
@ 2009-01-30 15:00   ` Manish Katiyar
  2009-02-02 16:10   ` Jan Kara
  1 sibling, 0 replies; 7+ messages in thread
From: Manish Katiyar @ 2009-01-30 15:00 UTC (permalink / raw)
  To: Theodore Ts'o, ext4; +Cc: mkatiyar

On Wed, Jan 28, 2009 at 10:51 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> On Wed, Jan 28, 2009 at 10:47 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
>> Below patch removes the following warning during compilation :
>>
>>  CC [M]  fs/ext4/super.o
>> fs/ext4/super.c:949: warning: initialization from incompatible pointer type
>>  LD [M]  fs/ext4/ext4.o

Hi Ted,

Any feedback on this ?

Thanks -
Manish

>
> Sorry,
>
> Tha correct patch is here.
>
> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
> ---
>  fs/ext4/ext4.h  |    2 +-
>  fs/ext4/inode.c |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 3ab1a41..0164866 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1088,7 +1088,7 @@ extern int ext4_chunk_trans_blocks(struct inode
> *, int nrblocks);
>  extern int ext4_block_truncate_page(handle_t *handle,
>                struct address_space *mapping, loff_t from);
>  extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page);
> -extern unsigned long long ext4_get_reserved_space(struct inode *inode);
> +extern qsize_t ext4_get_reserved_space(struct inode *inode);
>
>  /* ioctl.c */
>  extern long ext4_ioctl(struct file *, unsigned int, unsigned long);
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 6a316ec..6be09be 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -973,9 +973,9 @@ out:
>        return err;
>  }
>
> -unsigned long long ext4_get_reserved_space(struct inode *inode)
> +qsize_t ext4_get_reserved_space(struct inode *inode)
>  {
> -       unsigned long long total;
> +       qsize_t total;
>
>        spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
>        total = EXT4_I(inode)->i_reserved_data_blocks +
> --
> 1.5.4.3
>
> Thanks -
> Manish
>
>>
>>
>> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
>> ---
>>  fs/ext4/ext4.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
>> index 3ab1a41..0164866 100644
>> --- a/fs/ext4/ext4.h
>> +++ b/fs/ext4/ext4.h
>> @@ -1088,7 +1088,7 @@ extern int ext4_chunk_trans_blocks(struct inode
>> *, int nrblocks);
>>  extern int ext4_block_truncate_page(handle_t *handle,
>>                struct address_space *mapping, loff_t from);
>>  extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page);
>> -extern unsigned long long ext4_get_reserved_space(struct inode *inode);
>> +extern qsize_t ext4_get_reserved_space(struct inode *inode);
>>
>>  /* ioctl.c */
>>  extern long ext4_ioctl(struct file *, unsigned int, unsigned long);
>> --
>> 1.5.4.3
>>
>>
>> Thanks -
>> Manish
>>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations
  2009-01-28  5:21 ` Manish Katiyar
  2009-01-30 15:00   ` Manish Katiyar
@ 2009-02-02 16:10   ` Jan Kara
  2009-02-12  8:54     ` Manish Katiyar
  1 sibling, 1 reply; 7+ messages in thread
From: Jan Kara @ 2009-02-02 16:10 UTC (permalink / raw)
  To: Manish Katiyar; +Cc: Theodore Ts'o, ext4

> On Wed, Jan 28, 2009 at 10:47 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> > Below patch removes the following warning during compilation :
> >
> >  CC [M]  fs/ext4/super.o
> > fs/ext4/super.c:949: warning: initialization from incompatible pointer type
> >  LD [M]  fs/ext4/ext4.o
> 
> Sorry,
> 
> Tha correct patch is here.
> 
> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
  Looks fine to me.
Acked-by: Jan Kara <jack@suse.cz>

										Honza

> ---
>  fs/ext4/ext4.h  |    2 +-
>  fs/ext4/inode.c |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 3ab1a41..0164866 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1088,7 +1088,7 @@ extern int ext4_chunk_trans_blocks(struct inode
> *, int nrblocks);
>  extern int ext4_block_truncate_page(handle_t *handle,
>  		struct address_space *mapping, loff_t from);
>  extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page);
> -extern unsigned long long ext4_get_reserved_space(struct inode *inode);
> +extern qsize_t ext4_get_reserved_space(struct inode *inode);
> 
>  /* ioctl.c */
>  extern long ext4_ioctl(struct file *, unsigned int, unsigned long);
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 6a316ec..6be09be 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -973,9 +973,9 @@ out:
>  	return err;
>  }
> 
> -unsigned long long ext4_get_reserved_space(struct inode *inode)
> +qsize_t ext4_get_reserved_space(struct inode *inode)
>  {
> -	unsigned long long total;
> +	qsize_t total;
> 
>  	spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
>  	total = EXT4_I(inode)->i_reserved_data_blocks +
> -- 
> 1.5.4.3
> 
> Thanks -
> Manish
> 
> >
> >
> > Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
> > ---
> >  fs/ext4/ext4.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > index 3ab1a41..0164866 100644
> > --- a/fs/ext4/ext4.h
> > +++ b/fs/ext4/ext4.h
> > @@ -1088,7 +1088,7 @@ extern int ext4_chunk_trans_blocks(struct inode
> > *, int nrblocks);
> >  extern int ext4_block_truncate_page(handle_t *handle,
> >                struct address_space *mapping, loff_t from);
> >  extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page);
> > -extern unsigned long long ext4_get_reserved_space(struct inode *inode);
> > +extern qsize_t ext4_get_reserved_space(struct inode *inode);
> >
> >  /* ioctl.c */
> >  extern long ext4_ioctl(struct file *, unsigned int, unsigned long);
> > --
> > 1.5.4.3
> >
> >
> > Thanks -
> > Manish
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations
  2009-02-02 16:10   ` Jan Kara
@ 2009-02-12  8:54     ` Manish Katiyar
  2009-02-12 11:47       ` Theodore Tso
  2009-02-12 14:22       ` Jan Kara
  0 siblings, 2 replies; 7+ messages in thread
From: Manish Katiyar @ 2009-02-12  8:54 UTC (permalink / raw)
  To: Jan Kara; +Cc: Theodore Ts'o, ext4

On Mon, Feb 2, 2009 at 9:40 PM, Jan Kara <jack@suse.cz> wrote:
>> On Wed, Jan 28, 2009 at 10:47 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
>> > Below patch removes the following warning during compilation :
>> >
>> >  CC [M]  fs/ext4/super.o
>> > fs/ext4/super.c:949: warning: initialization from incompatible pointer type
>> >  LD [M]  fs/ext4/ext4.o
>>
>> Sorry,
>>
>> Tha correct patch is here.
>>
>> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
>  Looks fine to me.
> Acked-by: Jan Kara <jack@suse.cz>

Hi Jan,

A simple doubt. Patches acked by you will be automatically picked up
or will I have to resend it with your ack added ??

Thanks -
Manish

>
>                                                                                Honza
>
>> ---
>>  fs/ext4/ext4.h  |    2 +-
>>  fs/ext4/inode.c |    4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
>> index 3ab1a41..0164866 100644
>> --- a/fs/ext4/ext4.h
>> +++ b/fs/ext4/ext4.h
>> @@ -1088,7 +1088,7 @@ extern int ext4_chunk_trans_blocks(struct inode
>> *, int nrblocks);
>>  extern int ext4_block_truncate_page(handle_t *handle,
>>               struct address_space *mapping, loff_t from);
>>  extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page);
>> -extern unsigned long long ext4_get_reserved_space(struct inode *inode);
>> +extern qsize_t ext4_get_reserved_space(struct inode *inode);
>>
>>  /* ioctl.c */
>>  extern long ext4_ioctl(struct file *, unsigned int, unsigned long);
>> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
>> index 6a316ec..6be09be 100644
>> --- a/fs/ext4/inode.c
>> +++ b/fs/ext4/inode.c
>> @@ -973,9 +973,9 @@ out:
>>       return err;
>>  }
>>
>> -unsigned long long ext4_get_reserved_space(struct inode *inode)
>> +qsize_t ext4_get_reserved_space(struct inode *inode)
>>  {
>> -     unsigned long long total;
>> +     qsize_t total;
>>
>>       spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
>>       total = EXT4_I(inode)->i_reserved_data_blocks +
>> --
>> 1.5.4.3
>>
>> Thanks -
>> Manish
>>
>> >
>> >
>> > Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
>> > ---
>> >  fs/ext4/ext4.h |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
>> > index 3ab1a41..0164866 100644
>> > --- a/fs/ext4/ext4.h
>> > +++ b/fs/ext4/ext4.h
>> > @@ -1088,7 +1088,7 @@ extern int ext4_chunk_trans_blocks(struct inode
>> > *, int nrblocks);
>> >  extern int ext4_block_truncate_page(handle_t *handle,
>> >                struct address_space *mapping, loff_t from);
>> >  extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct page *page);
>> > -extern unsigned long long ext4_get_reserved_space(struct inode *inode);
>> > +extern qsize_t ext4_get_reserved_space(struct inode *inode);
>> >
>> >  /* ioctl.c */
>> >  extern long ext4_ioctl(struct file *, unsigned int, unsigned long);
>> > --
>> > 1.5.4.3
>> >
>> >
>> > Thanks -
>> > Manish
>> >
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> Jan Kara <jack@suse.cz>
> SuSE CR Labs
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations
  2009-02-12  8:54     ` Manish Katiyar
@ 2009-02-12 11:47       ` Theodore Tso
  2009-02-12 14:22       ` Jan Kara
  1 sibling, 0 replies; 7+ messages in thread
From: Theodore Tso @ 2009-02-12 11:47 UTC (permalink / raw)
  To: Manish Katiyar; +Cc: Jan Kara, ext4

On Thu, Feb 12, 2009 at 02:24:17PM +0530, Manish Katiyar wrote:
> On Mon, Feb 2, 2009 at 9:40 PM, Jan Kara <jack@suse.cz> wrote:
> >> On Wed, Jan 28, 2009 at 10:47 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> >> > Below patch removes the following warning during compilation :
> >> >
> >> >  CC [M]  fs/ext4/super.o
> >> > fs/ext4/super.c:949: warning: initialization from incompatible pointer type
> >> >  LD [M]  fs/ext4/ext4.o
> >>
> >> Sorry,
> >>
> >> Tha correct patch is here.
> >>
> >> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
> >  Looks fine to me.
> > Acked-by: Jan Kara <jack@suse.cz>
> 
> Hi Jan,
> 
> A simple doubt. Patches acked by you will be automatically picked up
> or will I have to resend it with your ack added ??

Actually, in this case Jan should pick up the patch and merge it with
Mingming's ext4 quota patch which is being carried in his tree.  The
current ext4 code doesn't have ext4_get_reserved_space() at all.

							- Ted

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations
  2009-02-12  8:54     ` Manish Katiyar
  2009-02-12 11:47       ` Theodore Tso
@ 2009-02-12 14:22       ` Jan Kara
  1 sibling, 0 replies; 7+ messages in thread
From: Jan Kara @ 2009-02-12 14:22 UTC (permalink / raw)
  To: Manish Katiyar; +Cc: Theodore Ts'o, ext4

On Thu 12-02-09 14:24:17, Manish Katiyar wrote:
> On Mon, Feb 2, 2009 at 9:40 PM, Jan Kara <jack@suse.cz> wrote:
> >> On Wed, Jan 28, 2009 at 10:47 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> >> > Below patch removes the following warning during compilation :
> >> >
> >> >  CC [M]  fs/ext4/super.o
> >> > fs/ext4/super.c:949: warning: initialization from incompatible pointer type
> >> >  LD [M]  fs/ext4/ext4.o
> >>
> >> Sorry,
> >>
> >> Tha correct patch is here.
> >>
> >> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
> >  Looks fine to me.
> > Acked-by: Jan Kara <jack@suse.cz>
> 
> Hi Jan,
> 
> A simple doubt. Patches acked by you will be automatically picked up
> or will I have to resend it with your ack added ??
  Ah, I realized that probably I should merge this patch since I carry the
ext4 quota reservation patch... Thanks for the reminder. But when I tried
to merge your patch I've found that the warning is already fixed in my tree
by some other patch. I'm sorry. Thanks for your work.

									Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2009-02-12 16:03 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-28  5:17 [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations Manish Katiyar
2009-01-28  5:21 ` Manish Katiyar
2009-01-30 15:00   ` Manish Katiyar
2009-02-02 16:10   ` Jan Kara
2009-02-12  8:54     ` Manish Katiyar
2009-02-12 11:47       ` Theodore Tso
2009-02-12 14:22       ` Jan Kara

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.