From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Subject: Re: [PATCH v2 2/2] mmc: sdhci: intel: Disable runtime pm when the sdio_irq is enabled. Date: Wed, 22 Mar 2017 16:29:07 +0200 Message-ID: References: <20170315163145.15475-1-hdegoede@redhat.com> <20170315163145.15475-2-hdegoede@redhat.com> <7e093710-03d0-30f1-4088-5f68217cb109@intel.com> <2d388dd3-a024-0eea-dc07-c207be0a044c@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mga07.intel.com ([134.134.136.100]:9101 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759133AbdCVOel (ORCPT ); Wed, 22 Mar 2017 10:34:41 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: Hans de Goede , "linux-mmc@vger.kernel.org" , Dong Aisheng On 22/03/17 16:00, Ulf Hansson wrote: > On 22 March 2017 at 13:06, Adrian Hunter wrote: >> On 21/03/17 16:54, Ulf Hansson wrote: >>> On 21 March 2017 at 13:34, Adrian Hunter wrote: >>>> On 21/03/17 12:00, Ulf Hansson wrote: >>>>> On 15 March 2017 at 17:31, Hans de Goede wrote: >>>>>> SDIO cards may need clock to send the card interrupt to the host. >>>>>> >>>>>> On a cherrytrail tablet with a RTL8723BS wifi chip, without this patch >>>>>> pinging the tablet results in: >>>>>> >>>>>> PING 192.168.1.14 (192.168.1.14) 56(84) bytes of data. >>>>>> 64 bytes from 192.168.1.14: icmp_seq=1 ttl=64 time=78.6 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=2 ttl=64 time=1760 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=3 ttl=64 time=753 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=4 ttl=64 time=3.88 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=5 ttl=64 time=795 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=6 ttl=64 time=1841 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=7 ttl=64 time=810 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=8 ttl=64 time=1860 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=9 ttl=64 time=812 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=10 ttl=64 time=48.6 ms >>>>>> >>>>>> Where as with this patch I get: >>>>>> >>>>>> PING 192.168.1.14 (192.168.1.14) 56(84) bytes of data. >>>>>> 64 bytes from 192.168.1.14: icmp_seq=1 ttl=64 time=3.96 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=2 ttl=64 time=1.97 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=3 ttl=64 time=17.2 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=4 ttl=64 time=2.46 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=5 ttl=64 time=2.83 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=6 ttl=64 time=1.40 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=7 ttl=64 time=2.10 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=8 ttl=64 time=1.40 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=9 ttl=64 time=2.04 ms >>>>>> 64 bytes from 192.168.1.14: icmp_seq=10 ttl=64 time=1.40 ms >>>>>> >>>>>> Cc: Dong Aisheng >>>>>> Signed-off-by: Hans de Goede >>>>>> --- >>>>>> Changes in v2: >>>>>> -New patch replacing "mmc: sdhci: sdio-intel: Set >>>>>> SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON quirk" >>>>>> --- >>>>>> drivers/mmc/host/sdhci-acpi.c | 1 + >>>>>> drivers/mmc/host/sdhci-pci-core.c | 1 + >>>>>> drivers/mmc/host/sdhci.c | 6 ++++++ >>>>>> drivers/mmc/host/sdhci.h | 2 ++ >>>>>> 4 files changed, 10 insertions(+) >>>>>> >>>>>> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c >>>>>> index 237f318..53b431a 100644 >>>>>> --- a/drivers/mmc/host/sdhci-acpi.c >>>>>> +++ b/drivers/mmc/host/sdhci-acpi.c >>>>>> @@ -288,6 +288,7 @@ static const struct sdhci_acpi_slot sdhci_acpi_slot_int_emmc = { >>>>>> static const struct sdhci_acpi_slot sdhci_acpi_slot_int_sdio = { >>>>>> .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC, >>>>>> .quirks2 = SDHCI_QUIRK2_HOST_OFF_CARD_ON | >>>>>> + SDHCI_QUIRK2_SDIO_IRQ_NO_RUNTIME_PM | >>>>>> SDHCI_QUIRK2_PRESET_VALUE_BROKEN, >>>>>> .caps = MMC_CAP_NONREMOVABLE | MMC_CAP_POWER_OFF_CARD | >>>>>> MMC_CAP_WAIT_WHILE_BUSY, >>>>>> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c >>>>>> index 982b3e3..a3b242e 100644 >>>>>> --- a/drivers/mmc/host/sdhci-pci-core.c >>>>>> +++ b/drivers/mmc/host/sdhci-pci-core.c >>>>>> @@ -498,6 +498,7 @@ static const struct sdhci_pci_fixes sdhci_ni_byt_sdio = { >>>>>> static const struct sdhci_pci_fixes sdhci_intel_byt_sdio = { >>>>>> .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC, >>>>>> .quirks2 = SDHCI_QUIRK2_HOST_OFF_CARD_ON | >>>>>> + SDHCI_QUIRK2_SDIO_IRQ_NO_RUNTIME_PM | >>>>>> SDHCI_QUIRK2_PRESET_VALUE_BROKEN, >>>>>> .allow_runtime_pm = true, >>>>>> .probe_slot = byt_sdio_probe_slot, >>>>>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c >>>>>> index 6fdd7a7..59c5cad 100644 >>>>>> --- a/drivers/mmc/host/sdhci.c >>>>>> +++ b/drivers/mmc/host/sdhci.c >>>>>> @@ -1828,6 +1828,9 @@ static void sdhci_enable_sdio_irq(struct mmc_host *mmc, int enable) >>>>>> struct sdhci_host *host = mmc_priv(mmc); >>>>>> unsigned long flags; >>>>>> >>>>>> + if ((host->quirks2 & SDHCI_QUIRK2_SDIO_IRQ_NO_RUNTIME_PM) && enable) >>>>>> + pm_runtime_get(host->mmc->parent); >>>>> >>>>> There are currently no sdhci variant for any SoC that implements >>>>> wakeup support in runtime suspend for SDIO irqs. In other words, it >>>>> seems all sdhci hosts suffers from the same problem. >>>> >>>> There might still be drivers that expect SDIO interrupts during >>>> runtime suspend, considering this patch: >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be138554a7923658ded799b0e8794d9c1d08a6e5 >>> >>> Right. Thanks for pointing it out. >>> >>> However I don't think that is how runtime PM should be deployed when >>> it is used for controlling devices like sdhci. Let's change that once >>> we have the common issue for sdhci and SDIO irqs resolved. >> >> Yes, then perhaps we could accept the inverted quirk on the basis that it >> will be removed. > > Well, why have quirk for something that will be always executed. Isn't > it better to invent one, when we see a need for it? I think the idea was to add the quirk to sdhci-esdhc-imx but I doubt sdhci-esdhc-imx is really saving much power with the function and interface clocks still on, so we can dispense with a quirk for now if that is what you prefer. > >> >> Hans, as I wrote somewhere else, we can use pm_runtime_get_noresume() and >> pm_runtime_put_noidle() since sdhci_enable_sdio_irq() must be called with >> the host claimed and therefore runtime resumed. >> > > Good point. This makes it more clear on what goes on. > > Kind regards > Uffe >