All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/15] arm: socfpga: agilex: Add base address for Intel Agilex SoC
Date: Tue, 25 Jun 2019 09:03:12 -0500	[thread overview]
Message-ID: <ea3191b3-10c2-1b8a-628f-b6ec24cc9e4a@kernel.org> (raw)
In-Reply-To: <CAFiDJ5-n_-q0sOEHtMFOnp_pqoOV9KguhvjRQnT-ZFDep+RjEw@mail.gmail.com>



On 6/24/19 8:16 PM, Ley Foon Tan wrote:
> On Tue, Jun 25, 2019 at 4:00 AM Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com> wrote:
>>
>> Am 30.05.2019 um 11:03 schrieb Ley Foon Tan:
>>> Add base address for Intel Agilex SoC.
>>>
>>> Reuse base_addr_s10.h for Agilex, only one base address is
>>> different from S10.
>>>
>>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>>> ---
>>
>> Wait, this is v2, right? What hss changed since v1? I notice v2 has 15
>> patches while v1 had 14.
>>
>> Have you ever considered using patman and its helper tags? It would
>> greatly reduce the effort for reviewers to keep things consistent and
>> including a list of changes in each patch.
>>
>> I mean, when reading v2, I want to rely on you saying "patches 1, 3, and
>> 5 of 14 have changed, the rest have not" to speed up my reviewing.
>> Patman really helps you with that, just try it! And if you don't want
>> to, well, look at how other developers send their multi-version patches...
>>
>> Regards,
>> Simon
>>
> I will look into Patman for next revision.
> 
> Here is summary for this series:
> 
> Patch 1, 5, 6, 7, 8, 13, 14, 15 have changed, the rest have not.
> *Patch 7 is new patch for clock manager driver with DM.
> 

Can you just resend the series with the version changes properly stated
in each patch? Also, its polite to include people in subsequent versions
that have made comments in previous version.

Dinh

  reply	other threads:[~2019-06-25 14:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30  9:03 [U-Boot] [PATCH 00/15] Add Intel Agilex SoC support Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 01/15] arm: socfpga: agilex: Add base address for Intel Agilex SoC Ley Foon Tan
2019-06-24 20:00   ` Simon Goldschmidt
2019-06-25  1:16     ` Ley Foon Tan
2019-06-25 14:03       ` Dinh Nguyen [this message]
2019-07-04  8:14         ` Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 02/15] arm: socfpga: Move firewall code to firewall file Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 03/15] arm: socfpga: Move Stratix10 and Agilex reset manager common code Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 04/15] arm: socfpga: agilex: Add reset manager support Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 05/15] arm: socfpga: Move Stratix10 and Agilex system manager common code Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 06/15] arm: socfpga: agilex: Add system manager support Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 07/15] clk: agilex: Add clock driver for Agilex Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 08/15] arm: socfpga: agilex: Add clock manager support Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 09/15] arm: socfpga: agilex: Add CCU support for Agilex Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 10/15] ddr: altera: Restructure Stratix 10 SDRAM driver Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 11/15] ddr: altera: agilex: Add SDRAM driver for Agilex Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 12/15] board: intel: agilex: Add socdk board support for Intel Agilex SoC Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 13/15] arm: socfpga: agilex: Add SPL for " Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 14/15] arm: dts: agilex: Add base dtsi and devkit dts Ley Foon Tan
2019-05-30  9:03 ` [U-Boot] [PATCH 15/15] arm: socfpga: agilex: Enable Agilex SoC build Ley Foon Tan
2019-06-10  6:31 ` [U-Boot] [PATCH 00/15] Add Intel Agilex SoC support Ley Foon Tan
2019-06-11 13:47   ` Marek Vasut
2019-06-11 14:03     ` Simon Goldschmidt
2019-06-24 19:53 ` Simon Goldschmidt
2019-06-25  1:01   ` Ley Foon Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea3191b3-10c2-1b8a-628f-b6ec24cc9e4a@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.