From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D58C433E0 for ; Fri, 19 Jun 2020 19:05:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A6802100A for ; Fri, 19 Jun 2020 19:05:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726516AbgFSTFK (ORCPT ); Fri, 19 Jun 2020 15:05:10 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:33636 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726065AbgFSTFI (ORCPT ); Fri, 19 Jun 2020 15:05:08 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: xclaesse) with ESMTPSA id 2D15D2A0C0C Message-ID: Subject: Re: [PATCH v1 1/1] Add support for meson building From: Xavier Claessens To: Ezequiel Garcia , kieran.bingham@ideasonboard.com, Ariel D'Alessandro , linux-media@vger.kernel.org Cc: hverkuil@xs4all.nl, sean@mess.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, nicolas@ndufresne.ca, gjasny@googlemail.com, nicolas Dufresne Date: Fri, 19 Jun 2020 15:04:57 -0400 In-Reply-To: References: <20200618133303.28676-1-ariel@vanguardiasur.com.ar> <20200618133303.28676-2-ariel@vanguardiasur.com.ar> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Le vendredi 19 juin 2020 à 11:12 -0300, Ezequiel Garcia a écrit : > I've looked through, and about the only thing that stands out to me > > is > > the way you're joining strings. > > > > Meson provides a join_paths() function specifically for that. > > Now we're "probably" not going to build this library on anything > > other > > than linux, but I think the function still has merit over the > > arbitrary > > strings which I mis-interpreted for 'divide' at first glance :S > > Note that you can also use 'some' / 'path' instead of join_paths('some', 'path'). AFAIK '/' works fine in Windows paths too.