* [PATCH] hw/vfio: Fix typo in comments
@ 2021-07-30 1:26 Cai Huoqing
2021-07-30 11:26 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Cai Huoqing @ 2021-07-30 1:26 UTC (permalink / raw)
To: alex.williamson; +Cc: Cai Huoqing, qemu-devel
Fix typo in comments:
*programatically ==> programmatically
*disconecting ==> disconnecting
*mulitple ==> multiple
*timout ==> timeout
*regsiter ==> register
*forumula ==> formula
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
hw/vfio/igd.c | 2 +-
hw/vfio/pci-quirks.c | 2 +-
hw/vfio/pci.c | 6 +++---
hw/vfio/platform.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index 470205f487..d4685709a3 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -557,7 +557,7 @@ void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr)
* must allocate a 1MB aligned reserved memory region below 4GB with
* the requested size (in bytes) for use by the Intel PCI class VGA
* device at VM address 00:02.0. The base address of this reserved
- * memory region must be written to the device BDSM regsiter at PCI
+ * memory region must be written to the device BDSM register at PCI
* config offset 0x5C.
*/
bdsm_size = g_malloc(sizeof(*bdsm_size));
diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
index e21a6ede11..0cf69a8c6d 100644
--- a/hw/vfio/pci-quirks.c
+++ b/hw/vfio/pci-quirks.c
@@ -1356,7 +1356,7 @@ static bool vfio_radeon_smc_is_running(VFIOPCIDevice *vdev)
/*
* The scope of a config reset is controlled by a mode bit in the misc register
* and a fuse, exposed as a bit in another register. The fuse is the default
- * (0 = GFX, 1 = whole GPU), the misc bit is a toggle, with the forumula
+ * (0 = GFX, 1 = whole GPU), the misc bit is a toggle, with the formula
* scope = !(misc ^ fuse), where the resulting scope is defined the same as
* the fuse. A truth table therefore tells us that if misc == fuse, we need
* to flip the value of the bit in the misc register.
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index e1ea1d8a23..4feaa1cb68 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1364,7 +1364,7 @@ static void vfio_pci_relocate_msix(VFIOPCIDevice *vdev, Error **errp)
* TODO: Lookup table for known devices.
*
* Logically we might use an algorithm here to select the BAR adding
- * the least additional MMIO space, but we cannot programatically
+ * the least additional MMIO space, but we cannot programmatically
* predict the driver dependency on BAR ordering or sizing, therefore
* 'auto' becomes a lookup for combinations reported to work.
*/
@@ -2158,7 +2158,7 @@ static void vfio_pci_pre_reset(VFIOPCIDevice *vdev)
}
/*
- * Stop any ongoing DMA by disconecting I/O, MMIO, and bus master.
+ * Stop any ongoing DMA by disconnecting I/O, MMIO, and bus master.
* Also put INTx Disable in known state.
*/
cmd = vfio_pci_read_config(pdev, PCI_COMMAND, 2);
@@ -2384,7 +2384,7 @@ out_single:
}
/*
- * We want to differentiate hot reset of mulitple in-use devices vs hot reset
+ * We want to differentiate hot reset of multiple in-use devices vs hot reset
* of a single in-use device. VFIO_DEVICE_RESET will already handle the case
* of doing hot resets when there is only a single device per bus. The in-use
* here refers to how many VFIODevices are affected. A hot reset that affects
diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
index cc3f66f7e4..f8f08a0f36 100644
--- a/hw/vfio/platform.c
+++ b/hw/vfio/platform.c
@@ -156,7 +156,7 @@ static void vfio_mmap_set_enabled(VFIOPlatformDevice *vdev, bool enabled)
* if there is no more active IRQ
* @opaque: actually points to the VFIO platform device
*
- * Called on mmap timer timout, this function checks whether the
+ * Called on mmap timer timeout, this function checks whether the
* IRQ is still active and if not, restores the fast path.
* by construction a single eventfd is handled at a time.
* if the IRQ is still active, the timer is re-programmed.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/vfio: Fix typo in comments
2021-07-30 1:26 [PATCH] hw/vfio: Fix typo in comments Cai Huoqing
@ 2021-07-30 11:26 ` Philippe Mathieu-Daudé
2021-09-16 9:58 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-30 11:26 UTC (permalink / raw)
To: Cai Huoqing, alex.williamson; +Cc: QEMU Trivial, qemu-devel
On 7/30/21 3:26 AM, Cai Huoqing wrote:
> Fix typo in comments:
> *programatically ==> programmatically
> *disconecting ==> disconnecting
> *mulitple ==> multiple
> *timout ==> timeout
> *regsiter ==> register
> *forumula ==> formula
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> hw/vfio/igd.c | 2 +-
> hw/vfio/pci-quirks.c | 2 +-
> hw/vfio/pci.c | 6 +++---
> hw/vfio/platform.c | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/vfio: Fix typo in comments
2021-07-30 11:26 ` Philippe Mathieu-Daudé
@ 2021-09-16 9:58 ` Laurent Vivier
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-09-16 9:58 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Cai Huoqing, alex.williamson
Cc: QEMU Trivial, qemu-devel
Le 30/07/2021 à 13:26, Philippe Mathieu-Daudé a écrit :
> On 7/30/21 3:26 AM, Cai Huoqing wrote:
>> Fix typo in comments:
>> *programatically ==> programmatically
>> *disconecting ==> disconnecting
>> *mulitple ==> multiple
>> *timout ==> timeout
>> *regsiter ==> register
>> *forumula ==> formula
>>
>> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
>> ---
>> hw/vfio/igd.c | 2 +-
>> hw/vfio/pci-quirks.c | 2 +-
>> hw/vfio/pci.c | 6 +++---
>> hw/vfio/platform.c | 2 +-
>> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-16 10:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 1:26 [PATCH] hw/vfio: Fix typo in comments Cai Huoqing
2021-07-30 11:26 ` Philippe Mathieu-Daudé
2021-09-16 9:58 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.