From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68B555733D for ; Mon, 18 Mar 2024 20:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710792052; cv=none; b=R+l8VxJu0Vh5XmPJPeQSUxUTZhjoRjbK6UGBsl1Cs2WA3/YiUBT+Cz9BkSO4wuRe5A5IzQ8NrIOo6JfwYwsDfXoM8p+ylomzO0vS4Zo6Leqj6n/+XdonL5XBdOk+vIVwuxn+w0DDmRvOdcyT9aYK7poDnPjsMWK6Cqvfk/hQu0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710792052; c=relaxed/simple; bh=4UU/Wt6ugiN/8OdzdCOP/dpF0PyxGrerAfISuir4TCM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HWXAcRpzsT65iDrgUPnjf/w5/1HNcW77bSqV7NUByujHZBIKykcqA02yvDHvnQuQ1GZ+d9wRptCgc9ewE/E781WusN7IRJ0/P7hSkCgLE0LCL7F+VTyvL75jKX+mvr6zrEZZt7hiQ5//Uv6pjfSmUgdIOIhWQ+Ok0FKwvHQmIgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=GpIwdP4p; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="GpIwdP4p" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2d29aad15a5so59025991fa.3 for ; Mon, 18 Mar 2024 13:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1710792047; x=1711396847; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p/uOKD1vdAmoLenmLGYJq1arvP7Bn4vYf3UI4yux59c=; b=GpIwdP4pDae9aTfcYO2dQ1fi6AFOwngO90B7UwFcXBjn+sS/7OpOM569aRKAo5pF77 pH0cHl6PaWoZG2oACF+pq5pe7cf++3E8U3EiAyje3c9P1zBpS0TxUQEbVSsc0u3tAwJY KXNHo61uMG9TmtNYEy/eiLdobaUdskFBU+AVu9HiRib1dWjz1qprubO29xoYqHIQRj6q sC7WEr0tBBuMMtteLCztg9qi8SE38HSZlkjOpAAvgfi3DiMRtkOV45zNGLa1YnEIfdse XoG3Q3aOZEY+RKH2Rk+ZEjgC7AL/ESLIooaSGoSX99kWcWLl4DxbwojB77jrRZNh36hH vHJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710792047; x=1711396847; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p/uOKD1vdAmoLenmLGYJq1arvP7Bn4vYf3UI4yux59c=; b=lGR7DQCEPGcqjrVIGLehcCEYbYrQ1tQEJv0p5gM8EfeNGhEVaodH6H6oWX0yhteex3 QUroKlz3ExQQcn8b+Z/NH4dhv53EEXiIRFPu4ZQ91R31W/jux8+8QMDQgHkydIipNl/S /G5ggxmvvnSOnpn+OysskCsYl3tXJZ/zdvFNj90ybxRysKuyfghi6vHt4GRetO4WMtCd 2onFd4wiLSTY4slXC8wiCGLDf2pC52DwZlNPUXLIVYpoiws5sLiF7lFVo0vVpSOW6J24 mu9/dyebsFP1QayhDDcn+4+Roq81ldQHczS+hv58tIJUvZ41QO302anHgKVKx1VOknAf DfDw== X-Forwarded-Encrypted: i=1; AJvYcCUoxAFMap87xxnShrVMQS2vGoW/QYju4ykDXaxqWlj0LgrgCCF6/2/4cHsw33ImHL7WukVuf7gSwXY2ZYnjLDZMGDL/tM3VX9M7VtY= X-Gm-Message-State: AOJu0YyF2m6uPJOUR59kgZKEPjw0WTPb/GQk3+HxBbsvoblEY1rKINS3 BN+uXkX0TuiTsRQ5Ec5fjG0bhaLZedncM2GUSOigZ4CERWUDYQZvGpfaDx6gu/5YIPUfFkxxmB5 R X-Google-Smtp-Source: AGHT+IGn0cDzWBnnZPzwWaYjEKj1pD1PrLo79AiavzmxTMEEIb617V/diJW81rlnhNqkOQMDnrvRLw== X-Received: by 2002:a2e:9001:0:b0:2d4:7455:89f4 with SMTP id h1-20020a2e9001000000b002d4745589f4mr7487623ljg.2.1710792047553; Mon, 18 Mar 2024 13:00:47 -0700 (PDT) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id n3-20020a170902e54300b001db37fd26bcsm3595673plf.116.2024.03.18.13.00.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 13:00:46 -0700 (PDT) Message-ID: Date: Tue, 19 Mar 2024 06:30:41 +1030 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] btrfs: New helper to clear EXTENT_BUFFER_READING Content-Language: en-US To: Tavian Barnes , linux-btrfs@vger.kernel.org Cc: Chris Mason , Josef Bacik , David Sterba , linux-kernel@vger.kernel.org References: <477327c2e21e253b56261f504a91603419bb167a.1710769876.git.tavianator@tavianator.com> From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJVBQkNOgemAAoJEMI9kfOh Jf6oapEH/3r/xcalNXMvyRODoprkDraOPbCnULLPNwwp4wLP0/nKXvAlhvRbDpyx1+Ht/3gW p+Klw+S9zBQemxu+6v5nX8zny8l7Q6nAM5InkLaD7U5OLRgJ0O1MNr/UTODIEVx3uzD2X6MR ECMigQxu9c3XKSELXVjTJYgRrEo8o2qb7xoInk4mlleji2rRrqBh1rS0pEexImWphJi+Xgp3 dxRGHsNGEbJ5+9yK9Nc5r67EYG4bwm+06yVT8aQS58ZI22C/UeJpPwcsYrdABcisd7dddj4Q RhWiO4Iy5MTGUD7PdfIkQ40iRcQzVEL1BeidP8v8C4LVGmk4vD1wF6xTjQRKfXHOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJuBQkNOge/AAoJEMI9kfOhJf6o rq8H/3LJmWxL6KO2y/BgOMYDZaFWE3TtdrlIEG8YIDJzIYbNIyQ4lw61RR+0P4APKstsu5VJ 9E3WR7vfxSiOmHCRIWPi32xwbkD5TwaA5m2uVg6xjb5wbdHm+OhdSBcw/fsg19aHQpsmh1/Q bjzGi56yfTxxt9R2WmFIxe6MIDzLlNw3JG42/ark2LOXywqFRnOHgFqxygoMKEG7OcGy5wJM AavA+Abj+6XoedYTwOKkwq+RX2hvXElLZbhYlE+npB1WsFYn1wJ22lHoZsuJCLba5lehI+// ShSsZT5Tlfgi92e9P7y+I/OzMvnBezAll+p/Ly2YczznKM5tV0gboCWeusM= In-Reply-To: <477327c2e21e253b56261f504a91603419bb167a.1710769876.git.tavianator@tavianator.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2024/3/19 00:26, Tavian Barnes 写道: > We are clearing the bit and waking up any waiters in two different > places. Factor that code out into a static helper function. > > Signed-off-by: Tavian Barnes Reviewed-by: Qu Wenruo Thanks, Qu > --- > fs/btrfs/extent_io.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > index 61594eaf1f89..46173dcfde4f 100644 > --- a/fs/btrfs/extent_io.c > +++ b/fs/btrfs/extent_io.c > @@ -4270,6 +4270,13 @@ void set_extent_buffer_uptodate(struct extent_buffer *eb) > } > } > > +static void clear_extent_buffer_reading(struct extent_buffer *eb) > +{ > + clear_bit(EXTENT_BUFFER_READING, &eb->bflags); > + smp_mb__after_atomic(); > + wake_up_bit(&eb->bflags, EXTENT_BUFFER_READING); > +} > + > static void end_bbio_meta_read(struct btrfs_bio *bbio) > { > struct extent_buffer *eb = bbio->private; > @@ -4304,9 +4311,7 @@ static void end_bbio_meta_read(struct btrfs_bio *bbio) > bio_offset += len; > } > > - clear_bit(EXTENT_BUFFER_READING, &eb->bflags); > - smp_mb__after_atomic(); > - wake_up_bit(&eb->bflags, EXTENT_BUFFER_READING); > + clear_extent_buffer_reading(eb); > free_extent_buffer(eb); > > bio_put(&bbio->bio); > @@ -4340,9 +4345,7 @@ int read_extent_buffer_pages(struct extent_buffer *eb, int wait, int mirror_num, > * will now be set, and we shouldn't read it in again. > */ > if (unlikely(test_bit(EXTENT_BUFFER_UPTODATE, &eb->bflags))) { > - clear_bit(EXTENT_BUFFER_READING, &eb->bflags); > - smp_mb__after_atomic(); > - wake_up_bit(&eb->bflags, EXTENT_BUFFER_READING); > + clear_extent_buffer_reading(eb); > return 0; > } >