From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D19FC43217 for ; Thu, 20 Oct 2022 12:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230077AbiJTMSr (ORCPT ); Thu, 20 Oct 2022 08:18:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbiJTMSo (ORCPT ); Thu, 20 Oct 2022 08:18:44 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95CB719188B for ; Thu, 20 Oct 2022 05:18:42 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id h10so13351161qvq.7 for ; Thu, 20 Oct 2022 05:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6P29Au+mNsUaLWGRFWpA1rpC+F5XcqKKfHLDcUXt2LM=; b=gX0c4gwqfE3LYsCNebzbubSDDy44gkgCDd/bgcEYCNFxJ3S3V+Os771bMGcp2U4SQa /YTGk8l7AdlBYLAjV4+LpSfweRGV0Ee/1DEuBzUXa4cRaF42Owp8B7he2aHeYARRSXez tqijng7a14Hgs8m1Ozz/SfS09dRAdLNP1QWHIXPahDZFyoqiEIpplf/Fq5p5rrp0CDAN ky/rLt6V0kKS5J8acDZh9vnF/XIAvFuF+8RxNp/PXd8A3FVPc7sTTG7tDR0aLbCrCyjA zDqMRJ6s+IUg7ggVW2OtRNRp7iogxPq+lFMQWwZ3513MQytj8dgURnKL+1E7kWrM5+Ty /Zrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6P29Au+mNsUaLWGRFWpA1rpC+F5XcqKKfHLDcUXt2LM=; b=1xy2z1Y230qkPL1MZ4BENuGzpAxybYHr5Xrz7ZrkSy+n5xVoJO5dcCwKTXiFjXwgdp oEQXuI4v9o1/2EhrbYrDpim87HR5w0o8yPPRTM6AE4ypOa/tF+4nlomH8M/lEUmF5K+Z XkaUyxCaVDg7EQ8eSETZzhjplCjHLDhnSdzCapF9lP7xgTyc6e1ioIekSoz++IleKhuk l5Hep9WZxauXKv48Sa0hoXMXsATXy/YYTSYjHfFWMXa6pBcuBB1zh3Yrh4QGJYw7riOM mW0mVAnA0ovEgVeo1dSYEruGdkUdd09bkW5GVktr1WjUwqvgcjoAxamUiiTX57/Hcr61 4KwQ== X-Gm-Message-State: ACrzQf1JalzCj4aYKdv2Ag0v4t4mj8MjeLQw/TVcAguC54XXjl3DZoiN Q/YjXR7BfkHOKnJ1kwH2jzJqUeCpFqiNBA== X-Google-Smtp-Source: AMsMyM6cXFBCkNgP0DqHpNDj7XnN6Spz2TY86LLtTMXRJIAvMaTzzlwSmMWcFPK2MjNbKNTmSJkqtw== X-Received: by 2002:a05:6214:2242:b0:4b1:ccb3:aced with SMTP id c2-20020a056214224200b004b1ccb3acedmr10831498qvc.51.1666268321693; Thu, 20 Oct 2022 05:18:41 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id g8-20020ac87f48000000b0035cf31005e2sm6172602qtk.73.2022.10.20.05.18.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 05:18:40 -0700 (PDT) Message-ID: Date: Thu, 20 Oct 2022 08:18:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode Content-Language: en-US To: Andrej Picej , Alexander Stein Cc: linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, wim@linux-watchdog.org, robh+dt@kernel.org References: <20221019111714.1953262-1-andrej.picej@norik.com> <20221019111714.1953262-3-andrej.picej@norik.com> <7508670.GXAFRqVoOG@steina-w> <56118d35-dfe6-f46b-9fc7-28aca6530fb5@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/10/2022 02:23, Andrej Picej wrote: > Hi Alexander and Krzysztof, > > hope I can reply to both questions here. > > On 19. 10. 22 17:51, Krzysztof Kozlowski wrote: >> On 19/10/2022 09:00, Alexander Stein wrote: >>> Hello Andrej, >>> >>> Am Mittwoch, 19. Oktober 2022, 13:17:13 CEST schrieb Andrej Picej: >> >> Missing commit msg. >> >>>> Signed-off-by: Andrej Picej >>>> --- >>>> Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>>> b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml index >>>> fb7695515be1..01b3e04e7e65 100644 >>>> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>>> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>>> @@ -55,6 +55,11 @@ properties: >>>> If present, the watchdog device is configured to assert its >>>> external reset (WDOG_B) instead of issuing a software reset. >>>> >>>> + fsl,suspend-in-wait: >>>> + $ref: /schemas/types.yaml#/definitions/flag >>>> + description: | >>>> + If present, the watchdog device is suspended in WAIT mode. >>>> + >>>> required: >>>> - compatible >>>> - interrupts >>> >>> What is the condition the watchdog is suspended in WAIT mode? Is this specific >>> to SoC or platform or something else? >>> >> > > Sorry, what exactly do you mean by condition? Ugh, I also cannot parse it now... > When the property > "fsl,suspend-in-wait" is set the watchdog is suspended in WAIT mode, so > this is defined by the user. Didn't want to apply it for all the > supported machines since there could be devices which depend on watchdog > triggering in WAIT mode. We stumbled on this problem on imx6 devices, > but the same bit (with the same description) is found on imx25, imx35, > imx50/51/53, imx7 and imx8. I meant, what is expected to happen if you do not enable this bit and watchdog triggers in WAIT mode? IOW, why someone might want to enable or disable this property? > >> And what happens else? When it is not suspended in WAIT mode? >> > > When you put the device in "freeze"/"Suspend-To-Idle" low-power mode the > watchdog keeps running and triggers a reset after 128 seconds. So the > maximum length the device can stay in this mode is limited to 128 seconds. And who wakes up the system before 128 seconds? IOW is there a use case of not enabling this property? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92C70C433FE for ; Thu, 20 Oct 2022 12:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pl+sERIBlA1MKWYDRfj+R/gghzpPyg6jYOzQy/1fgUE=; b=be48AOsmIlYULV OkoPrjpLmzyAH752G6KB1ub734sUtWHJgjnDfwkRi/qk0tFPpRPD0mYD8sjWLxssvlLh0Spdtiunc 2Dq0NJfHiSBnD9MYFfffqMn4OTNgAdwip5AKh/Fc/9NB/SaNhFPSiIqV7Ndo3aVn79ipi0RHuUxK1 gqapCkp/nD2y53qXs/rKKhrYAPlbTE9GGu93+Qw/abcI8CZiy5AIP7oAO7HO5rjsnptuQ3VFOpBwQ u1EjmCU+U0A4bUEDA9b6yvlVzxUcrH3Ijc7v2ofktNKGb3i3p0TQlKbvpNtt62qidK6RI+BNIF3Cf I2QUZpmsbT8vQI27U0Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olUvP-00EylC-LX; Thu, 20 Oct 2022 12:45:28 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olUVZ-00EfRn-4s for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 12:18:46 +0000 Received: by mail-qv1-xf35.google.com with SMTP id x15so585289qvp.1 for ; Thu, 20 Oct 2022 05:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6P29Au+mNsUaLWGRFWpA1rpC+F5XcqKKfHLDcUXt2LM=; b=gX0c4gwqfE3LYsCNebzbubSDDy44gkgCDd/bgcEYCNFxJ3S3V+Os771bMGcp2U4SQa /YTGk8l7AdlBYLAjV4+LpSfweRGV0Ee/1DEuBzUXa4cRaF42Owp8B7he2aHeYARRSXez tqijng7a14Hgs8m1Ozz/SfS09dRAdLNP1QWHIXPahDZFyoqiEIpplf/Fq5p5rrp0CDAN ky/rLt6V0kKS5J8acDZh9vnF/XIAvFuF+8RxNp/PXd8A3FVPc7sTTG7tDR0aLbCrCyjA zDqMRJ6s+IUg7ggVW2OtRNRp7iogxPq+lFMQWwZ3513MQytj8dgURnKL+1E7kWrM5+Ty /Zrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6P29Au+mNsUaLWGRFWpA1rpC+F5XcqKKfHLDcUXt2LM=; b=xSpzM4sKbGa9zFhyWdbBHJbnfXBT4QNvF1dWG0vXKUGSyhiM8Jd2xQEox1TvPsfz36 RQfmVuhLMTbwG/9r+hIAr4mlRfrqgG4emfkVUSgGac7TtigP2MpM4DQiVwtZCrcanJfN Bngj8WLJ8Jv5fer4eUqeWsiKeml8ig4MOTPYc+Jze+63kSdxqN5tD/oWsltO+6w1MRQ1 ac/jj3MvIlw7znskEFaKqqM9kngCybbyh+owvOMcxUhLakml38/YpTp4R5DrJVZAHR/J cIliZqzvl3TWalb6AnUUNBkXJltQUkkR+dP3YSXBSbPR/2+w1zKYCQbCiDH7LC8sn8i/ BUag== X-Gm-Message-State: ACrzQf3oBy6ZhGktp5mc+srGY0dD4PL2Wq6g1pbyseC1F3eh/KqOnxj0 54FiHj0VafbnxjMuNrObWCoFxQ== X-Google-Smtp-Source: AMsMyM6cXFBCkNgP0DqHpNDj7XnN6Spz2TY86LLtTMXRJIAvMaTzzlwSmMWcFPK2MjNbKNTmSJkqtw== X-Received: by 2002:a05:6214:2242:b0:4b1:ccb3:aced with SMTP id c2-20020a056214224200b004b1ccb3acedmr10831498qvc.51.1666268321693; Thu, 20 Oct 2022 05:18:41 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id g8-20020ac87f48000000b0035cf31005e2sm6172602qtk.73.2022.10.20.05.18.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 05:18:40 -0700 (PDT) Message-ID: Date: Thu, 20 Oct 2022 08:18:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode Content-Language: en-US To: Andrej Picej , Alexander Stein Cc: linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, wim@linux-watchdog.org, robh+dt@kernel.org References: <20221019111714.1953262-1-andrej.picej@norik.com> <20221019111714.1953262-3-andrej.picej@norik.com> <7508670.GXAFRqVoOG@steina-w> <56118d35-dfe6-f46b-9fc7-28aca6530fb5@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_051845_288764_A1884363 X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/10/2022 02:23, Andrej Picej wrote: > Hi Alexander and Krzysztof, > > hope I can reply to both questions here. > > On 19. 10. 22 17:51, Krzysztof Kozlowski wrote: >> On 19/10/2022 09:00, Alexander Stein wrote: >>> Hello Andrej, >>> >>> Am Mittwoch, 19. Oktober 2022, 13:17:13 CEST schrieb Andrej Picej: >> >> Missing commit msg. >> >>>> Signed-off-by: Andrej Picej >>>> --- >>>> Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>>> b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml index >>>> fb7695515be1..01b3e04e7e65 100644 >>>> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>>> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>>> @@ -55,6 +55,11 @@ properties: >>>> If present, the watchdog device is configured to assert its >>>> external reset (WDOG_B) instead of issuing a software reset. >>>> >>>> + fsl,suspend-in-wait: >>>> + $ref: /schemas/types.yaml#/definitions/flag >>>> + description: | >>>> + If present, the watchdog device is suspended in WAIT mode. >>>> + >>>> required: >>>> - compatible >>>> - interrupts >>> >>> What is the condition the watchdog is suspended in WAIT mode? Is this specific >>> to SoC or platform or something else? >>> >> > > Sorry, what exactly do you mean by condition? Ugh, I also cannot parse it now... > When the property > "fsl,suspend-in-wait" is set the watchdog is suspended in WAIT mode, so > this is defined by the user. Didn't want to apply it for all the > supported machines since there could be devices which depend on watchdog > triggering in WAIT mode. We stumbled on this problem on imx6 devices, > but the same bit (with the same description) is found on imx25, imx35, > imx50/51/53, imx7 and imx8. I meant, what is expected to happen if you do not enable this bit and watchdog triggers in WAIT mode? IOW, why someone might want to enable or disable this property? > >> And what happens else? When it is not suspended in WAIT mode? >> > > When you put the device in "freeze"/"Suspend-To-Idle" low-power mode the > watchdog keeps running and triggers a reset after 128 seconds. So the > maximum length the device can stay in this mode is limited to 128 seconds. And who wakes up the system before 128 seconds? IOW is there a use case of not enabling this property? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel