From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [alsa-devel] [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement Date: Fri, 11 Jan 2019 09:15:42 +0000 Message-ID: References: <20181218174040.k7u26vnnoplllnwb@camel2.lan> <952471da-b355-6471-6c19-5120d6704f81@nvidia.com> <87lg3vuc7p.wl-kuninori.morimoto.gx@renesas.com> <865d2a3e-bf6b-1f30-1179-7e922c0d0641@nvidia.com> <87k1je38w7.wl-kuninori.morimoto.gx@renesas.com> <0660a471-3698-2059-4494-ad146518a4ed@nvidia.com> <20190109125340.GD10405@sirena.org.uk> <52f5f2cf-9260-f9c5-f73d-3c3d5debc86b@nvidia.com> <20190109141439.GE10405@sirena.org.uk> <875zuxb9uy.wl-kuninori.morimoto.gx@renesas.com> <871s5kqb43.wl-kuninori.morimoto.gx@renesas.com> <87h8efpoxh.wl-kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87h8efpoxh.wl-kuninori.morimoto.gx@renesas.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Kuninori Morimoto Cc: Mark Brown , Liam Girdwood , linux-tegra@vger.kernel.org, Matthias Reichl , alsa-devel@alsa-project.org, Marcel Ziswiler , Takashi Iwai , linux-kernel@vger.kernel.org, Marcel Ziswiler List-Id: linux-tegra@vger.kernel.org On 11/01/2019 08:51, Kuninori Morimoto wrote: >>> Indeed there is such case so far, but my understanding is that current >>> driver should select "legacy style" or "modern style". >>> If driver setup it as "legacy", but access to "modern" member, >>> it is driver side bug, right ? >> >> Yes absolutely it is a driver bug, but looking at the snd_soc_dai_link >> structure today it is not clear what the driver should be setting and >> what is 'modern' and what is 'legacy'. You need to dig through the git >> history and code to figure this out. So you could say it is not very >> well documented/commented from a soc-core perspective and could be easy >> for a driver writer to get themselves in a pickle/mess. Anyway, that is >> easy to fix and we could add some comments to clear it up. > > Thank you for your feedback. > Yes, indeed there is no enough information/documentation about > legacy/modern style, and its plan > (= all driver will be switched to modern, legacy will be removed, etc, etc..). > > So, can you agree about these ? > 1) Add enough information/documentation about legacy/modern style and its plan. > 2) Add dirty pointer fixup patch as workaround > 3) switch to modern style as much as possible I think that Mark needs to decided on whether use your 'dirty pointer' fix or not. Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF635C43387 for ; Fri, 11 Jan 2019 09:15:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89AAD20870 for ; Fri, 11 Jan 2019 09:15:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="DsDYTZNh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731370AbfAKJPs (ORCPT ); Fri, 11 Jan 2019 04:15:48 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:12270 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731355AbfAKJPr (ORCPT ); Fri, 11 Jan 2019 04:15:47 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 11 Jan 2019 01:15:20 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Fri, 11 Jan 2019 01:15:46 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Fri, 11 Jan 2019 01:15:46 -0800 Received: from [10.21.132.148] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 11 Jan 2019 09:15:44 +0000 Subject: Re: [alsa-devel] [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement To: Kuninori Morimoto CC: Mark Brown , Liam Girdwood , , Matthias Reichl , , Marcel Ziswiler , Takashi Iwai , , Marcel Ziswiler References: <20181218174040.k7u26vnnoplllnwb@camel2.lan> <952471da-b355-6471-6c19-5120d6704f81@nvidia.com> <87lg3vuc7p.wl-kuninori.morimoto.gx@renesas.com> <865d2a3e-bf6b-1f30-1179-7e922c0d0641@nvidia.com> <87k1je38w7.wl-kuninori.morimoto.gx@renesas.com> <0660a471-3698-2059-4494-ad146518a4ed@nvidia.com> <20190109125340.GD10405@sirena.org.uk> <52f5f2cf-9260-f9c5-f73d-3c3d5debc86b@nvidia.com> <20190109141439.GE10405@sirena.org.uk> <875zuxb9uy.wl-kuninori.morimoto.gx@renesas.com> <871s5kqb43.wl-kuninori.morimoto.gx@renesas.com> <87h8efpoxh.wl-kuninori.morimoto.gx@renesas.com> From: Jon Hunter Message-ID: Date: Fri, 11 Jan 2019 09:15:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87h8efpoxh.wl-kuninori.morimoto.gx@renesas.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1547198121; bh=1rrvMM4MjDeO//ECKMPyDeXrm6Ya4/OwKYxd/hh4D14=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=DsDYTZNhPgMJ3FDbLxs78qyl1Hn3WGNpHIGRlvG5LfkIFdfswnEuqwQryE1vOrODg UX4oCRAQ4yLH4DC9pqt4V1iWn7e7TwZawUBSSC+/EC0bLgSBNYA3p9oz/9RLQXkQ4n 4t+faVsgEQkeRuGfYCeQwtwe5Ji/U+iy1MbQ6qM/304xNmzCSJcxhU0TSfpt1vnJgo BKejbAhKVYdbJbG4EOL/LRvbyYCGGVQRRF7SPlyez5Yiz6ruF4cPKb9ynWwx4RPKrx M2plav0bbaOXeO1wv/jkgaEhUqaQrEToQZeEMBJpvHhINGSb8iLkhj5IIr5EvDud70 ETRac366QakoA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/2019 08:51, Kuninori Morimoto wrote: >>> Indeed there is such case so far, but my understanding is that current >>> driver should select "legacy style" or "modern style". >>> If driver setup it as "legacy", but access to "modern" member, >>> it is driver side bug, right ? >> >> Yes absolutely it is a driver bug, but looking at the snd_soc_dai_link >> structure today it is not clear what the driver should be setting and >> what is 'modern' and what is 'legacy'. You need to dig through the git >> history and code to figure this out. So you could say it is not very >> well documented/commented from a soc-core perspective and could be easy >> for a driver writer to get themselves in a pickle/mess. Anyway, that is >> easy to fix and we could add some comments to clear it up. > > Thank you for your feedback. > Yes, indeed there is no enough information/documentation about > legacy/modern style, and its plan > (= all driver will be switched to modern, legacy will be removed, etc, etc..). > > So, can you agree about these ? > 1) Add enough information/documentation about legacy/modern style and its plan. > 2) Add dirty pointer fixup patch as workaround > 3) switch to modern style as much as possible I think that Mark needs to decided on whether use your 'dirty pointer' fix or not. Jon -- nvpublic