From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40F81C4332F for ; Thu, 17 Nov 2022 16:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zGZDWiN8LIQjBskslerYUOoiascgASW6wrDjai8IqFc=; b=U+oqkrhF4DJ6o3 T4ZrtshDyA0O19uMWBLPRdOpesa2CVk2pK6MDarZUWN482+Vx4IstlbJeC7M3lBI/Q2cs5XyIJdSK sP8C0scwZMMwoKNk1cWPfsQyc2KLF3hK7aLBFY+gIjZeW/gIMfuqVVyNV7juC3tO2ULWBkF/83up1 +OqG7RQfL+Pz0SbgeEeiIt3dsh6bzd38QU4E3kbWO3sTsthvXLDw0Lviu/cW/pabjzZUGQv/DX62F ysi3hE1j+pVZcNrEexM7aeNA3v6goRR+28wlcMiwV0sohAorN381tvgYFNNsDZZNuxtBlm76WuHxB ZR1F2AnbZNt2J23hcacw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovhoI-00FxPW-Na; Thu, 17 Nov 2022 16:32:19 +0000 Received: from mx4.securetransport.de ([178.254.6.145]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovhkG-00FvCn-M4 for linux-arm-kernel@lists.infradead.org; Thu, 17 Nov 2022 16:28:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1668702460; bh=H+3POvLcMB/2sXOAktbUJZAKxLZhFxA1ywC4FrmX/3I=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=fMYUOA7Swx9j6abeA33r3smk9s9OzUU1B/iuSjcWuIHUt95IpEvZNh+/GBcAJZ1L2 N399kEbkR6sZQ6SPJEY2AiY67kbef3TEnxjC4NroXvmOplur/YTMc/DV9u/6MkOhZ2 yUtsE1G0+W6slZVDnsFBAPL6EtrYsSqb0GFuEbtRyHUt3oZMA5euShWPVHj9bQ/WoY dNrjh/MJPEXsXi04kmIoiqtxizA/5rWCedaxGeODr6fZgKHcg3k/pYLXdKIm3z/cqJ O/KJeGUz7rrjBUOM1gnCGhOYnyFZNVRuGJpOfkiTJi7+1wIzAHa07gIWXzv4XtEmnT AfqqQo6pr5ysQ== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Krzysztof Kozlowski CC: Rob Herring , Krzysztof Kozlowski , Peng Fan , Shawn Guo , Marek Vasut , Fabio Estevam , NXP Linux Team , kernel , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 2/4] ARM: dts: imx6ull-dhcom: Add DH electronics DHCOM i.MX6ULL SoM and PDK2 board Thread-Topic: [PATCH 2/4] ARM: dts: imx6ull-dhcom: Add DH electronics DHCOM i.MX6ULL SoM and PDK2 board Thread-Index: AQHY+m/i8HDH8ZvdakChfjIb9+/Inq5DBgkAgAAbXGD///1/AIAALtIQ Date: Thu, 17 Nov 2022 16:27:34 +0000 Message-ID: References: <20221117103134.6452-1-cniedermaier@dh-electronics.com> <20221117103134.6452-3-cniedermaier@dh-electronics.com> <2333f957-5ff8-da99-7862-ba9eb794c20c@linaro.org> <31567c6722b34abba179f330cab004db@dh-electronics.com> <2bc5b167-a453-bbb4-9feb-c03913874740@linaro.org> In-Reply-To: <2bc5b167-a453-bbb4-9feb-c03913874740@linaro.org> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_082809_048387_481EA314 X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] Sent: Thursday, November 17, 2022 3:39 PM > On 17/11/2022 15:11, Christoph Niedermaier wrote: >>>> +&fec2 { /* DHCOM ETH2 */ >>>> + phy-handle = <&mdio2_phy1>; >>>> + phy-mode = "rmii"; >>>> + pinctrl-0 = <&pinctrl_fec2>; >>>> + pinctrl-names = "default"; >>>> + status = "okay"; >>>> + >>>> + mdio { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + >>>> + mdio2_phy0: ethernet-phy@0 { /* SMSC LAN8710Ai */ >>>> + clock-names = "rmii-ref"; >>>> + clocks = <&clks IMX6UL_CLK_ENET_REF>; >>>> + compatible = "ethernet-phy-id0007.c0f0", >>>> + "ethernet-phy-ieee802.3-c22"; >>>> + interrupt-parent = <&gpio5>; >>>> + interrupts = <5 IRQ_TYPE_LEVEL_LOW>; >>>> + pinctrl-0 = <&pinctrl_fec1_phy &pinctrl_snvs_fec1_phy>; >>>> + pinctrl-names = "default"; >>>> + reg = <0>; >>> >>> compatible first, reg second, then the rest of properties. Same in other >>> places. >> >> Sorry, I have sorted it alphabetically. >> Should the status property be sorted at the end or also alphabetically? > > You do not have status here. For the cases where it is present, depends > on the preferences of subarch maintainer. Usually it also goes to the > end, but not always. Thanks for the clarification. Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel