From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6662C433ED for ; Sat, 10 Apr 2021 12:40:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A267A610CB for ; Sat, 10 Apr 2021 12:40:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234626AbhDJMkh (ORCPT ); Sat, 10 Apr 2021 08:40:37 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:45742 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234091AbhDJMka (ORCPT ); Sat, 10 Apr 2021 08:40:30 -0400 Received: from mail-ed1-f69.google.com ([209.85.208.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lVCuL-0002YQ-B3 for linux-kernel@vger.kernel.org; Sat, 10 Apr 2021 12:40:13 +0000 Received: by mail-ed1-f69.google.com with SMTP id o9so574829edq.16 for ; Sat, 10 Apr 2021 05:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k8kbv7tLUPin7vEZz6Y8S8Ho2i9EHLVgMoQhgUpPZTc=; b=OO8qVJuU9zI7kl4q5wh2Hw+t1/mTfN3s30cQPpEeiJhPMBvb1G/Hsf1hyPbw2ZlQDX xYTDS/ebiUYyvQmoeXRJfFScPbW5B3677INIX3WOnGxvGtaKsWLoKe9kolUKwao7W0Rc /yGuu5PYMvA+ccD298AR6l7P5KPYEAUW/wICHSseaBXjtOA/4Fdm5LX+KwjVR7zQ3Jvz VKoGgb6zd+NjOcXa9W8UoP1leDUXK/fgfShjLBPIZQ5IhIJ5et5RjuUBhFxgafp4ij0e IblXqWjM7lJBgTAGCF1S+JddRK2732PSWjWuXC0KYYks5BfK2r9ooXxmUZdeJ3VXVxlM flCw== X-Gm-Message-State: AOAM532HWv8twvu38+3LB0b86UhwMzS7CMCdp5LcpIXY5wvSIU4t61Ps pRNif2QYqu1Yo1ZM5b3D6mRhB2qKptzlZnNWVnlys8HaH4nPpEhiOkUJShTRMyDu2GpjeZ2qnpI qfLI6ubpBhccqcgm4NvWOL8IFk8iYMVKCC92zmflUuQ== X-Received: by 2002:a05:6402:148a:: with SMTP id e10mr21482429edv.377.1618058413094; Sat, 10 Apr 2021 05:40:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnEqzqI9N9YfHRefBuhHMer8IAZFUeA1p/w31AAx1VON2hHKiqTW68RFjQfE3PCZ9Bpj9RyA== X-Received: by 2002:a05:6402:148a:: with SMTP id e10mr21482422edv.377.1618058412954; Sat, 10 Apr 2021 05:40:12 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id d6sm3149960edr.21.2021.04.10.05.40.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Apr 2021 05:40:12 -0700 (PDT) Subject: Re: [PATCH v5 04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common To: Yong Wu , Matthias Brugger , Joerg Roedel , Rob Herring Cc: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, Nicolas Boichat , Matthias Kaehlcke , anan.sun@mediatek.com, chao.hao@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, eizan@chromium.org, acourbot@chromium.org References: <20210410091128.31823-1-yong.wu@mediatek.com> <20210410091128.31823-5-yong.wu@mediatek.com> From: Krzysztof Kozlowski Message-ID: Date: Sat, 10 Apr 2021 14:40:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210410091128.31823-5-yong.wu@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/04/2021 11:11, Yong Wu wrote: > Normally, If the smi-larb HW need work, we should enable the smi-common > HW power and clock firstly. > This patch adds device-link between the smi-larb dev and the smi-common > dev. then If pm_runtime_get_sync(smi-larb-dev), the pm_runtime_get_sync > (smi-common-dev) will be called automatically. > > Also, Add DL_FLAG_STATELESS to avoid the smi-common clocks be gated when > probe. > > CC: Matthias Brugger > Suggested-by: Tomasz Figa > Signed-off-by: Yong Wu > --- > drivers/memory/mtk-smi.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) I understood this is a dependency for other patches, so: Acked-by: Krzysztof Kozlowski If I am wrong and I can take it via memory tree, let me know. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB0CC433B4 for ; Sat, 10 Apr 2021 12:40:24 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77635610F9 for ; Sat, 10 Apr 2021 12:40:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77635610F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 358D2607CE; Sat, 10 Apr 2021 12:40:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nwj-Fpy5JjMI; Sat, 10 Apr 2021 12:40:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id 7F8CC60624; Sat, 10 Apr 2021 12:40:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 55BF5C000C; Sat, 10 Apr 2021 12:40:18 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 169F0C000A for ; Sat, 10 Apr 2021 12:40:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E24FF40454 for ; Sat, 10 Apr 2021 12:40:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VyQVdlJOlnmJ for ; Sat, 10 Apr 2021 12:40:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by smtp4.osuosl.org (Postfix) with ESMTPS id E19454044B for ; Sat, 10 Apr 2021 12:40:15 +0000 (UTC) Received: from mail-ed1-f69.google.com ([209.85.208.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lVCuL-0002Yg-GD for iommu@lists.linux-foundation.org; Sat, 10 Apr 2021 12:40:13 +0000 Received: by mail-ed1-f69.google.com with SMTP id b8so589928ede.5 for ; Sat, 10 Apr 2021 05:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k8kbv7tLUPin7vEZz6Y8S8Ho2i9EHLVgMoQhgUpPZTc=; b=UpQCl2GZ4SxR2ikwaB/YV5IyN4E1/7e5dhnUHZI53AbomuFwVHyjtfZlSVzqUo7u/q 7Bh/E7NgOG8DKRBlgO7eYDCSo7/sogdEYCmHLy63FO0OXjpfTj0moirAQu23QDa2RJYt CIfT+UY0XJsQRiUzEofZi2zFwOrWHAd4dxmfpc5pGU7hQiFE3iymU1seZwjWaD2ks10k xl8/CYmwNckJueDpCBQBRptioD7pw2hrjvIG8VUhmgzFy5HzQq5p8/Ef8Nwc/fzDZrQ0 Fl4xDidkMZvfQpp1BL/6upGxrL6dQ6ixowadqOBUJx2/IYupMCGi5uKYtfDKwGgf2mPA enBw== X-Gm-Message-State: AOAM5333z16gfku6I87J4z1FT5x4irxiJ+YibRrVA8fAmF4ziHfYMM8j CIrIMPRN8iONrwvoJtEHOK4kPdfVLqo5ki3JUA/Ct5UuuJuylqDQ3A9hcI6wWrysORBxApbQEOt JyPwX4KYOx+M+5jIgxTZMSJGNCB1v8z56nqkEZ/6tlg5uRDQ= X-Received: by 2002:a05:6402:148a:: with SMTP id e10mr21482432edv.377.1618058413094; Sat, 10 Apr 2021 05:40:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnEqzqI9N9YfHRefBuhHMer8IAZFUeA1p/w31AAx1VON2hHKiqTW68RFjQfE3PCZ9Bpj9RyA== X-Received: by 2002:a05:6402:148a:: with SMTP id e10mr21482422edv.377.1618058412954; Sat, 10 Apr 2021 05:40:12 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id d6sm3149960edr.21.2021.04.10.05.40.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Apr 2021 05:40:12 -0700 (PDT) Subject: Re: [PATCH v5 04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common To: Yong Wu , Matthias Brugger , Joerg Roedel , Rob Herring References: <20210410091128.31823-1-yong.wu@mediatek.com> <20210410091128.31823-5-yong.wu@mediatek.com> From: Krzysztof Kozlowski Message-ID: Date: Sat, 10 Apr 2021 14:40:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210410091128.31823-5-yong.wu@mediatek.com> Content-Language: en-US Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, yi.kuo@mediatek.com, Nicolas Boichat , acourbot@chromium.org, srv_heupstream@mediatek.com, eizan@chromium.org, Will Deacon , linux-kernel@vger.kernel.org, Evan Green , chao.hao@mediatek.com, iommu@lists.linux-foundation.org, Matthias Kaehlcke , linux-mediatek@lists.infradead.org, ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Robin Murphy , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 10/04/2021 11:11, Yong Wu wrote: > Normally, If the smi-larb HW need work, we should enable the smi-common > HW power and clock firstly. > This patch adds device-link between the smi-larb dev and the smi-common > dev. then If pm_runtime_get_sync(smi-larb-dev), the pm_runtime_get_sync > (smi-common-dev) will be called automatically. > > Also, Add DL_FLAG_STATELESS to avoid the smi-common clocks be gated when > probe. > > CC: Matthias Brugger > Suggested-by: Tomasz Figa > Signed-off-by: Yong Wu > --- > drivers/memory/mtk-smi.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) I understood this is a dependency for other patches, so: Acked-by: Krzysztof Kozlowski If I am wrong and I can take it via memory tree, let me know. Best regards, Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53CEBC433ED for ; Sat, 10 Apr 2021 12:40:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9A4D610CC for ; Sat, 10 Apr 2021 12:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9A4D610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=He3wUdOSvbSShL9PJGkQF2eFPofCKRFjFSygwj99wSY=; b=dsCTpa6M3uPBglXbS9zB53RM7 3cAJp0rAEjokX0fhQMArmuN4b91y4qm2Tdkn8PI91YGLt0n8jKH0DRlFMYAsXQP7DY5KNt1kMPGw0 YKmW9yYKZ38Zp7kDdpezLeRUf66SkUlJ5K+PSzDCgbRg582dYHFFBQ4l/oBTJbvU/gZj+MA1+dv9Q PGlg4Ms/b81abTVDY0FHpqFqitkIDEEeMJzTY3aVycTWf3KnWg2MaerUiXA/55CfijCM7keOIGM4r RLkaHwixAYVell9TIpQ8KtOyM1+G8FCwcfRQk3T6oBt+64Q2dzbR6EG8X8/P/xr2yi4ntK6AhY2/8 JKrL43J0A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVCud-002pGf-Lr; Sat, 10 Apr 2021 12:40:31 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVCuS-002pEY-Py for linux-mediatek@desiato.infradead.org; Sat, 10 Apr 2021 12:40:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=k8kbv7tLUPin7vEZz6Y8S8Ho2i9EHLVgMoQhgUpPZTc=; b=sH7AU7kTTfj1TUN270Sr97+awl fDLCdVPXFw8XfOUdrfNXt8Rz59P+W2j2PcHTeYW8CvNuVr5aFpC7FbwZMCixVioLlBFth9TXf5IPx JOHwOpe9vwMoYrcCiW0GsGRWIZemzpxIzRzqsfV/fZgZ1I299L6iAyr9+to5EInKAXGbkEZT7T1M3 7ajQIEoAZG7xhmcZ64GYqPIKu/GIyP3yNZ+LoMLo4YdhQx74yE8mvgxcYl7jl8Q9wDbuOW/eqsblQ QgWJZe0ZX4HZmS52UYrAgIbpmXEGcA8/lI8f33p3tgU9llAXXu6LlZKCX4BDBErtb7HV2nt3wdYS7 DyPH9xIg==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVCuQ-0055uH-0M for linux-mediatek@lists.infradead.org; Sat, 10 Apr 2021 12:40:19 +0000 Received: from mail-ed1-f69.google.com ([209.85.208.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lVCuL-0002YU-BG for linux-mediatek@lists.infradead.org; Sat, 10 Apr 2021 12:40:13 +0000 Received: by mail-ed1-f69.google.com with SMTP id h5so579359edf.17 for ; Sat, 10 Apr 2021 05:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k8kbv7tLUPin7vEZz6Y8S8Ho2i9EHLVgMoQhgUpPZTc=; b=MWALYQ78L2b1wh/8R9oinGirCXJ03A5pHr1NB+Pvb7y3yIAVSYnkCDGtsT5lrc0mxa 84CEfk13hJZG8wzoh0x7HooAdZcgHivSZDDZGsOIYnTWsuSi49YViR+VkhZHk/dTCrmJ MSh39Pv1RLeIJsg9hIOXAVng83PvEueY/yDuM2zgYVi4stGhXkfW/FbmIiO/DP9HFWT1 kB3JD/RyzuFlpBBzseGDpRVLL4HdOMMVAJlcNv/asE7s3Z40VfNf7j3Zj0byo6tqdOJu XJMWdXJaSIz3reofWLPVcwKtn7p23evnrxafyUUt5Xf9vByLBEGYP1tOyDlvz1dVL+nE nEaQ== X-Gm-Message-State: AOAM532RLeAoUZkfdf8z8GgC+0/6C06hyqZP+TRkj4yUfOc09ZOip+0f RJkWo7HXXCmVCb9+CqQ3+4llV+/vMqDZHHp4qqdWqAqukea3x+Xqf1v/pw5XDC64I1Vm5X6xcfE YVcqpaeU8Qey7J09ps/sTyaT//TQ8YTVjNbehm+DbyHPbUiZE8w== X-Received: by 2002:a05:6402:148a:: with SMTP id e10mr21482436edv.377.1618058413094; Sat, 10 Apr 2021 05:40:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnEqzqI9N9YfHRefBuhHMer8IAZFUeA1p/w31AAx1VON2hHKiqTW68RFjQfE3PCZ9Bpj9RyA== X-Received: by 2002:a05:6402:148a:: with SMTP id e10mr21482422edv.377.1618058412954; Sat, 10 Apr 2021 05:40:12 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id d6sm3149960edr.21.2021.04.10.05.40.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Apr 2021 05:40:12 -0700 (PDT) Subject: Re: [PATCH v5 04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common To: Yong Wu , Matthias Brugger , Joerg Roedel , Rob Herring Cc: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, Nicolas Boichat , Matthias Kaehlcke , anan.sun@mediatek.com, chao.hao@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, eizan@chromium.org, acourbot@chromium.org References: <20210410091128.31823-1-yong.wu@mediatek.com> <20210410091128.31823-5-yong.wu@mediatek.com> From: Krzysztof Kozlowski Message-ID: Date: Sat, 10 Apr 2021 14:40:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210410091128.31823-5-yong.wu@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210410_054018_231080_84A33E35 X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 10/04/2021 11:11, Yong Wu wrote: > Normally, If the smi-larb HW need work, we should enable the smi-common > HW power and clock firstly. > This patch adds device-link between the smi-larb dev and the smi-common > dev. then If pm_runtime_get_sync(smi-larb-dev), the pm_runtime_get_sync > (smi-common-dev) will be called automatically. > > Also, Add DL_FLAG_STATELESS to avoid the smi-common clocks be gated when > probe. > > CC: Matthias Brugger > Suggested-by: Tomasz Figa > Signed-off-by: Yong Wu > --- > drivers/memory/mtk-smi.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) I understood this is a dependency for other patches, so: Acked-by: Krzysztof Kozlowski If I am wrong and I can take it via memory tree, let me know. Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3161DC433B4 for ; Sat, 10 Apr 2021 12:42:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADFE6610CC for ; Sat, 10 Apr 2021 12:42:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADFE6610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DhFBbWkpZKcMKWB+AD+xXTJlAZ9klIH9bqVNaZX26WI=; b=jepHVzAvrTFvw0l/i/1k7b2jj eSDcEgXWFVylncKk8NJi8R5YJnUYsGAYmGjx6BM3ZN5VfyHsFod5UJT2+8kYrtwl9ZP0CyyFwP1QM x6p0TwRC5sjohmIhlgafMRY9iqB7FOocgU2jlO/bK43sKGVto7cA/Hv0nqwwn2gP/ghRiQDutOCNQ fJBQAnkLOv0peL30h6J+nYF37yfXjy6lnzuT+zjWW6ZJGv5qPfT3OHn/WL6qTdWzAA07yPEGtLs6O o+fpjzanUdky7RdD67FYmhKT3GQw63f95jnG40Sq5Dd0CJ2o+i6QC2aw5I4qm4ywNi2rIUotpqd0Y ar1fdDk1w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVCuV-002pEz-TE; Sat, 10 Apr 2021 12:40:24 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVCuS-002pEZ-Q1 for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 12:40:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=k8kbv7tLUPin7vEZz6Y8S8Ho2i9EHLVgMoQhgUpPZTc=; b=sH7AU7kTTfj1TUN270Sr97+awl fDLCdVPXFw8XfOUdrfNXt8Rz59P+W2j2PcHTeYW8CvNuVr5aFpC7FbwZMCixVioLlBFth9TXf5IPx JOHwOpe9vwMoYrcCiW0GsGRWIZemzpxIzRzqsfV/fZgZ1I299L6iAyr9+to5EInKAXGbkEZT7T1M3 7ajQIEoAZG7xhmcZ64GYqPIKu/GIyP3yNZ+LoMLo4YdhQx74yE8mvgxcYl7jl8Q9wDbuOW/eqsblQ QgWJZe0ZX4HZmS52UYrAgIbpmXEGcA8/lI8f33p3tgU9llAXXu6LlZKCX4BDBErtb7HV2nt3wdYS7 DyPH9xIg==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVCuQ-0055uI-1H for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 12:40:19 +0000 Received: from mail-ed1-f70.google.com ([209.85.208.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lVCuL-0002Yi-Gq for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 12:40:13 +0000 Received: by mail-ed1-f70.google.com with SMTP id dj13so579542edb.14 for ; Sat, 10 Apr 2021 05:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k8kbv7tLUPin7vEZz6Y8S8Ho2i9EHLVgMoQhgUpPZTc=; b=Sut1hXLGaKWBop1vZw9CE9VCbZMqz6XHXkGGADUykz6OitusVYZK+wevWUpsvLabvG 1ijQflFwoYIxOLjyyGpI1Q+/rfUAVzTedyBLTZ8GbS5SaYczHC2qkNw8ZBkdJVFRQ8EW NdTiG9f4jRHsvFwiQEhtfR5vepfK7SENpeJXHYp27ZIYSQRilWoXqHudk9ev/MlHLtqq fG25OyeIu1vVbb0CdokQipe8Mr9Fd3Qn35in5lcHatSe6+lrOzReLYM/P4ebKmqeVLVt v3xVTSCutrLO7SVOcVPkdPE1wIWYmo5j8jOqAXU8OtPcUAY1WM14nDYHUG3P6vDEtFaK L71Q== X-Gm-Message-State: AOAM533PKiLtIEi+obP3BS3acySFI2nYFUwpjhnjpnGEXdkZCT8/AQh8 7g++ajecHifYoIjCL+QlWn+9ygQq0GMOax7E6vR4c6SYAuDYFt1bgirSWDMXH5Y3uOSYE3eL+UB yNqgjczzIpIJ8aDjjaBC4i+cgDG1iIR6ffm9r+1NBeKzQ8OnGt+4K X-Received: by 2002:a05:6402:148a:: with SMTP id e10mr21482454edv.377.1618058413154; Sat, 10 Apr 2021 05:40:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnEqzqI9N9YfHRefBuhHMer8IAZFUeA1p/w31AAx1VON2hHKiqTW68RFjQfE3PCZ9Bpj9RyA== X-Received: by 2002:a05:6402:148a:: with SMTP id e10mr21482422edv.377.1618058412954; Sat, 10 Apr 2021 05:40:12 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id d6sm3149960edr.21.2021.04.10.05.40.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Apr 2021 05:40:12 -0700 (PDT) Subject: Re: [PATCH v5 04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common To: Yong Wu , Matthias Brugger , Joerg Roedel , Rob Herring Cc: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, Nicolas Boichat , Matthias Kaehlcke , anan.sun@mediatek.com, chao.hao@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, eizan@chromium.org, acourbot@chromium.org References: <20210410091128.31823-1-yong.wu@mediatek.com> <20210410091128.31823-5-yong.wu@mediatek.com> From: Krzysztof Kozlowski Message-ID: Date: Sat, 10 Apr 2021 14:40:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210410091128.31823-5-yong.wu@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210410_054018_238982_38E42494 X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/04/2021 11:11, Yong Wu wrote: > Normally, If the smi-larb HW need work, we should enable the smi-common > HW power and clock firstly. > This patch adds device-link between the smi-larb dev and the smi-common > dev. then If pm_runtime_get_sync(smi-larb-dev), the pm_runtime_get_sync > (smi-common-dev) will be called automatically. > > Also, Add DL_FLAG_STATELESS to avoid the smi-common clocks be gated when > probe. > > CC: Matthias Brugger > Suggested-by: Tomasz Figa > Signed-off-by: Yong Wu > --- > drivers/memory/mtk-smi.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) I understood this is a dependency for other patches, so: Acked-by: Krzysztof Kozlowski If I am wrong and I can take it via memory tree, let me know. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel