From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756236AbcHBHNY (ORCPT ); Tue, 2 Aug 2016 03:13:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:56947 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755447AbcHBHNR (ORCPT ); Tue, 2 Aug 2016 03:13:17 -0400 Subject: Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look less scary To: Jan Beulich References: <1470120213-16683-1-git-send-email-jgross@suse.com> <57A0636A0200007800101998@suse.com> Cc: david.vrabel@citrix.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org From: Juergen Gross Message-ID: Date: Tue, 2 Aug 2016 09:12:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <57A0636A0200007800101998@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/16 09:10, Jan Beulich wrote: >>>> On 02.08.16 at 08:43, wrote: >> --- a/arch/x86/xen/pmu.c >> +++ b/arch/x86/xen/pmu.c >> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu) >> return; >> >> fail: >> - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n", >> - cpu, err); >> + if (err == -EOPNOTSUPP) >> + pr_info_once("VPMU disabled by hypervisor.\n"); >> + else >> + pr_info_once("Could not initialize VPMU for cpu %d, error %d\n", >> + cpu, err); > > I'm sorry for not already having thought about this for v1, but > what about older hypervisors, where the hypercall would return > -ENOSYS? I wasn't aware of that possibility. It should be covered, of course! V3 will be sent soon... Thanks for noticing now, Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH v2] xen: Make VPMU init message look less scary Date: Tue, 2 Aug 2016 09:12:04 +0200 Message-ID: References: <1470120213-16683-1-git-send-email-jgross@suse.com> <57A0636A0200007800101998@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUTrz-0004h2-9w for xen-devel@lists.xenproject.org; Tue, 02 Aug 2016 07:12:07 +0000 In-Reply-To: <57A0636A0200007800101998@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gMDIvMDgvMTYgMDk6MTAsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDAyLjA4LjE2IGF0 IDA4OjQzLCA8Skdyb3NzQHN1c2UuY29tPiB3cm90ZToKPj4gLS0tIGEvYXJjaC94ODYveGVuL3Bt dS5jCj4+ICsrKyBiL2FyY2gveDg2L3hlbi9wbXUuYwo+PiBAQCAtNTQ3LDggKzU0NywxMSBAQCB2 b2lkIHhlbl9wbXVfaW5pdChpbnQgY3B1KQo+PiAgCXJldHVybjsKPj4gIAo+PiAgZmFpbDoKPj4g LQlwcl9pbmZvX29uY2UoIkNvdWxkIG5vdCBpbml0aWFsaXplIFZQTVUgZm9yIGNwdSAlZCwgZXJy b3IgJWRcbiIsCj4+IC0JCWNwdSwgZXJyKTsKPj4gKwlpZiAoZXJyID09IC1FT1BOT1RTVVBQKQo+ PiArCQlwcl9pbmZvX29uY2UoIlZQTVUgZGlzYWJsZWQgYnkgaHlwZXJ2aXNvci5cbiIpOwo+PiAr CWVsc2UKPj4gKwkJcHJfaW5mb19vbmNlKCJDb3VsZCBub3QgaW5pdGlhbGl6ZSBWUE1VIGZvciBj cHUgJWQsIGVycm9yICVkXG4iLAo+PiArCQkJY3B1LCBlcnIpOwo+IAo+IEknbSBzb3JyeSBmb3Ig bm90IGFscmVhZHkgaGF2aW5nIHRob3VnaHQgYWJvdXQgdGhpcyBmb3IgdjEsIGJ1dAo+IHdoYXQg YWJvdXQgb2xkZXIgaHlwZXJ2aXNvcnMsIHdoZXJlIHRoZSBoeXBlcmNhbGwgd291bGQgcmV0dXJu Cj4gLUVOT1NZUz8KCkkgd2Fzbid0IGF3YXJlIG9mIHRoYXQgcG9zc2liaWxpdHkuIEl0IHNob3Vs ZCBiZSBjb3ZlcmVkLCBvZiBjb3Vyc2UhCgpWMyB3aWxsIGJlIHNlbnQgc29vbi4uLgoKVGhhbmtz IGZvciBub3RpY2luZyBub3csCgoKSnVlcmdlbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=