All of
 help / color / mirror / Atom feed
From: Randy Dunlap <>
To: LKML <>,
	linux-pci <>,
	Bjorn Helgaas <>
Cc: stable <>,
	Jacob Pan <>,
	Len Brown <>, Jesse Barnes <>,
	Arjan van de Ven <>,
	Andy Shevchenko <>,
	Thomas Gleixner <>,
	Adam Borowski <>
Subject: [PATCH v2] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled
Date: Fri, 21 Aug 2020 17:10:27 -0700	[thread overview]
Message-ID: <> (raw)

From: Randy Dunlap <>

Fix build error when CONFIG_ACPI is not set/enabled by adding
the header file <asm/acpi.h> which contains a stub for the function
in the build error.

../arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]

Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()")
Signed-off-by: Randy Dunlap <>
Cc:	# v4.16+
Cc: Jacob Pan <>
Cc: Len Brown <>
To: Bjorn Helgaas <>
Cc: Jesse Barnes <>
Cc: Arjan van de Ven <>
Reviewed-by: Andy Shevchenko <>
Reviewed-by: Jesse Barnes <>
Acked-by: Thomas Gleixner <>
Found in linux-next, but applies to/exists in mainline also.

- add Reviewed-by: and Acked-by: tags
- drop alternatives

 arch/x86/pci/intel_mid_pci.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20200813.orig/arch/x86/pci/intel_mid_pci.c
+++ linux-next-20200813/arch/x86/pci/intel_mid_pci.c
@@ -33,6 +33,7 @@
 #include <asm/hw_irq.h>
 #include <asm/io_apic.h>
 #include <asm/intel-mid.h>
+#include <asm/acpi.h>
 #define PCIE_CAP_OFFSET	0x100

             reply	other threads:[~2020-08-22  0:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-22  0:10 Randy Dunlap [this message]
2020-08-27 19:05 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.