All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: "Hu, Jiayu" <jiayu.hu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] gso: fix VxLAN/GRE tunnel checks
Date: Sun, 20 Jan 2019 12:58:50 +0300	[thread overview]
Message-ID: <ea99e6e7-3546-58fa-5a50-cdb4da55766d@solarflare.com> (raw)
In-Reply-To: <ED946F0BEFE0A141B63BABBD629A2A9B3CF47556@shsmsx102.ccr.corp.intel.com>

On 1/19/19 4:31 PM, Hu, Jiayu wrote:
> Hi Andrew,
>
> Would you please give more explanation about the problem that
> the patch wants to fix?

Let's consider if tunnel is IPIP (0x3ULL << 45) or MPLSINUDP (0x5ULL << 45).
If so flags & VXLAN (0x1ULL << 45), still makes (0x1ULL << 45)==VXLAN,
but it is not a VXLAN tunnel packet.

Andrew.

>
> Thanks,
> Jiayu
>> -----Original Message-----
>> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
>> Sent: Friday, January 18, 2019 9:29 PM
>> To: Hu, Jiayu <jiayu.hu@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: [PATCH] gso: fix VxLAN/GRE tunnel checks
>>
>> Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
>>
>> Fixes: b058d92ea95d ("gso: support VxLAN GSO")
>> Fixes: 70e737e448c7 ("gso: support GRE GSO")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>>   lib/librte_gso/gso_common.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/librte_gso/gso_common.h b/lib/librte_gso/gso_common.h
>> index 6cd764ff5..b6ff1b886 100644
>> --- a/lib/librte_gso/gso_common.h
>> +++ b/lib/librte_gso/gso_common.h
>> @@ -22,12 +22,12 @@
>>   		(PKT_TX_TCP_SEG | PKT_TX_IPV4))
>>
>>   #define IS_IPV4_VXLAN_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
>> PKT_TX_IPV4 | \
>> -				PKT_TX_OUTER_IPV4 |
>> PKT_TX_TUNNEL_VXLAN)) == \
>> +				PKT_TX_OUTER_IPV4 |
>> PKT_TX_TUNNEL_MASK)) == \
>>   		(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
>> \
>>   		 PKT_TX_TUNNEL_VXLAN))
>>
>>   #define IS_IPV4_GRE_TCP4(flag) (((flag) & (PKT_TX_TCP_SEG |
>> PKT_TX_IPV4 | \
>> -				PKT_TX_OUTER_IPV4 |
>> PKT_TX_TUNNEL_GRE)) == \
>> +				PKT_TX_OUTER_IPV4 |
>> PKT_TX_TUNNEL_MASK)) == \
>>   		(PKT_TX_TCP_SEG | PKT_TX_IPV4 | PKT_TX_OUTER_IPV4 |
>> \
>>   		 PKT_TX_TUNNEL_GRE))
>>
>> --
>> 2.17.1

  reply	other threads:[~2019-01-20  9:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 13:28 [PATCH] gso: fix VxLAN/GRE tunnel checks Andrew Rybchenko
2019-01-19 13:31 ` Hu, Jiayu
2019-01-20  9:58   ` Andrew Rybchenko [this message]
2019-01-20 13:27     ` Hu, Jiayu
2019-01-21  6:27 ` [PATCH v2] " Andrew Rybchenko
2019-01-21  6:40   ` Hu, Jiayu
2019-01-21  6:42 ` [PATCH v3] " Andrew Rybchenko
2019-01-21  6:45   ` Hu, Jiayu
2019-01-22 16:09     ` [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea99e6e7-3546-58fa-5a50-cdb4da55766d@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.