From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932247AbeCKODS (ORCPT ); Sun, 11 Mar 2018 10:03:18 -0400 Received: from esa7.dell-outbound.iphmx.com ([68.232.153.96]:57025 "EHLO esa7.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932136AbeCKODP (ORCPT ); Sun, 11 Mar 2018 10:03:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GRAQABNqVah8mZ6ERdGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYMjgQN/KAqDRpgOggSBFpQyghUKhSUCGoJ3ITUXAQIBAQEBAQE?= =?us-ascii?q?CAQIQAQEBCgsJCCgugjgigkoBAQEDASMRRQwEAgEIEQQBAQECAh8EAwICAkQBC?= =?us-ascii?q?AgCBA4FCBOEdQipW4ImiFmCGoENhCiCLoM8gy6FBQYdEAYbAoJOgmIEiBGSRQm?= =?us-ascii?q?QWY5rkUiBLB8BgglwgxKCMhAMFm0BCWx3AYpQgRgBAQE?= X-IPAS-Result: =?us-ascii?q?A2GRAQABNqVah8mZ6ERdGQEBAQEBAQEBAQEBAQcBAQEBAYM?= =?us-ascii?q?jgQN/KAqDRpgOggSBFpQyghUKhSUCGoJ3ITUXAQIBAQEBAQECAQIQAQEBCgsJC?= =?us-ascii?q?CgugjgigkoBAQEDASMRRQwEAgEIEQQBAQECAh8EAwICAkQBCAgCBA4FCBOEdQi?= =?us-ascii?q?pW4ImiFmCGoENhCiCLoM8gy6FBQYdEAYbAoJOgmIEiBGSRQmQWY5rkUiBLB8Bg?= =?us-ascii?q?glwgxKCMhAMFm0BCWx3AYpQgRgBAQE?= From: X-LoopCount0: from 10.166.132.152 X-IronPort-AV: E=Sophos;i="5.47,455,1515477600"; d="scan'208";a="148502568" X-DLP: DLP_GlobalPCIDSS To: CC: , , , , , , , Subject: RE: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics Thread-Topic: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics Thread-Index: AQHTtr1XC+3UjKIddE2I55hGuXPKiaPIAceAgAAHyYD//5ufkIAAaMcA//+dHPCAAgPLgIABZOtw Date: Sun, 11 Mar 2018 14:03:13 +0000 Message-ID: References: <20180308091023.9061-1-kai.heng.feng@canonical.com> <20180308091023.9061-3-kai.heng.feng@canonical.com> <20180309090223.xb55ltac4pfesdrh@pali> <723DA929-C9FA-4F69-8D3A-03D8A75D09A6@canonical.com> <014795f5a3014cd3bf55de26f76a5af8@ausx13mpc124.AMER.DELL.COM> <20180309094600.m24d3zbzdsmls7aw@pali> <09eadabb264f401a88b427744505adf8@ausx13mpc124.AMER.DELL.COM> <20180310103809.5nnwoulua2u64rku@pali> In-Reply-To: <20180310103809.5nnwoulua2u64rku@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w2BE3Oik031485 > -----Original Message----- > From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86- > owner@vger.kernel.org] On Behalf Of Pali Rohár > Sent: Saturday, March 10, 2018 6:38 PM > To: Limonciello, Mario > Cc: kai.heng.feng@canonical.com; mjg59@srcf.ucam.org; dvhart@infradead.org; > andy@infradead.org; tiwai@suse.com; platform-driver-x86@vger.kernel.org; linux- > kernel@vger.kernel.org; alsa-devel@alsa-project.org > Subject: Re: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell > platforms with Switchable Graphics > > On Friday 09 March 2018 09:59:39 Mario.Limonciello@dell.com wrote: > > > > Pali is your concern that this code for matching vendor/subsystem is running > > > > on non-Dell too? The only other recommendation I think that can be to restrict > > > > to matching Dell OEM strings in SMBIOS table, but I don't think that's any better > > > > than the matching for VID/SSVID. > > > > > > My concern is about adding a new machine specific code into generic > > > driver, which check is done just by PCI vendor and subvendor. > > > > > > In future there can be new models or other PCI devices which matches > > > above condition even they would not have any switchable graphics, nor > > > they would manufactured by Dell. > > > > Uh Dell subsystem ID means it's Dell no? > > What would prevent you to take PCI device marked with Dell ID and put it > into non-Dell computer? I do not believe that Dell PCI devices are > configured to work only in Dell branded devices and refuse to power up > in others. I think the missing aspect is that this is only used in AIO and laptop form factors where the discrete graphics is in a non-removable form factor. Running with your hypothetical though, what would happen is if it's on a non-Dell machine the PCI check would pass and then the code would not be executed by dell-laptop (since dell-smbios didn't load). If it was on a Dell machine it would load but the BIOS would return either Switchable graphics turned off, or invalid token. Even though these aren't real for switchable graphics on Dell I don't see a problem with either of these situations if it ever came up. > > If there is Dell ID then it just means that PCI device itself is Dell's. > And not that machine in which that device is plugged is also Dell. > > > > Also I can imagine that in future (or maybe already now?) it is possible > > > to find PCI device which pass above checks and connect this PCI device > > > into desktop /server / any non-laptop device. > > > > > > If this switchable graphics solution is specific to dell laptops, then > > > rather checking for PCI vendor/subvevendor main check, there should be > > > main check via DMI strings. > > > > Right now this is affected to both AIO desktop and laptops. > > > > IIRC you won't end up with switchable graphics in traditional desktop that you > > can remove PCI card. If this code was run on a traditional desktop with a > > AMD PCI card that BIOS query result should be invalid token (which will infer > > switchable off to this routine). > > > > > > > > Hardware is changing relatively quickly and there is absolutely no > > > guarantee that e.g. NVIDIA would not start providing audio controller in > > > similar like AMD and it would be put in those Dell machines. > > > > Kai Heng can explain exactly why NVIDIA isn't affected. > > This is probably good information to include in the commit message too. > > Yes, extending commit message is a good idea. > > But here I'm talking about future, NVIDIA cards could be in future. > > I still think that whitelisting devices based on vendor ID by some > measurements at one time is a bad idea. It is fragile which can stop > working in the future. Compiling a whitelist is a wasted effort because it will have to change Every year for every new platform that has AMD switchable graphics. This heuristic that is selected covers switchable graphics back for the past generations that Canonical has tested and fixed, not just this current one. If that situation you refer to happens, it will be on new hardware that's not yet enabled by the Linux kernel. We can cross that bridge when we come to it with either a newly proposed heuristic or some adjustments for whitelist/blacklist. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: Re: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics Date: Sun, 11 Mar 2018 14:03:13 +0000 Message-ID: References: <20180308091023.9061-1-kai.heng.feng@canonical.com> <20180308091023.9061-3-kai.heng.feng@canonical.com> <20180309090223.xb55ltac4pfesdrh@pali> <723DA929-C9FA-4F69-8D3A-03D8A75D09A6@canonical.com> <014795f5a3014cd3bf55de26f76a5af8@ausx13mpc124.AMER.DELL.COM> <20180309094600.m24d3zbzdsmls7aw@pali> <09eadabb264f401a88b427744505adf8@ausx13mpc124.AMER.DELL.COM> <20180310103809.5nnwoulua2u64rku@pali> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180310103809.5nnwoulua2u64rku@pali> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: pali.rohar@gmail.com Cc: mjg59@srcf.ucam.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, platform-driver-x86@vger.kernel.org, kai.heng.feng@canonical.com, dvhart@infradead.org, andy@infradead.org List-Id: platform-driver-x86.vger.kernel.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBwbGF0Zm9ybS1kcml2ZXIteDg2 LW93bmVyQHZnZXIua2VybmVsLm9yZyBbbWFpbHRvOnBsYXRmb3JtLWRyaXZlci14ODYtDQo+IG93 bmVyQHZnZXIua2VybmVsLm9yZ10gT24gQmVoYWxmIE9mIFBhbGkgUm9ow6FyDQo+IFNlbnQ6IFNh dHVyZGF5LCBNYXJjaCAxMCwgMjAxOCA2OjM4IFBNDQo+IFRvOiBMaW1vbmNpZWxsbywgTWFyaW8g PE1hcmlvX0xpbW9uY2llbGxvQERlbGwuY29tPg0KPiBDYzoga2FpLmhlbmcuZmVuZ0BjYW5vbmlj YWwuY29tOyBtamc1OUBzcmNmLnVjYW0ub3JnOyBkdmhhcnRAaW5mcmFkZWFkLm9yZzsNCj4gYW5k eUBpbmZyYWRlYWQub3JnOyB0aXdhaUBzdXNlLmNvbTsgcGxhdGZvcm0tZHJpdmVyLXg4NkB2Z2Vy Lmtlcm5lbC5vcmc7IGxpbnV4LQ0KPiBrZXJuZWxAdmdlci5rZXJuZWwub3JnOyBhbHNhLWRldmVs QGFsc2EtcHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAzLzNdIEFMU0E6IGhk YTogRGlzYWJsZWQgdW51c2VkIGF1ZGlvIGNvbnRyb2xsZXIgZm9yIERlbGwNCj4gcGxhdGZvcm1z IHdpdGggU3dpdGNoYWJsZSBHcmFwaGljcw0KPiANCj4gT24gRnJpZGF5IDA5IE1hcmNoIDIwMTgg MDk6NTk6MzkgTWFyaW8uTGltb25jaWVsbG9AZGVsbC5jb20gd3JvdGU6DQo+ID4gPiA+IFBhbGkg aXMgeW91ciBjb25jZXJuIHRoYXQgdGhpcyBjb2RlIGZvciBtYXRjaGluZyB2ZW5kb3Ivc3Vic3lz dGVtIGlzIHJ1bm5pbmcNCj4gPiA+ID4gb24gbm9uLURlbGwgdG9vPyAgVGhlIG9ubHkgb3RoZXIg cmVjb21tZW5kYXRpb24gSSB0aGluayB0aGF0IGNhbiBiZSB0byByZXN0cmljdA0KPiA+ID4gPiB0 byBtYXRjaGluZyBEZWxsIE9FTSBzdHJpbmdzIGluIFNNQklPUyB0YWJsZSwgYnV0IEkgZG9uJ3Qg dGhpbmsgdGhhdCdzIGFueSBiZXR0ZXINCj4gPiA+ID4gdGhhbiB0aGUgbWF0Y2hpbmcgZm9yIFZJ RC9TU1ZJRC4NCj4gPiA+DQo+ID4gPiBNeSBjb25jZXJuIGlzIGFib3V0IGFkZGluZyBhIG5ldyBt YWNoaW5lIHNwZWNpZmljIGNvZGUgaW50byBnZW5lcmljDQo+ID4gPiBkcml2ZXIsIHdoaWNoIGNo ZWNrIGlzIGRvbmUganVzdCBieSBQQ0kgdmVuZG9yIGFuZCBzdWJ2ZW5kb3IuDQo+ID4gPg0KPiA+ ID4gSW4gZnV0dXJlIHRoZXJlIGNhbiBiZSBuZXcgbW9kZWxzIG9yIG90aGVyIFBDSSBkZXZpY2Vz IHdoaWNoIG1hdGNoZXMNCj4gPiA+IGFib3ZlIGNvbmRpdGlvbiBldmVuIHRoZXkgd291bGQgbm90 IGhhdmUgYW55IHN3aXRjaGFibGUgZ3JhcGhpY3MsIG5vcg0KPiA+ID4gdGhleSB3b3VsZCBtYW51 ZmFjdHVyZWQgYnkgRGVsbC4NCj4gPg0KPiA+IFVoIERlbGwgc3Vic3lzdGVtIElEIG1lYW5zIGl0 J3MgRGVsbCBubz8NCj4gDQo+IFdoYXQgd291bGQgcHJldmVudCB5b3UgdG8gdGFrZSBQQ0kgZGV2 aWNlIG1hcmtlZCB3aXRoIERlbGwgSUQgYW5kIHB1dCBpdA0KPiBpbnRvIG5vbi1EZWxsIGNvbXB1 dGVyPyBJIGRvIG5vdCBiZWxpZXZlIHRoYXQgRGVsbCBQQ0kgZGV2aWNlcyBhcmUNCj4gY29uZmln dXJlZCB0byB3b3JrIG9ubHkgaW4gRGVsbCBicmFuZGVkIGRldmljZXMgYW5kIHJlZnVzZSB0byBw b3dlciB1cA0KPiBpbiBvdGhlcnMuDQoNCkkgdGhpbmsgdGhlIG1pc3NpbmcgYXNwZWN0IGlzIHRo YXQgdGhpcyBpcyBvbmx5IHVzZWQgaW4gQUlPIGFuZCBsYXB0b3AgZm9ybQ0KZmFjdG9ycyB3aGVy ZSB0aGUgZGlzY3JldGUgZ3JhcGhpY3MgaXMgaW4gYSBub24tcmVtb3ZhYmxlIGZvcm0gZmFjdG9y Lg0KDQpSdW5uaW5nIHdpdGggeW91ciBoeXBvdGhldGljYWwgdGhvdWdoLCB3aGF0IHdvdWxkIGhh cHBlbiBpcyBpZiBpdCdzDQpvbiBhIG5vbi1EZWxsIG1hY2hpbmUgdGhlIFBDSSBjaGVjayB3b3Vs ZCBwYXNzIGFuZCB0aGVuIHRoZSBjb2RlDQp3b3VsZCBub3QgYmUgZXhlY3V0ZWQgYnkgZGVsbC1s YXB0b3AgKHNpbmNlIGRlbGwtc21iaW9zIGRpZG4ndCBsb2FkKS4NCg0KSWYgaXQgd2FzIG9uIGEg RGVsbCBtYWNoaW5lIGl0IHdvdWxkIGxvYWQgYnV0IHRoZSBCSU9TIHdvdWxkIHJldHVybg0KZWl0 aGVyIFN3aXRjaGFibGUgZ3JhcGhpY3MgdHVybmVkIG9mZiwgb3IgaW52YWxpZCB0b2tlbi4NCg0K RXZlbiB0aG91Z2ggdGhlc2UgYXJlbid0IHJlYWwgZm9yIHN3aXRjaGFibGUgZ3JhcGhpY3Mgb24g RGVsbCBJIGRvbid0DQpzZWUgYSBwcm9ibGVtIHdpdGggZWl0aGVyIG9mIHRoZXNlIHNpdHVhdGlv bnMgaWYgaXQgZXZlciBjYW1lIHVwLg0KIA0KPiANCj4gSWYgdGhlcmUgaXMgRGVsbCBJRCB0aGVu IGl0IGp1c3QgbWVhbnMgdGhhdCBQQ0kgZGV2aWNlIGl0c2VsZiBpcyBEZWxsJ3MuDQo+IEFuZCBu b3QgdGhhdCBtYWNoaW5lIGluIHdoaWNoIHRoYXQgZGV2aWNlIGlzIHBsdWdnZWQgaXMgYWxzbyBE ZWxsLg0KPiANCj4gPiA+IEFsc28gSSBjYW4gaW1hZ2luZSB0aGF0IGluIGZ1dHVyZSAob3IgbWF5 YmUgYWxyZWFkeSBub3c/KSBpdCBpcyBwb3NzaWJsZQ0KPiA+ID4gdG8gZmluZCBQQ0kgZGV2aWNl IHdoaWNoIHBhc3MgYWJvdmUgY2hlY2tzIGFuZCBjb25uZWN0IHRoaXMgUENJIGRldmljZQ0KPiA+ ID4gaW50byBkZXNrdG9wIC9zZXJ2ZXIgLyBhbnkgbm9uLWxhcHRvcCBkZXZpY2UuDQo+ID4gPg0K PiA+ID4gSWYgdGhpcyBzd2l0Y2hhYmxlIGdyYXBoaWNzIHNvbHV0aW9uIGlzIHNwZWNpZmljIHRv IGRlbGwgbGFwdG9wcywgdGhlbg0KPiA+ID4gcmF0aGVyIGNoZWNraW5nIGZvciBQQ0kgdmVuZG9y L3N1YnZldmVuZG9yIG1haW4gY2hlY2ssIHRoZXJlIHNob3VsZCBiZQ0KPiA+ID4gbWFpbiBjaGVj ayB2aWEgRE1JIHN0cmluZ3MuDQo+ID4NCj4gPiBSaWdodCBub3cgdGhpcyBpcyBhZmZlY3RlZCB0 byBib3RoIEFJTyBkZXNrdG9wIGFuZCBsYXB0b3BzLg0KPiA+DQo+ID4gSUlSQyB5b3Ugd29uJ3Qg ZW5kIHVwIHdpdGggc3dpdGNoYWJsZSBncmFwaGljcyBpbiB0cmFkaXRpb25hbCBkZXNrdG9wIHRo YXQgeW91DQo+ID4gY2FuIHJlbW92ZSBQQ0kgY2FyZC4gIElmIHRoaXMgY29kZSB3YXMgcnVuIG9u IGEgdHJhZGl0aW9uYWwgZGVza3RvcCB3aXRoIGENCj4gPiBBTUQgUENJIGNhcmQgdGhhdCBCSU9T IHF1ZXJ5IHJlc3VsdCBzaG91bGQgYmUgaW52YWxpZCB0b2tlbiAod2hpY2ggd2lsbCBpbmZlcg0K PiA+IHN3aXRjaGFibGUgb2ZmIHRvIHRoaXMgcm91dGluZSkuDQo+ID4NCj4gPiA+DQo+ID4gPiBI YXJkd2FyZSBpcyBjaGFuZ2luZyByZWxhdGl2ZWx5IHF1aWNrbHkgYW5kIHRoZXJlIGlzIGFic29s dXRlbHkgbm8NCj4gPiA+IGd1YXJhbnRlZSB0aGF0IGUuZy4gTlZJRElBIHdvdWxkIG5vdCBzdGFy dCBwcm92aWRpbmcgYXVkaW8gY29udHJvbGxlciBpbg0KPiA+ID4gc2ltaWxhciBsaWtlIEFNRCBh bmQgaXQgd291bGQgYmUgcHV0IGluIHRob3NlIERlbGwgbWFjaGluZXMuDQo+ID4NCj4gPiBLYWkg SGVuZyBjYW4gZXhwbGFpbiBleGFjdGx5IHdoeSBOVklESUEgaXNuJ3QgYWZmZWN0ZWQuDQo+ID4g VGhpcyBpcyBwcm9iYWJseSBnb29kIGluZm9ybWF0aW9uIHRvIGluY2x1ZGUgaW4gdGhlIGNvbW1p dCBtZXNzYWdlIHRvby4NCj4gDQo+IFllcywgZXh0ZW5kaW5nIGNvbW1pdCBtZXNzYWdlIGlzIGEg Z29vZCBpZGVhLg0KPiANCj4gQnV0IGhlcmUgSSdtIHRhbGtpbmcgYWJvdXQgZnV0dXJlLCBOVklE SUEgY2FyZHMgY291bGQgYmUgaW4gZnV0dXJlLg0KPiANCj4gSSBzdGlsbCB0aGluayB0aGF0IHdo aXRlbGlzdGluZyBkZXZpY2VzIGJhc2VkIG9uIHZlbmRvciBJRCBieSBzb21lDQo+IG1lYXN1cmVt ZW50cyBhdCBvbmUgdGltZSBpcyBhIGJhZCBpZGVhLiBJdCBpcyBmcmFnaWxlIHdoaWNoIGNhbiBz dG9wDQo+IHdvcmtpbmcgaW4gdGhlIGZ1dHVyZS4NCg0KQ29tcGlsaW5nIGEgd2hpdGVsaXN0IGlz IGEgd2FzdGVkIGVmZm9ydCBiZWNhdXNlIGl0IHdpbGwgaGF2ZSB0byBjaGFuZ2UNCkV2ZXJ5IHll YXIgZm9yIGV2ZXJ5IG5ldyBwbGF0Zm9ybSB0aGF0IGhhcyBBTUQgc3dpdGNoYWJsZSBncmFwaGlj cy4NCg0KVGhpcyBoZXVyaXN0aWMgdGhhdCBpcyBzZWxlY3RlZCBjb3ZlcnMgc3dpdGNoYWJsZSBn cmFwaGljcyBiYWNrIGZvciB0aGUNCnBhc3QgZ2VuZXJhdGlvbnMgdGhhdCBDYW5vbmljYWwgaGFz IHRlc3RlZCBhbmQgZml4ZWQsIG5vdCBqdXN0IHRoaXMNCmN1cnJlbnQgb25lLg0KDQpJZiB0aGF0 IHNpdHVhdGlvbiB5b3UgcmVmZXIgdG8gaGFwcGVucywgaXQgd2lsbCBiZSBvbiBuZXcgaGFyZHdh cmUgdGhhdCdzDQpub3QgeWV0IGVuYWJsZWQgYnkgdGhlIExpbnV4IGtlcm5lbC4gIFdlIGNhbiBj cm9zcyB0aGF0IGJyaWRnZSB3aGVuIHdlDQpjb21lIHRvIGl0IHdpdGggZWl0aGVyIGEgbmV3bHkg cHJvcG9zZWQgaGV1cmlzdGljIG9yIHNvbWUgYWRqdXN0bWVudHMNCmZvciB3aGl0ZWxpc3QvYmxh Y2tsaXN0Lg0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0 cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK