All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Laszlo Ersek <lersek@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, somlo@cmu.edu,
	qemu-devel@nongnu.org, rjones@redhat.com, pbonzini@redhat.com,
	imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()
Date: Wed, 21 Jun 2017 07:58:43 +0100	[thread overview]
Message-ID: <eaa2cd40-0d64-6843-7e39-c0f94c7e797f@ilande.co.uk> (raw)
In-Reply-To: <9d24bf00-cf82-717a-eccd-f51e2c80dd6f@redhat.com>

On 19/06/17 23:43, Laszlo Ersek wrote:

> It looks good to me, but please await Eduardo's reply as well.
> 
> In particular, it should be confirmed that object_resolve_path_type()
> matches instances of *subclasses* as well (as I expect it would). Your
> test results confirm that; let's make sure it is intentional behavior.
> Eduardo (or someone else on the CC list), can you please comment on that?

Thanks Laszlo. Eduardo, can you confirm this is the correct behaviour?

I now have a v7 patchset ready to go (currently hosted at
https://github.com/mcayland/qemu/tree/fwcfg7 for the curious). Laszlo,
I've currently left off your Tested-by tag since I'm not sure it's still
valid for less-than-trivial changes - if you're happy for me to re-add
it before I send the v7 patchset to the list, please let me know.


ATB,

Mark.

  reply	other threads:[~2017-06-21  6:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 12:59 [Qemu-devel] [PATCHv6 0/5] fw_cfg: qdev-related tidy-ups Mark Cave-Ayland
2017-06-19 12:59 ` [Qemu-devel] [PATCHv6 1/5] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize() Mark Cave-Ayland
2017-06-19 14:10   ` Eduardo Habkost
2017-06-19 12:59 ` [Qemu-devel] [PATCHv6 2/5] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1() Mark Cave-Ayland
2017-06-19 14:11   ` Eduardo Habkost
2017-06-20  3:18   ` Philippe Mathieu-Daudé
2017-06-19 12:59 ` [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init() Mark Cave-Ayland
2017-06-19 14:28   ` Eduardo Habkost
2017-06-19 14:56     ` Laszlo Ersek
2017-06-19 16:57     ` Mark Cave-Ayland
2017-06-19 17:09       ` Laszlo Ersek
2017-06-19 18:49         ` Mark Cave-Ayland
2017-06-19 22:43           ` Laszlo Ersek
2017-06-21  6:58             ` Mark Cave-Ayland [this message]
2017-06-21  7:48               ` Laszlo Ersek
2017-06-21 11:36                 ` Eduardo Habkost
2017-06-21 12:17                   ` Mark Cave-Ayland
2017-06-21 13:23                     ` Eduardo Habkost
2017-06-23  8:12                       ` Mark Cave-Ayland
2017-06-23 11:50                         ` Eduardo Habkost
2017-06-23 15:52                           ` Laszlo Ersek
2017-06-23 16:10                             ` Eduardo Habkost
2017-06-23 16:48                               ` Laszlo Ersek
2017-06-23 18:50                                 ` Eduardo Habkost
2017-06-25 18:58                                   ` Mark Cave-Ayland
2017-06-27  0:49                                     ` Eduardo Habkost
2017-06-28  7:09                                       ` Mark Cave-Ayland
2017-06-28 14:12                                         ` Igor Mammedov
2017-06-28 14:21                                           ` Laszlo Ersek
2017-06-28 15:31                                             ` Igor Mammedov
2017-06-29 12:12                                           ` Mark Cave-Ayland
2017-06-19 12:59 ` [Qemu-devel] [PATCHv6 4/5] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers Mark Cave-Ayland
2017-06-19 12:59 ` [Qemu-devel] [PATCHv6 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaa2cd40-0d64-6843-7e39-c0f94c7e797f@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=somlo@cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.