From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E112C4346E for ; Thu, 24 Sep 2020 06:58:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A63C420758 for ; Thu, 24 Sep 2020 06:58:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rp606QH1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="lO71Dyg4"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ceNeyj9t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A63C420758 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:To:From:Date:References:In-Reply-To: Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nfOeua0EtT7VI1kaUSULp9jKQcIDxXrTOalS6bwnRWc=; b=rp606QH1PyIQ4zaTlxobN+WfU RQ0VKYIUincSLnwGeLVqTJZqv4SrJ1C/KkomgYv9qZlnaNpbshP7mWtrvakCuOjh1gLnAb9BKgJMu 35RQ6U2Jyvhw9dOJ0+tXjCHFfLI2BVeN3d82d7DSkhZABvhpYbhBodXZNOdRk9N63iUOBAjfLlvtn z8vp49lfFqJYaWR5QwldhnMR8AivQciRvJnggd+xUUxlJdijeCA0LA9yWG+HG8sP8AAs5UUH0a0fq MLBVhQA7qwy0CKNQm1B+S81+3adcjMOD5XoSgoDTZ2R8Mb922qyEykSKn9VyPQdvKpl1WYYqSVkAz mXt9uhwEg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLLBj-0007Lg-MX; Thu, 24 Sep 2020 06:57:07 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLLBb-0007J2-Gb for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2020 06:57:01 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D04645C00D4; Thu, 24 Sep 2020 02:56:58 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Thu, 24 Sep 2020 02:56:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=QRuWYPevCj4nozR25VUG34/Q1P8+l7X Prm/DpLYeIdw=; b=lO71Dyg45QsJFp/W6eGvhaazUxLlsRXYBmRh+Q6TWfE7OUc KCxRowKjYrh/bgDu3YIyp+F6BLYfiQcZgT3O2ML3YaXDhtoQjLWigqDAcHhZBed7 fhK1XYTXRT6/7b0eI9OvP4dSRLZIvWYOHSE+3LJVy1cX/nGALfGNYkvC+akxwW5m 1l8rJpZEtROI84lVCp7rck98xnN/OXrsK5qTeSk8GBKQCQmgF/FDcTuKYixvCJ6a MeHLl+h/sjj7I5XNitz2+a2XUTY7V+PThMi+2QuN1pgv9UXNTAVRFtXGeVHEgsBF bD/wPBr3z4Rfwbl216oi1m3XBSl0H0eKWVeB9QA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=QRuWYP evCj4nozR25VUG34/Q1P8+l7XPrm/DpLYeIdw=; b=ceNeyj9tHgTSbr+9yz0bIG 1XIAa7AW5HTMTiOjOMrdyXiWOJ+eEhw4TP/4awfJJlnZus1ONVqqOPEckfzABhkH T7w44ZJMXSilzBKDGVgkmsYBihFDjPkHc2div7popdMpnJwhafU3aSOS3ljIj49Q WhwC4BxU3Mr0fxXSc3pm4SbrTCSHXCuHRu5JNg4JreIRBA/T7KCMw3ZidH31jDg4 zbF1JihIpc1/gifmuKSi6baP6VNN0odqWdNXpPUVDb9mA1bMd4IUWowGsu0xLDwo JwN4oIBKiZVYx1SXvdyhWk2ImqMpkwMONSqDlFL84RC50sF6S18ymN8UPj6DZQwQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhephefhfeekgfekudevheffheeihedujeefjeevjeefudfgfeeutdeuvdeh hfevueffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id CD9C7E0169; Thu, 24 Sep 2020 02:56:56 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-355-g3ece53b-fm-20200922.004-g3ece53b9 Mime-Version: 1.0 Message-Id: In-Reply-To: <20200921091644.133107-3-joel@jms.id.au> References: <20200921091644.133107-1-joel@jms.id.au> <20200921091644.133107-3-joel@jms.id.au> Date: Thu, 24 Sep 2020 16:26:37 +0930 From: "Andrew Jeffery" To: "Joel Stanley" , "Rob Herring" Subject: Re: [PATCH v3 2/3] soc: aspeed: Add soc info driver X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200924_025659_640310_AC17DAD6 X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 21 Sep 2020, at 18:46, Joel Stanley wrote: > This adds a SOC_BUS info driver for the ASPEED platform. > > The full ID table is preserved in this commit message in case someone > finds a need to change the implemntation in the future. > > { "AST1100-A0", 0x00000200 }, > { "AST1100-A1", 0x00000201 }, > { "AST1100-A2", 0x00000202 }, > { "AST1100-A3", 0x00000202 }, > > { "AST2050-A0", 0x00000200 }, > { "AST2050-A1", 0x00000201 }, > { "AST2050-A2", 0x00000202 }, > { "AST2050-A3", 0x00000202 }, > > { "AST2100-A0", 0x00000300 }, > { "AST2100-A1", 0x00000301 }, > { "AST2100-A2", 0x00000302 }, > { "AST2100-A3", 0x00000302 }, > > { "AST2150-A0", 0x00000202 }, > { "AST2150-A1", 0x00000202 }, > > { "AST2200-A0", 0x00000102 }, > { "AST2200-A1", 0x00000102 }, > > { "AST2300-A0", 0x01000003 }, > { "AST2300-A1", 0x01010303 }, > > { "AST1300-A1", 0x01010003 }, > { "AST1050-A1", 0x01010203 }, > > { "AST2400-A0", 0x02000303 }, > { "AST2400-A1", 0x02010303 }, > { "AST1400-A1", 0x02010103 }, > { "AST1250-A1", 0x02010303 }, > > { "AST2500-A0", 0x04000303 }, > { "AST2510-A0", 0x04000103 }, > { "AST2520-A0", 0x04000203 }, > { "AST2530-A0", 0x04000403 }, > { "AST2500-A1", 0x04010303 }, > { "AST2510-A1", 0x04010103 }, > { "AST2520-A1", 0x04010203 }, > { "AST2530-A1", 0x04010403 }, > { "AST2500-A2", 0x04030303 }, > { "AST2510-A2", 0x04030103 }, > { "AST2520-A2", 0x04030203 }, > { "AST2530-A2", 0x04030403 }, > > { "AST2600-A0", 0x05000303 }, > { "AST2600-A1", 0x05010303 }, > { "AST2600-A2", 0x05020303 }, > { "AST2620-A1", 0x05010203 }, > { "AST2620-A2", 0x05020203 }, > > Signed-off-by: Joel Stanley I didn't rigorously check the list above, but it looks reasonable at a glance. The code looks good to me this time, so: Reviewed-by: Andrew Jeffery _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel