Re: [PATCH] ASoC: Intel: avs: Depend on CONFIG_ACPI - Pierre-Louis Bossart

From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Intel: avs: Depend on CONFIG_ACPI
Date: Tue, 26 Apr 2022 08:33:57 -0500	[thread overview]
Message-ID: <eab567f0-73a4-bf23-76bf-8d576fa942f0@linux.intel.com> (raw)
In-Reply-To: <20220426115454.685787-1-amadeuszx.slawinski@linux.intel.com>

On 4/26/22 06:54, Amadeusz Sławiński wrote:
> Apparently the assumption that driver can build without ACPI was too
> optimistic as avs selects SND_SOC_ACPI which requires working ACPI
> implementation. So depend on ACPI without COMPILE_TEST alternative.
> 
> Fixes: 47a1886a610a ("ASoC: Intel: avs: Enable AVS driver only on x86 platforms")
> Reported-by: kernel test robot <lkp@intel.com>
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
> ---
>  sound/soc/intel/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index be42c4eff165..9fdd6e32951f 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -211,8 +211,8 @@ config SND_SOC_INTEL_KEEMBAY
>  
>  config SND_SOC_INTEL_AVS
>  	tristate "Intel AVS driver"
> -	depends on (X86 && ACPI) || COMPILE_TEST
> -	depends on PCI
> +	depends on X86 || COMPILE_TEST
> +	depends on PCI && ACPI
>  	depends on COMMON_CLK
>  	select SND_SOC_ACPI

select SND_SOC_ACPI if ACPI should work, that's what we do for SOF.

>  	select SND_SOC_TOPOLOGY