All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: phillip.ennen@gmail.com, qemu-devel@nongnu.org
Cc: stefanha@gmail.com, jasowang@redhat.com, phillip@axleos.com
Subject: Re: [PATCH 1/2] build: add configure flag to indicate when the host is Darwin
Date: Fri, 5 Feb 2021 06:56:38 +0100	[thread overview]
Message-ID: <eacb4adb-3139-e8ed-0d1f-d070af226872@redhat.com> (raw)
In-Reply-To: <20210204162544.65439-2-phillip.ennen@gmail.com>

On 04/02/2021 17.25, phillip.ennen@gmail.com wrote:
> From: Phillip Tennen <phillip@axleos.com>
> 
> Although we already have CONFIG_BSD, I added this flag to be sure that we could rely on various macOS-specific subsystems, such as vmnet.framework.
> 
> Signed-off-by: Phillip Tennen <phillip@axleos.com>
> ---
>   configure | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/configure b/configure
> index 87de49e2c2..4afd22bdf5 100755
> --- a/configure
> +++ b/configure
> @@ -5825,6 +5825,10 @@ if [ "$bsd" = "yes" ] ; then
>     echo "CONFIG_BSD=y" >> $config_host_mak
>   fi
>   
> +if [ "$darwin" = "yes" ] ; then
> +  echo "CONFIG_DARWIN=y" >> $config_host_mak
> +fi

  Hi!

We already have these lines in "configure":

if test "$darwin" = "yes" ; then
   echo "CONFIG_DARWIN=y" >> $config_host_mak
fi

... so your patch here looks pretty redundant?

  Thomas



  reply	other threads:[~2021-02-05  5:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 16:25 [PATCH 0/2] net/macos: implement vmnet-based network device phillip.ennen
2021-02-04 16:25 ` [PATCH 1/2] build: add configure flag to indicate when the host is Darwin phillip.ennen
2021-02-05  5:56   ` Thomas Huth [this message]
2021-02-05 13:32     ` Phillip Tennen
2021-02-04 16:25 ` [PATCH 2/2] net: implement vmnet-based netdev phillip.ennen
2021-02-04 19:51   ` Eric Blake
2021-02-05  0:25     ` Phillip Tennen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eacb4adb-3139-e8ed-0d1f-d070af226872@redhat.com \
    --to=thuth@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=phillip.ennen@gmail.com \
    --cc=phillip@axleos.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.