All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhixiong Chi <zhixiong.chi@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] core-image-minimal-initramfs: add libgcc into the initramfs image
Date: Thu, 7 Mar 2019 18:00:21 +0800	[thread overview]
Message-ID: <eadbbfcd-6dd6-929e-1fbc-8aee74b5961b@windriver.com> (raw)
In-Reply-To: <CAJTo0LbsGET5t6AyfgfQ2L=jR01g+uM8Ec0FA5L5nxpchGd49g@mail.gmail.com>

It's not for dependency of the package in the initramfs image,

just for the multithread application while the customer use initramfs image.

Since we use PACKAGE_INSTALL to override the rootfs in the initramfs bb 
file,

so we couldn't use the IMAGE_INSTALL_append to add the package in the 
local.conf.

Did you think if it should be added into the image? :-)

I know the initramfs is just to bootup the system. If the customer want 
to support the

multithread app, they can use the other types of the image.

Thanks.


On 2019年03月07日 17:05, Burton, Ross wrote:
> Wouldn't it be better to add that dependency to the packages which need it?
>
> Ross
>
> On Thu, 7 Mar 2019 at 06:53, Zhixiong Chi <zhixiong.chi@windriver.com> wrote:
>> Add the libgcc package into the initramfs image to avoid multithread
>> function error in the userspace(eg: pthread_cancel).
>>
>> Signed-off-by: Zhixiong Chi <zhixiong.chi@windriver.com>
>> ---
>>   meta/recipes-core/images/core-image-minimal-initramfs.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/images/core-image-minimal-initramfs.bb b/meta/recipes-core/images/core-image-minimal-initramfs.bb
>> index 7df8ab1ebd..3cf2c7b01f 100644
>> --- a/meta/recipes-core/images/core-image-minimal-initramfs.bb
>> +++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb
>> @@ -11,7 +11,7 @@ INITRAMFS_SCRIPTS ?= "\
>>                         initramfs-module-install-efi \
>>                        "
>>
>> -PACKAGE_INSTALL = "${INITRAMFS_SCRIPTS} ${VIRTUAL-RUNTIME_base-utils} udev base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}"
>> +PACKAGE_INSTALL = "${INITRAMFS_SCRIPTS} ${VIRTUAL-RUNTIME_base-utils} udev base-passwd libgcc ${ROOTFS_BOOTSTRAP_INSTALL}"
>>
>>   # Do not pollute the initrd image with rootfs features
>>   IMAGE_FEATURES = ""
>> --
>> 2.17.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
---------------------
Thanks,
Zhixiong Chi
Tel: +86-10-8477-7036



  reply	other threads:[~2019-03-07  9:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07  6:51 [PATCH] core-image-minimal-initramfs: add libgcc into the initramfs image Zhixiong Chi
2019-03-07  9:05 ` Burton, Ross
2019-03-07 10:00   ` Zhixiong Chi [this message]
2019-03-07 12:33     ` Richard Purdie
2019-03-07 12:39       ` Burton, Ross
2019-03-07 14:45         ` Khem Raj
2019-03-07 14:47           ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eadbbfcd-6dd6-929e-1fbc-8aee74b5961b@windriver.com \
    --to=zhixiong.chi@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.