From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Allan Peramaki <aperamak@pp1.inet.fi>,
QEMU Developers <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] hw/audio/gus: Fix registers 32-bit access
Date: Thu, 18 Jun 2020 12:35:15 +0200 [thread overview]
Message-ID: <eae2ce28-693a-b838-37ea-b8a58a581bb8@redhat.com> (raw)
In-Reply-To: <CAFEAcA9sCJ6wKdra+EBFOJfOaZbtOE0DND6S6rh5jgrDqLG57Q@mail.gmail.com>
On 6/18/20 12:23 PM, Peter Maydell wrote:
> On Thu, 18 Jun 2020 at 11:22, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> On 6/17/20 10:23 PM, Peter Maydell wrote:
>>> On Mon, 15 Jun 2020 at 22:23, Allan Peramaki <aperamak@pp1.inet.fi> wrote:
>>>>
>>>> Fix audio on software that accesses DRAM above 64k via register peek/poke
>>>> and some cases when more than 16 voices are used.
>>>>
>>>> Fixes: 135f5ae1974c ("audio: GUSsample is int16_t")
>>>> Signed-off-by: Allan Peramaki <aperamak@pp1.inet.fi>
>>>
>>> This patch is quite difficult to read because it mixes some
>>> whitespace only changes with some actual changes of
>>> behaviour.
>>
>> In such cases the author might add a comment in the commit
>> description "this patch is easier to review with git-diff -w"
>> or other options.
>>
>> Allan, can we get the patch with only the changed lines?
>
> Is it worth the effort of a respin at this point?
>
I'll give it a try to see if it takes me less than 2min.
next prev parent reply other threads:[~2020-06-18 10:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 20:17 [PATCH] hw/audio/gus: Fix registers 32-bit access Allan Peramaki
2020-06-17 19:58 ` Volker Rümelin
2020-06-17 20:23 ` Peter Maydell
2020-06-17 22:25 ` Allan Peramaki
2020-06-17 23:10 ` Allan Peramaki
2020-06-18 4:57 ` Thomas Huth
2020-06-18 9:13 ` Peter Maydell
2020-06-18 10:22 ` Philippe Mathieu-Daudé
2020-06-18 10:23 ` Peter Maydell
2020-06-18 10:35 ` Philippe Mathieu-Daudé [this message]
2020-06-18 4:59 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eae2ce28-693a-b838-37ea-b8a58a581bb8@redhat.com \
--to=philmd@redhat.com \
--cc=aperamak@pp1.inet.fi \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.