From: Markus Theil <markus.theil@tu-ilmenau.de>
To: Venkateswara Naralasetty <vnaralas@codeaurora.org>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: fix retry packets update in station dump
Date: Thu, 11 Jun 2020 12:26:46 +0200 [thread overview]
Message-ID: <eaf47825-bf7a-e3aa-d0dc-42cf4aa5c9f1@tu-ilmenau.de> (raw)
In-Reply-To: <1591856446-26977-1-git-send-email-vnaralas@codeaurora.org>
On 6/11/20 8:20 AM, Venkateswara Naralasetty wrote:
> When tx status enabled, retry count is updated from tx completion status.
> which is not working as expected due to firmware limitation where
> firmware can not provide per MSDU rate statistics from tx completion
> status. Due to this tx retry count is always 0 in station dump.
>
> Fix this issue by updating the retry packet count from per peer
> statistics. This patch will not break on SDIO devices since, this retry
> count is already updating from peer statistics for SDIO devices.
>
> HW used: QCA9984
> FW version: 10.4-3.6-00104
Thanks a lot for this patch! I tested it on the following HW, where it
also works.
HW: QCA9882
FW: 10.2.4-1.0-00047
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Theil <markus.theil@tu-ilmenau.de>
To: Venkateswara Naralasetty <vnaralas@codeaurora.org>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: fix retry packets update in station dump
Date: Thu, 11 Jun 2020 12:26:46 +0200 [thread overview]
Message-ID: <eaf47825-bf7a-e3aa-d0dc-42cf4aa5c9f1@tu-ilmenau.de> (raw)
In-Reply-To: <1591856446-26977-1-git-send-email-vnaralas@codeaurora.org>
On 6/11/20 8:20 AM, Venkateswara Naralasetty wrote:
> When tx status enabled, retry count is updated from tx completion status.
> which is not working as expected due to firmware limitation where
> firmware can not provide per MSDU rate statistics from tx completion
> status. Due to this tx retry count is always 0 in station dump.
>
> Fix this issue by updating the retry packet count from per peer
> statistics. This patch will not break on SDIO devices since, this retry
> count is already updating from peer statistics for SDIO devices.
>
> HW used: QCA9984
> FW version: 10.4-3.6-00104
Thanks a lot for this patch! I tested it on the following HW, where it
also works.
HW: QCA9882
FW: 10.2.4-1.0-00047
Markus
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-06-11 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 6:20 [PATCH] ath10k: fix retry packets update in station dump Venkateswara Naralasetty
2020-06-11 6:20 ` Venkateswara Naralasetty
2020-06-11 10:26 ` Markus Theil [this message]
2020-06-11 10:26 ` Markus Theil
2020-06-16 8:15 ` Kalle Valo
2020-06-16 8:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf47825-bf7a-e3aa-d0dc-42cf4aa5c9f1@tu-ilmenau.de \
--to=markus.theil@tu-ilmenau.de \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vnaralas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.