From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F637C432BE for ; Mon, 30 Aug 2021 23:22:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2794360FD9 for ; Mon, 30 Aug 2021 23:22:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239031AbhH3XXN (ORCPT ); Mon, 30 Aug 2021 19:23:13 -0400 Received: from mail-pj1-f41.google.com ([209.85.216.41]:40842 "EHLO mail-pj1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237832AbhH3XXM (ORCPT ); Mon, 30 Aug 2021 19:23:12 -0400 Received: by mail-pj1-f41.google.com with SMTP id n13-20020a17090a4e0d00b0017946980d8dso601396pjh.5; Mon, 30 Aug 2021 16:22:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3BuLY5kAE+rCQDQ4lYnvYWzvrhUWdDxg0o3sLidGK5s=; b=Gh66qja4pYH+aIgAe6BAOooCPzzd7FEyDdxlaZZ+IqEa0Y8ah80VpiVZUvwF7aHqpM qgUrEV94Aj1Kpl2czixtt4DALMsiQFMED8u+pittgy5PjY3NDWy2A5qlj2oWFjc+R1Pr 0VVDaPwM+D0SDMfMaureoD3x61pDbOLE/dxlz8geiDCRvJ4ZvgcLD4WsD6kFW15iDpMQ 6fCBAXbHLfYIADC+bPdQC0GnZfkaO/pIOrYiW3IqeughHh4pPmvcBT1zloiDpepjhkIf NYyWbsS7PdZdha2kYzJjfcVw11AUMhQVnEIORqvUMxg/NDUeYsxpTWAGAzdvXoiykS+i qquQ== X-Gm-Message-State: AOAM5333ut9J4qU6S7v7cJEvwn7AGkdNeF+pfLWFmotifo0q+AXLDekY EXwDcK7DeYSZCiwMmTmrtqO8oSwPG68= X-Google-Smtp-Source: ABdhPJx0Kt94qu+u3L/jCu5PjC+so9nK8TNaDN8+z2gVkqDkG4poj7ZG9IKS+p+/l0cMxxVBoD68rw== X-Received: by 2002:a17:902:9009:b0:12d:8de4:bc2d with SMTP id a9-20020a170902900900b0012d8de4bc2dmr1830427plp.44.1630365737564; Mon, 30 Aug 2021 16:22:17 -0700 (PDT) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:86a7:224:3596:de63]) by smtp.gmail.com with ESMTPSA id u6sm17625679pgr.3.2021.08.30.16.22.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Aug 2021 16:22:16 -0700 (PDT) Subject: Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning To: Geert Uytterhoeven , Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210830091128.1854266-1-geert@linux-m68k.org> From: Bart Van Assche Message-ID: Date: Mon, 30 Aug 2021 16:22:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210830091128.1854266-1-geert@linux-m68k.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 8/30/21 2:11 AM, Geert Uytterhoeven wrote: > If CONFIG_BLK_DEBUG_FS=n: > > block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function] > 274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio) > | ^~~~~~~~~ > > Fix this by moving dd_queued() just before the sole function that calls > it. > > Fixes: 7b05bf771084ff78 ("Revert "block/mq-deadline: Prioritize high-priority requests"") > Signed-off-by: Geert Uytterhoeven The Fixes tag probably should be changed into the following: Fixes: 38ba64d12d4c ("block/mq-deadline: Track I/O statistics") Anyway: Reviewed-by: Bart Van Assche