From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Nilesh Javali <njavali@marvell.com>,
martin.petersen@oracle.com, emilne@redhat.com
Cc: linux-scsi@vger.kernel.org, GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH 3/3] qla2xxx: delete all sessions before unregister local nvme port
Date: Fri, 27 Mar 2020 09:19:09 -0500 [thread overview]
Message-ID: <eb0b8e2f-96cb-61e0-f6fd-e8075bcc0b3f@oracle.com> (raw)
In-Reply-To: <20200327102730.22351-4-njavali@marvell.com>
On 3/27/2020 5:27 AM, Nilesh Javali wrote:
> From: Quinn Tran <qutran@marvell.com>
>
> Delete all sessions before unregistering local nvme port. This
> allows nvme layer to decrement all active rport count down to zero.
> Once the count is down to zero, nvme would call qla to continue with
> the npiv port deletion.
>
> PID: 27448 TASK: ffff9e34b777c1c0 CPU: 0 COMMAND: "qaucli"
> 0 [ffff9e25e84abbd8] __schedule at ffffffff977858ca
> 1 [ffff9e25e84abc68] schedule at ffffffff97785d79
> 2 [ffff9e25e84abc78] schedule_timeout at ffffffff97783881
> 3 [ffff9e25e84abd28] wait_for_completion at ffffffff9778612d
> 4 [ffff9e25e84abd88] qla_nvme_delete at ffffffffc0e3024e [qla2xxx]
> 5 [ffff9e25e84abda8] qla24xx_vport_delete at ffffffffc0e024b9 [qla2xxx]
> 6 [ffff9e25e84abdf0] fc_vport_terminate at ffffffffc011c247 [scsi_transport_fc]
> 7 [ffff9e25e84abe28] store_fc_host_vport_delete at ffffffffc011cd94 [scsi_transport_fc]
> 8 [ffff9e25e84abe70] dev_attr_store at ffffffff974b376b
> 9 [ffff9e25e84abe80] sysfs_kf_write at ffffffff972d9a92
> 10 [ffff9e25e84abe90] kernfs_fop_write at ffffffff972d907b
> 11 [ffff9e25e84abec8] vfs_write at ffffffff9724c790
> 12 [ffff9e25e84abf08] sys_write at ffffffff9724d55f
> 13 [ffff9e25e84abf50] system_call_fastpath at ffffffff97792ed2
> RIP: 00007fc0bd81a6fd RSP: 00007ffff78d9648 RFLAGS: 00010202
> RAX: 0000000000000001 RBX: 0000000000000022 RCX: 00007ffff78d96e0
> RDX: 0000000000000022 RSI: 00007ffff78d94e0 RDI: 0000000000000008
> RBP: 00007ffff78d9440 R8: 0000000000000000 R9: 00007fc0bd48b2cd
> R10: 0000000000000017 R11: 0000000000000293 R12: 0000000000000000
> R13: 00005624e4dac840 R14: 00005624e4da9a10 R15: 0000000000000000
> ORIG_RAX: 0000000000000001 CS: 0033 SS: 002b
>
> Signed-off-by: Quinn Tran <qutran@marvell.com>
> Signed-off-by: Nilesh Javali <njavali@marvell.com>
> ---
> drivers/scsi/qla2xxx/qla_attr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
> index 3a5f6f27587e..4cfebf34ad7c 100644
> --- a/drivers/scsi/qla2xxx/qla_attr.c
> +++ b/drivers/scsi/qla2xxx/qla_attr.c
> @@ -3055,11 +3055,11 @@ qla24xx_vport_delete(struct fc_vport *fc_vport)
> test_bit(FCPORT_UPDATE_NEEDED, &vha->dpc_flags))
> msleep(1000);
>
> - qla_nvme_delete(vha);
>
> qla24xx_disable_vp(vha);
> qla2x00_wait_for_sess_deletion(vha);
>
> + qla_nvme_delete(vha);
> vha->flags.delete_progress = 1;
>
> qlt_remove_target(ha, vha);
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
next prev parent reply other threads:[~2020-03-27 14:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 10:27 [PATCH 0/3] qla2xxx: Updates for the driver Nilesh Javali
2020-03-27 10:27 ` [PATCH 1/3] qla2xxx: Fix MPI failure AEN (8200) handling Nilesh Javali
2020-03-27 14:20 ` Himanshu Madhani
2020-03-30 13:42 ` Himanshu Madhani
2020-03-27 10:27 ` [PATCH 2/3] qla2xxx: Fix hang when issuing nvme disconnect-all in NPIV Nilesh Javali
2020-03-27 14:18 ` Himanshu Madhani
2020-03-27 10:27 ` [PATCH 3/3] qla2xxx: delete all sessions before unregister local nvme port Nilesh Javali
2020-03-27 14:19 ` Himanshu Madhani [this message]
2020-03-27 13:37 ` [PATCH 0/3] qla2xxx: Updates for the driver Nilesh Javali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0b8e2f-96cb-61e0-f6fd-e8075bcc0b3f@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.