From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F26DC433F4 for ; Mon, 29 Mar 2021 08:01:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A77E6196D for ; Mon, 29 Mar 2021 08:01:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231723AbhC2IBh (ORCPT ); Mon, 29 Mar 2021 04:01:37 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:6380 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231596AbhC2IA6 (ORCPT ); Mon, 29 Mar 2021 04:00:58 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12T7w1iT002406; Mon, 29 Mar 2021 10:00:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=YARP2pjSPKUGCU0uuAV6W5anS3B8C1Bjy68KpzSsA10=; b=476iQQ/ln+z8k2S6OM44WSlaUduFXgR3sPWrk7EGcvnGpTSfV4PsJ3whyb6fFFUAAijL kphHP5Upu8cPLnbEZ1ohP+9bvlV+bV4uieGCHOdpDKlL7gRAT2VeXgYoPXXQT3uSrAvs MuYk0TJvuqeuAYBl8fHi7qZUa35Lf2ZM6f+aFtrQoc51IVLgQFWkQE5BAGbKQwYrRjzU dycYNFrHmS/RNulAPdCDLucbv0eREmRBbGIXQm3cDX3gbFYubWTMYBiA9WJbMe1vtG8O HcbHTjLkSFcSSDOCr/aLbdXyv3A4KF6DjUTRaTg6KB/TptjMFjvUjG+hNt6fJaVuWhPi ZA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37jy132qvq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Mar 2021 10:00:15 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 79E6110002A; Mon, 29 Mar 2021 10:00:13 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 58DB92397B8; Mon, 29 Mar 2021 10:00:13 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.45) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 29 Mar 2021 10:00:12 +0200 Subject: Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support To: , , , , , , , , , , , References: <1615530274-31422-1-git-send-email-dillon.minfei@gmail.com> <1615530274-31422-9-git-send-email-dillon.minfei@gmail.com> From: Alexandre TORGUE Message-ID: Date: Mon, 29 Mar 2021 10:00:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1615530274-31422-9-git-send-email-dillon.minfei@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-29_04:2021-03-26,2021-03-29 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dillon On 3/12/21 7:24 AM, dillon.minfei@gmail.com wrote: > From: dillon min > > This patch adds STM32H750 pinctrl and GPIO support > since stm32h750 has the same pin alternate functions > with stm32h743, so just reuse the stm32h743's pinctrl > driver > > Signed-off-by: dillon min > --- > v2: > - add compatible string st,stm32h750-pinctrl to pinctl-stm32h743.c as they > have same pin alternate functions > - add STM32H750 to Kconfig description > > drivers/pinctrl/stm32/Kconfig | 2 +- > drivers/pinctrl/stm32/pinctrl-stm32h743.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig > index f36f29113370..fb1ffc94c57f 100644 > --- a/drivers/pinctrl/stm32/Kconfig > +++ b/drivers/pinctrl/stm32/Kconfig > @@ -35,7 +35,7 @@ config PINCTRL_STM32F769 > select PINCTRL_STM32 > > config PINCTRL_STM32H743 > - bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743 > + bool "STMicroelectronics STM32H743/STM32H750 pin control" if COMPILE_TEST && !MACH_STM32H743 > depends on OF && HAS_IOMEM > default MACH_STM32H743 > select PINCTRL_STM32 > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32h743.c b/drivers/pinctrl/stm32/pinctrl-stm32h743.c > index ffe7b5271506..700206c7bc11 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32h743.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32h743.c > @@ -1966,6 +1966,9 @@ static const struct of_device_id stm32h743_pctrl_match[] = { > .compatible = "st,stm32h743-pinctrl", > .data = &stm32h743_match_data, > }, > + { .compatible = "st,stm32h750-pinctrl", > + .data = &stm32h743_match_data, > + }, If you use exactly the same driver (i.e. same ball out and AF mux) then you don't have to create a new compatible for that. Just use the same than h743.(so you don't have to factorize DT files). Regards Alex > { } > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AED2C433E0 for ; Mon, 29 Mar 2021 17:02:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB6FE6192F for ; Mon, 29 Mar 2021 17:02:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB6FE6192F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8oGRk8hPmiUPyBTIgleoe+dU+0NXC3SAH3EukFOjO1Q=; b=JTqcMobqsuVx9PAo7jn1TRXdQ 9J3Fl7A/Y0LbJvF9VeGY81PE9H1Ao8WejqywhVppO+rvs+zozdQz7Aod/OKgoP97CykGTOMLUlyjF ev3WgxZRpxtNslW05xynBIc3mUCxjfRU17cFrW4qYB6RX0R0OhgNquzNMpHbRCHXz+p3EEYJa1m2k JFwpRV/XP+upYDZuDoVzuviSQXM/WpJOY+yioK0cpa4AIutzswX8vmlnKWAUiD/Jzc1LhStLpMOLn O07n8yKjoFKpWLo02sQM+MecfnsD3+fvOEqa0+2bfM2t3s140meye3GmLgGeQ1ObFRORiFH/v5sCs aZpYWtnjg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQvGC-000p04-Rz; Mon, 29 Mar 2021 17:01:05 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQoki-000Z0h-Mn for linux-arm-kernel@desiato.infradead.org; Mon, 29 Mar 2021 10:04:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=YARP2pjSPKUGCU0uuAV6W5anS3B8C1Bjy68KpzSsA10=; b=ijwOd6M/0XSgA4dXyID0aR9OgQ qRJhObn1af8c+M30Vn/WYLWfex28PbkRDsfyo0juA7r9utGsnOozYRdkaVf5sd4o/NbXYHZ1vcHUB 3may9cPVttWNw5EWracvQNxer5g4Tu3r3SW3xoLWiKONoCthL5nWYcz7HRQKFcMsjYuO7DRbAhCez xOQ0Z0/zCI7aESisMxFDUrJpryjtHH9tMYINCcr/m0nE5bIBIao8W7s/7XAnxNyBOqcK8D9Uqbc0v Hfq7J8T920Rm0WaHN11m3PKsuOdUSsLJx/SCRWJs6kKQOYPDbIYW69inD0ler37aTtft94/uuajAg XoQkJ76Q==; Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQmp7-001D6w-8x for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 08:00:49 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12T7w1iT002406; Mon, 29 Mar 2021 10:00:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=YARP2pjSPKUGCU0uuAV6W5anS3B8C1Bjy68KpzSsA10=; b=476iQQ/ln+z8k2S6OM44WSlaUduFXgR3sPWrk7EGcvnGpTSfV4PsJ3whyb6fFFUAAijL kphHP5Upu8cPLnbEZ1ohP+9bvlV+bV4uieGCHOdpDKlL7gRAT2VeXgYoPXXQT3uSrAvs MuYk0TJvuqeuAYBl8fHi7qZUa35Lf2ZM6f+aFtrQoc51IVLgQFWkQE5BAGbKQwYrRjzU dycYNFrHmS/RNulAPdCDLucbv0eREmRBbGIXQm3cDX3gbFYubWTMYBiA9WJbMe1vtG8O HcbHTjLkSFcSSDOCr/aLbdXyv3A4KF6DjUTRaTg6KB/TptjMFjvUjG+hNt6fJaVuWhPi ZA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37jy132qvq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Mar 2021 10:00:15 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 79E6110002A; Mon, 29 Mar 2021 10:00:13 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 58DB92397B8; Mon, 29 Mar 2021 10:00:13 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.45) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 29 Mar 2021 10:00:12 +0200 Subject: Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support To: , , , , , , , , , , , References: <1615530274-31422-1-git-send-email-dillon.minfei@gmail.com> <1615530274-31422-9-git-send-email-dillon.minfei@gmail.com> From: Alexandre TORGUE Message-ID: Date: Mon, 29 Mar 2021 10:00:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1615530274-31422-9-git-send-email-dillon.minfei@gmail.com> Content-Language: en-US X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-29_04:2021-03-26, 2021-03-29 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_090036_999789_20A02AC4 X-CRM114-Status: GOOD ( 21.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dillon On 3/12/21 7:24 AM, dillon.minfei@gmail.com wrote: > From: dillon min > > This patch adds STM32H750 pinctrl and GPIO support > since stm32h750 has the same pin alternate functions > with stm32h743, so just reuse the stm32h743's pinctrl > driver > > Signed-off-by: dillon min > --- > v2: > - add compatible string st,stm32h750-pinctrl to pinctl-stm32h743.c as they > have same pin alternate functions > - add STM32H750 to Kconfig description > > drivers/pinctrl/stm32/Kconfig | 2 +- > drivers/pinctrl/stm32/pinctrl-stm32h743.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig > index f36f29113370..fb1ffc94c57f 100644 > --- a/drivers/pinctrl/stm32/Kconfig > +++ b/drivers/pinctrl/stm32/Kconfig > @@ -35,7 +35,7 @@ config PINCTRL_STM32F769 > select PINCTRL_STM32 > > config PINCTRL_STM32H743 > - bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743 > + bool "STMicroelectronics STM32H743/STM32H750 pin control" if COMPILE_TEST && !MACH_STM32H743 > depends on OF && HAS_IOMEM > default MACH_STM32H743 > select PINCTRL_STM32 > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32h743.c b/drivers/pinctrl/stm32/pinctrl-stm32h743.c > index ffe7b5271506..700206c7bc11 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32h743.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32h743.c > @@ -1966,6 +1966,9 @@ static const struct of_device_id stm32h743_pctrl_match[] = { > .compatible = "st,stm32h743-pinctrl", > .data = &stm32h743_match_data, > }, > + { .compatible = "st,stm32h750-pinctrl", > + .data = &stm32h743_match_data, > + }, If you use exactly the same driver (i.e. same ball out and AF mux) then you don't have to create a new compatible for that. Just use the same than h743.(so you don't have to factorize DT files). Regards Alex > { } > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel