From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org, Jin Yao <yao.jin@linux.intel.com>
Subject: Re: [PATCH] perf evlist: Fix id index for heterogeneous systems
Date: Thu, 21 Jan 2021 15:39:03 +0200 [thread overview]
Message-ID: <eb24747b-0b93-6373-cb84-52596ef3fc89@intel.com> (raw)
In-Reply-To: <20210121131901.GA345740@kernel.org>
On 21/01/21 3:19 pm, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 21, 2021 at 02:54:46PM +0200, Adrian Hunter escreveu:
>> perf_evlist__set_sid_idx() updates perf_sample_id with the evlist map
>> index, cpu number and tid. It is passed indexes to the evsel's cpu and
>> thread maps, but references the evlist's maps instead. That results in
>> using incorrect cpu numbers on heterogeneous systems. Fix by using evsel
>> maps.
>>
>> The id index (PERF_RECORD_ID_INDEX) is used by AUX area tracing when in
>> sampling mode. Having an incorrect cpu number causes the trace data to
>> be attributed to the wrong cpu, and can result in decoder errors because
>> the trace data is then associated with the wrong process.
>
> Can you please provide a Fixes: tag so that the stable@kernel.org guys
> can apply where appropriate?
Oops sorry missed that. Here it is:
Fixes: 3c659eedada2 ("perf tools: Add id index")
next prev parent reply other threads:[~2021-01-21 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 12:54 [PATCH] perf evlist: Fix id index for heterogeneous systems Adrian Hunter
2021-01-21 13:19 ` Arnaldo Carvalho de Melo
2021-01-21 13:39 ` Adrian Hunter [this message]
2021-01-21 13:40 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb24747b-0b93-6373-cb84-52596ef3fc89@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.