Hi Gabriel, Mariem, On 03/19/2018 11:26 AM, Gabriel Lucas wrote: > From: Mariem Cherif > > --- > plugins/gemalto.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 74 insertions(+), 4 deletions(-) > > diff --git a/plugins/gemalto.c b/plugins/gemalto.c > index 5573606..029e09d 100644 > --- a/plugins/gemalto.c > +++ b/plugins/gemalto.c > @@ -57,6 +57,8 @@ > #define GEMALTO_MODEL_PHS8P "0053" > #define GEMALTO_MODEL_ALS3 "0061" > > +static void gemalto_ciev_notify(GAtResult *result, gpointer user_data); > + Please note doc/coding-style.txt item M17. I silently re-structured this patch to avoid the need for this forward-declaration. Patch has been applied, thanks! Regards, -Denis