All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 5/6] dt-bindings: memory: tegra20: emc: Convert to schema
Date: Tue, 30 Mar 2021 18:56:44 +0300	[thread overview]
Message-ID: <eb29dd93-214d-ba15-7825-888467bd782b@gmail.com> (raw)
In-Reply-To: <989c3c70-3f0c-abff-ed07-c2dea3b66a2d@gmail.com>

30.03.2021 18:29, Dmitry Osipenko пишет:
> 30.03.2021 11:48, Krzysztof Kozlowski пишет:
>>> +  power-domains:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>> +    description:
>>> +      Phandle of the SoC "core" power domain.
>> I think the core checks the type, so you only need to limit max items.
>>
> 
> It's a bit confusing that both variants work and it's not apparent what
> variant is better.
> 
> I actually used the max items limit initially and then changed it to
> $ref phandle because it appeared to me that it's a better choice. I'll
> switch back to the limit in v2, thanks.
> 

Although, I'm still not sure what is the best variant. Could you please
clarify why maxItems is better?

Seems the $ref phandle already limits domain items to 1. So I don't
understand what's the difference.

  reply	other threads:[~2021-03-30 15:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 19:45 [PATCH v1 0/6] NVIDIA Tegra memory improvements Dmitry Osipenko
2021-03-29 19:45 ` [PATCH v1 1/6] dt-bindings: memory: tegra20: emc: Replace core regulator with power domain Dmitry Osipenko
2021-03-29 19:45 ` [PATCH v1 2/6] dt-bindings: memory: tegra30: " Dmitry Osipenko
2021-03-30 22:23   ` Rob Herring
2021-03-30 22:31     ` Dmitry Osipenko
2021-03-29 19:45 ` [PATCH v1 3/6] dt-bindings: memory: tegra124: " Dmitry Osipenko
2021-03-29 19:46 ` [PATCH v1 4/6] dt-bindings: memory: tegra20: mc: Convert to schema Dmitry Osipenko
2021-03-30  8:37   ` Krzysztof Kozlowski
2021-03-30 15:25     ` Dmitry Osipenko
2021-03-30 13:08   ` Rob Herring
2021-03-30 13:46     ` Rob Herring
2021-03-30 15:25       ` Dmitry Osipenko
2021-03-29 19:46 ` [PATCH v1 5/6] dt-bindings: memory: tegra20: emc: " Dmitry Osipenko
2021-03-30  8:48   ` Krzysztof Kozlowski
2021-03-30 15:29     ` Dmitry Osipenko
2021-03-30 15:56       ` Dmitry Osipenko [this message]
2021-03-30 22:33         ` Rob Herring
2021-03-30 15:32     ` Dmitry Osipenko
2021-03-30 22:35       ` Rob Herring
2021-03-30 15:34     ` Dmitry Osipenko
2021-03-29 19:46 ` [PATCH v1 6/6] memory: tegra: Print out info-level once per driver probe Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb29dd93-214d-ba15-7825-888467bd782b@gmail.com \
    --to=digetx@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.