From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29576C388F3 for ; Fri, 27 Sep 2019 15:48:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F01E421927 for ; Fri, 27 Sep 2019 15:48:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="n0Dr10Fc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727974AbfI0PsE (ORCPT ); Fri, 27 Sep 2019 11:48:04 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:59552 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727585AbfI0PsE (ORCPT ); Fri, 27 Sep 2019 11:48:04 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x8RFlwsx028604; Fri, 27 Sep 2019 10:47:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1569599278; bh=U37r5TojFgcS5DwKcw0E6Hys+tinXCxumASCFgqCX8M=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=n0Dr10Fc+4D7YJlreDJ02Ho/MKselqyZ6JuPychdRGigTx8dWWa2gK6i2fqY5dVQc IUPJMUBCpnPe8DrSvyAnfIiHNm4vGE9zwJvOxkba71HzXwN4KHTMU/1RfIyWs0RCMF vVrX5avWBICkiZbB3QrrbQqe4DGgEkXTJSC9ZWrM= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x8RFlwN2037608 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Sep 2019 10:47:58 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 27 Sep 2019 10:47:49 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 27 Sep 2019 10:47:49 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8RFltEh071020; Fri, 27 Sep 2019 10:47:55 -0500 Subject: Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts To: Tero Kristo , Adam Ford CC: Tony Lindgren , Linux-OMAP , Adam Ford , =?UTF-8?Q?Beno=c3=aet_Cousson?= , dri-devel , devicetree , Linux Kernel Mailing List References: <20190510194229.20628-1-aford173@gmail.com> <7ada0752-6f65-2906-cb29-a47c9490fd57@ti.com> <845055e2-8182-de74-2077-629fdf50ac6c@ti.com> <854f6130-c8a8-81cb-aa76-4830f218ae54@ti.com> <0473526e-df0a-94a5-5c22-debd0084ab16@ti.com> <36369388-e9c8-22cd-8c19-e2bdf2d0389b@ti.com> From: Tomi Valkeinen Message-ID: Date: Fri, 27 Sep 2019 18:47:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <36369388-e9c8-22cd-8c19-e2bdf2d0389b@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/09/2019 18:37, Tero Kristo wrote: > If you can provide details about what clock framework / driver does > wrong (sample clk_set_xyz call sequence, expected results via > clk_get_xyz, and what fails), I can take a look at it. Just reporting > arbitrary display driver issues I won't be able to debug at all (I don't > have access to any of the displays, nor do I want to waste time > debugging them without absolutely no knowledge whatsoever.) I used your hack patches to allow changing rates via debugfs. And set dss1_alwon_fck_3430es2 to 27000000 or 27870967. The end result was that DSS gets some very high clock from dss1_alwon_fck_3430es2, as the frame rate jumps to many hundreds fps. So, these numbers are not real, but to give the idea what I saw. Running first with 50 MHz, I can see, say, 40 fps. Then I set the clock to 30 MHz, and fps dropped to, say, 30fps, as expected with lower clock. Then I set the clock to 27MHz (or the other one), expecting a bit lower fps, but instead I saw hundreds of fps. I don't know if there's any other way to observe the wrong clock rate but have the dss enabled and running kmstest or similar. I can help you set that up next week, should be trivial. You don't need a display for that. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts Date: Fri, 27 Sep 2019 18:47:54 +0300 Message-ID: References: <20190510194229.20628-1-aford173@gmail.com> <7ada0752-6f65-2906-cb29-a47c9490fd57@ti.com> <845055e2-8182-de74-2077-629fdf50ac6c@ti.com> <854f6130-c8a8-81cb-aa76-4830f218ae54@ti.com> <0473526e-df0a-94a5-5c22-debd0084ab16@ti.com> <36369388-e9c8-22cd-8c19-e2bdf2d0389b@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <36369388-e9c8-22cd-8c19-e2bdf2d0389b@ti.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tero Kristo , Adam Ford Cc: devicetree , Tony Lindgren , Linux Kernel Mailing List , dri-devel , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Linux-OMAP , Adam Ford List-Id: devicetree@vger.kernel.org T24gMjcvMDkvMjAxOSAxODozNywgVGVybyBLcmlzdG8gd3JvdGU6Cgo+IElmIHlvdSBjYW4gcHJv dmlkZSBkZXRhaWxzIGFib3V0IHdoYXQgY2xvY2sgZnJhbWV3b3JrIC8gZHJpdmVyIGRvZXMgCj4g d3JvbmcgKHNhbXBsZSBjbGtfc2V0X3h5eiBjYWxsIHNlcXVlbmNlLCBleHBlY3RlZCByZXN1bHRz IHZpYSAKPiBjbGtfZ2V0X3h5eiwgYW5kIHdoYXQgZmFpbHMpLCBJIGNhbiB0YWtlIGEgbG9vayBh dCBpdC4gSnVzdCByZXBvcnRpbmcgCj4gYXJiaXRyYXJ5IGRpc3BsYXkgZHJpdmVyIGlzc3VlcyBJ IHdvbid0IGJlIGFibGUgdG8gZGVidWcgYXQgYWxsIChJIGRvbid0IAo+IGhhdmUgYWNjZXNzIHRv IGFueSBvZiB0aGUgZGlzcGxheXMsIG5vciBkbyBJIHdhbnQgdG8gd2FzdGUgdGltZSAKPiBkZWJ1 Z2dpbmcgdGhlbSB3aXRob3V0IGFic29sdXRlbHkgbm8ga25vd2xlZGdlIHdoYXRzb2V2ZXIuKQoK SSB1c2VkIHlvdXIgaGFjayBwYXRjaGVzIHRvIGFsbG93IGNoYW5naW5nIHJhdGVzIHZpYSBkZWJ1 Z2ZzLiBBbmQgc2V0IApkc3MxX2Fsd29uX2Zja18zNDMwZXMyIHRvIDI3MDAwMDAwIG9yIDI3ODcw OTY3LiBUaGUgZW5kIHJlc3VsdCB3YXMgdGhhdCAKRFNTIGdldHMgc29tZSB2ZXJ5IGhpZ2ggY2xv Y2sgZnJvbSBkc3MxX2Fsd29uX2Zja18zNDMwZXMyLCBhcyB0aGUgZnJhbWUgCnJhdGUganVtcHMg dG8gbWFueSBodW5kcmVkcyBmcHMuCgpTbywgdGhlc2UgbnVtYmVycyBhcmUgbm90IHJlYWwsIGJ1 dCB0byBnaXZlIHRoZSBpZGVhIHdoYXQgSSBzYXcuIFJ1bm5pbmcgCmZpcnN0IHdpdGggNTAgTUh6 LCBJIGNhbiBzZWUsIHNheSwgNDAgZnBzLiBUaGVuIEkgc2V0IHRoZSBjbG9jayB0byAzMCAKTUh6 LCBhbmQgZnBzIGRyb3BwZWQgdG8sIHNheSwgMzBmcHMsIGFzIGV4cGVjdGVkIHdpdGggbG93ZXIg Y2xvY2suIFRoZW4gCkkgc2V0IHRoZSBjbG9jayB0byAyN01IeiAob3IgdGhlIG90aGVyIG9uZSks IGV4cGVjdGluZyBhIGJpdCBsb3dlciBmcHMsIApidXQgaW5zdGVhZCBJIHNhdyBodW5kcmVkcyBv ZiBmcHMuCgpJIGRvbid0IGtub3cgaWYgdGhlcmUncyBhbnkgb3RoZXIgd2F5IHRvIG9ic2VydmUg dGhlIHdyb25nIGNsb2NrIHJhdGUgCmJ1dCBoYXZlIHRoZSBkc3MgZW5hYmxlZCBhbmQgcnVubmlu ZyBrbXN0ZXN0IG9yIHNpbWlsYXIuIEkgY2FuIGhlbHAgeW91IApzZXQgdGhhdCB1cCBuZXh0IHdl ZWssIHNob3VsZCBiZSB0cml2aWFsLiBZb3UgZG9uJ3QgbmVlZCBhIGRpc3BsYXkgZm9yIHRoYXQu CgogIFRvbWkKCi0tIApUZXhhcyBJbnN0cnVtZW50cyBGaW5sYW5kIE95LCBQb3Jra2FsYW5rYXR1 IDIyLCAwMDE4MCBIZWxzaW5raS4KWS10dW5udXMvQnVzaW5lc3MgSUQ6IDA2MTU1MjEtNC4gS290 aXBhaWtrYS9Eb21pY2lsZTogSGVsc2lua2kKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVs