All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>,
	Andrew Melnychenko <andrew@daynix.com>,
	qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [RFC PATCH v2 0/5] eBPF RSS support for virtio-net
Date: Mon, 30 Nov 2020 10:54:12 +0800	[thread overview]
Message-ID: <eb2f83b5-1eba-1aa9-af3d-0044b8731a91@redhat.com> (raw)
In-Reply-To: <CAOEp5Oc=v_FPE+ik=X8UnPzOmEHBXRQGYsq1PPkUUCEeecNarA@mail.gmail.com>


On 2020/11/27 下午2:06, Yuri Benditovich wrote:
>
>
>     > After some experiments we can see that stripping of debug sections
>     > reduces the size of
>     > ELF from ~45K to ~20K (we tried to strip more but the libbpf
>     fails to
>     > load it, libbpf needs BTF and symbols)
>     > So I suggest to reevaluate the necessity of libbpf.
>     > For this specific BPF it does not present advantage and we
>     hardly can
>     > create some reusable code
>     > related to libbpf, i.e. any further BPF will need its own libbpf
>     wrapper.
>     > The BTF is really good feature and in case some later BPF will
>     need an
>     > access to kernel
>     > structures it will use libbpf loader.
>     > What you think about it?
>
>
>     If we can find a way to use BTF without libbpf, it should be
>     acceptable.
>
> But the point is that the RSS BPF does not need the BTF as it does not 
> use any kernel structures.


Kinds of, it tries to access skb. But yes, it doesn't access any 
metadata of skb.


> When we have, for example, filter BPF that will need the BTF - we'll  
> use libbpf for it.
> Anyway we do not have here any infrastructural code related to libbpf,


Right, so I think we can probably start from a non BTF version without 
libbpf. And adding other features on top.

Thanks



  reply	other threads:[~2020-11-30  2:57 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 11:13 [RFC PATCH v2 0/5] eBPF RSS support for virtio-net Andrew Melnychenko
2020-11-19 11:13 ` [RFC PATCH v2 1/5] net: Added SetSteeringEBPF method for NetClientState Andrew Melnychenko
2020-11-23  6:10   ` Jason Wang
2020-11-19 11:13 ` [RFC PATCH v2 2/5] ebpf: Added eBPF RSS program Andrew Melnychenko
2020-11-24  8:14   ` Jason Wang
2020-11-19 11:13 ` [RFC PATCH v2 3/5] ebpf: Added eBPF RSS loader Andrew Melnychenko
2020-11-24  8:33   ` Jason Wang
2020-11-19 11:13 ` [RFC PATCH v2 4/5] virtio-net: Added eBPF RSS to virtio-net Andrew Melnychenko
2020-11-24  8:48   ` Jason Wang
2020-12-01  7:40     ` Yuri Benditovich
2020-12-02  4:05       ` Jason Wang
2020-12-02  7:16         ` Yuri Benditovich
2020-12-02  8:06           ` Jason Wang
2020-11-19 11:13 ` [RFC PATCH v2 5/5] docs: Added eBPF documentation Andrew Melnychenko
2020-11-24  8:54   ` Jason Wang
2020-11-26 13:00     ` Yuri Benditovich
2020-11-27  4:36       ` Jason Wang
2020-11-23  6:08 ` [RFC PATCH v2 0/5] eBPF RSS support for virtio-net Jason Wang
2020-11-26 12:52   ` Yuri Benditovich
2020-11-27  4:35     ` Jason Wang
2020-11-27  6:06       ` Yuri Benditovich
2020-11-30  2:54         ` Jason Wang [this message]
2020-12-02 13:55 ` Jason Wang
2020-12-02 14:18   ` Toke Høiland-Jørgensen
2020-12-04  7:42     ` Yuri Benditovich
2020-12-04 10:09       ` Toke Høiland-Jørgensen
2020-12-04 12:31         ` Yuri Benditovich
2020-12-04 13:57           ` Toke Høiland-Jørgensen
2020-12-06 18:44             ` Yuri Benditovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb2f83b5-1eba-1aa9-af3d-0044b8731a91@redhat.com \
    --to=jasowang@redhat.com \
    --cc=andrew@daynix.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.