From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com (ale.deltatee.com [207.54.116.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 984182111FE43 for ; Wed, 5 Sep 2018 13:10:13 -0700 (PDT) References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> <20180901082812.GB670@lst.de> <5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com> <59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk> <1b4283da-44df-4a02-3167-e295243cef78@deltatee.com> <09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk> <20180905195647.GA1626@lst.de> <20180905201152.GA1893@lst.de> From: Logan Gunthorpe Message-ID: Date: Wed, 5 Sep 2018 14:09:55 -0600 MIME-Version: 1.0 In-Reply-To: <20180905201152.GA1893@lst.de> Content-Language: en-US Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Christoph Hellwig , Jens Axboe Cc: Alex Williamson , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , =?UTF-8?Q?Christian_K=c3=b6nig?= List-ID: On 05/09/18 02:11 PM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018 at 01:54:31PM -0600, Jens Axboe wrote: >> On 9/5/18 1:56 PM, Christoph Hellwig wrote: >>> On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote: >>>> The point is that the caller doesn't necessarily know where the bio >>>> will end up, hence the caller can't fully check if the whole stack >>>> supports P2P. >>> >>> The caller must necessarily know where the bio will end up, as for P2P >>> support we need to query if the bio target is P2P capable vs the >>> source of the P2P memory. >> >> Then what's the point of having the check at all? > > Just an additional little safe guard. If you think it isn't worth > it I guess we can just drop it for now. Yes, the point is to prevent driver writers from doing the wrong thing by not doing the necessary checks before submitting to the queue. Logan _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com ([207.54.116.67]:53816 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727688AbeIFAmJ (ORCPT ); Wed, 5 Sep 2018 20:42:09 -0400 To: Christoph Hellwig , Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Benjamin Herrenschmidt , Alex Williamson , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> <20180901082812.GB670@lst.de> <5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com> <59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk> <1b4283da-44df-4a02-3167-e295243cef78@deltatee.com> <09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk> <20180905195647.GA1626@lst.de> <20180905201152.GA1893@lst.de> From: Logan Gunthorpe Message-ID: Date: Wed, 5 Sep 2018 14:09:55 -0600 MIME-Version: 1.0 In-Reply-To: <20180905201152.GA1893@lst.de> Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On 05/09/18 02:11 PM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018 at 01:54:31PM -0600, Jens Axboe wrote: >> On 9/5/18 1:56 PM, Christoph Hellwig wrote: >>> On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote: >>>> The point is that the caller doesn't necessarily know where the bio >>>> will end up, hence the caller can't fully check if the whole stack >>>> supports P2P. >>> >>> The caller must necessarily know where the bio will end up, as for P2P >>> support we need to query if the bio target is P2P capable vs the >>> source of the P2P memory. >> >> Then what's the point of having the check at all? > > Just an additional little safe guard. If you think it isn't worth > it I guess we can just drop it for now. Yes, the point is to prevent driver writers from doing the wrong thing by not doing the necessary checks before submitting to the queue. Logan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Logan Gunthorpe Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests Date: Wed, 5 Sep 2018 14:09:55 -0600 Message-ID: References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> <20180901082812.GB670@lst.de> <5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com> <59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk> <1b4283da-44df-4a02-3167-e295243cef78@deltatee.com> <09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk> <20180905195647.GA1626@lst.de> <20180905201152.GA1893@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180905201152.GA1893-jcswGhMUV9g@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Christoph Hellwig , Jens Axboe Cc: Alex Williamson , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , =?UTF-8?Q?Christian_K=c3=b6nig?= List-Id: linux-rdma@vger.kernel.org On 05/09/18 02:11 PM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018 at 01:54:31PM -0600, Jens Axboe wrote: >> On 9/5/18 1:56 PM, Christoph Hellwig wrote: >>> On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote: >>>> The point is that the caller doesn't necessarily know where the bio >>>> will end up, hence the caller can't fully check if the whole stack >>>> supports P2P. >>> >>> The caller must necessarily know where the bio will end up, as for P2P >>> support we need to query if the bio target is P2P capable vs the >>> source of the P2P memory. >> >> Then what's the point of having the check at all? > > Just an additional little safe guard. If you think it isn't worth > it I guess we can just drop it for now. Yes, the point is to prevent driver writers from doing the wrong thing by not doing the necessary checks before submitting to the queue. Logan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: To: Christoph Hellwig , Jens Axboe References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> <20180901082812.GB670@lst.de> <5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com> <59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk> <1b4283da-44df-4a02-3167-e295243cef78@deltatee.com> <09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk> <20180905195647.GA1626@lst.de> <20180905201152.GA1893@lst.de> From: Logan Gunthorpe Message-ID: Date: Wed, 5 Sep 2018 14:09:55 -0600 MIME-Version: 1.0 In-Reply-To: <20180905201152.GA1893@lst.de> Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Alex Williamson , Sagi Grimberg , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen Bates , linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , Dan Williams , =?UTF-8?Q?Christian_K=c3=b6nig?= Content-Type: text/plain; charset="us-ascii" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On 05/09/18 02:11 PM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018 at 01:54:31PM -0600, Jens Axboe wrote: >> On 9/5/18 1:56 PM, Christoph Hellwig wrote: >>> On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote: >>>> The point is that the caller doesn't necessarily know where the bio >>>> will end up, hence the caller can't fully check if the whole stack >>>> supports P2P. >>> >>> The caller must necessarily know where the bio will end up, as for P2P >>> support we need to query if the bio target is P2P capable vs the >>> source of the P2P memory. >> >> Then what's the point of having the check at all? > > Just an additional little safe guard. If you think it isn't worth > it I guess we can just drop it for now. Yes, the point is to prevent driver writers from doing the wrong thing by not doing the necessary checks before submitting to the queue. Logan _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 From: logang@deltatee.com (Logan Gunthorpe) Date: Wed, 5 Sep 2018 14:09:55 -0600 Subject: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests In-Reply-To: <20180905201152.GA1893@lst.de> References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> <20180901082812.GB670@lst.de> <5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com> <59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk> <1b4283da-44df-4a02-3167-e295243cef78@deltatee.com> <09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk> <20180905195647.GA1626@lst.de> <20180905201152.GA1893@lst.de> Message-ID: On 05/09/18 02:11 PM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018@01:54:31PM -0600, Jens Axboe wrote: >> On 9/5/18 1:56 PM, Christoph Hellwig wrote: >>> On Wed, Sep 05, 2018@01:45:04PM -0600, Jens Axboe wrote: >>>> The point is that the caller doesn't necessarily know where the bio >>>> will end up, hence the caller can't fully check if the whole stack >>>> supports P2P. >>> >>> The caller must necessarily know where the bio will end up, as for P2P >>> support we need to query if the bio target is P2P capable vs the >>> source of the P2P memory. >> >> Then what's the point of having the check at all? > > Just an additional little safe guard. If you think it isn't worth > it I guess we can just drop it for now. Yes, the point is to prevent driver writers from doing the wrong thing by not doing the necessary checks before submitting to the queue. Logan