From: Eric Sandeen <sandeen@sandeen.net>
To: David Howells <dhowells@redhat.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: Clarification of statx->attributes_mask meaning?
Date: Mon, 30 Nov 2020 17:29:47 -0600 [thread overview]
Message-ID: <eb47ab08-67fc-6151-5669-d4fb514c2b50@sandeen.net> (raw)
In-Reply-To: <1942931.1606341048@warthog.procyon.org.uk>
On 11/25/20 3:50 PM, David Howells wrote:
> Darrick J. Wong <darrick.wong@oracle.com> wrote:
>
>> mask=1 bit=0: "attribute not set on this file"
>> mask=1 bit=1: "attribute is set on this file"
>> mask=0 bit=0: "attribute doesn't fit into the design of this fs"
>
> Or is "not supported by the filesystem driver in this kernel version".
For a concrete example, let's talk about the DAX statx attribute.
If the kernel is configured w/o DAX support, should the DAX attr be in the mask?
If the block device has no DAX support, should the DAX attr be in the mask?
If the filesystem is mounted with dax=never, should the DAX attr be in the mask?
About to send a patch for xfs which answers "no" to all of those, but I'm still
not quite sure if that's what's expected. I'll be sure to cc: dhowells, Ira, and
others who may care...
-Eric
>> mask=0 bit=1: "filesystem is lying snake"
>
> I like your phrasing :-)
>
>> It's up to the fs driver and not the vfs to set attributes_mask, and
>> therefore (as I keep pointing out to XiaoLi Feng) xfs_vn_getattr should
>> be setting the mask.
>
> Agreed. I think there's some confusion stemming from STATX_ATTR_MOUNT_ROOT -
> but that's supported by the *vfs* not by the filesystem.
>
> David
>
next prev parent reply other threads:[~2020-11-30 23:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 19:19 Clarification of statx->attributes_mask meaning? Eric Sandeen
2020-11-25 21:25 ` Darrick J. Wong
2020-11-25 21:42 ` Eric Sandeen
2020-11-25 21:50 ` David Howells
2020-11-30 23:29 ` Eric Sandeen [this message]
2020-12-01 3:20 ` Theodore Y. Ts'o
2020-12-01 3:37 ` Eric Sandeen
2020-12-01 3:50 ` Eric Sandeen
2020-12-01 15:39 ` Theodore Y. Ts'o
2020-12-01 16:25 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb47ab08-67fc-6151-5669-d4fb514c2b50@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.