From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soeren Moch Date: Sun, 24 May 2020 17:46:22 +0200 Subject: [PATCH] tbs2910: migrate to DM_VIDEO In-Reply-To: <20200522232417.4202-1-agust@denx.de> References: <20200522232417.4202-1-agust@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 23.05.20 01:24, Anatolij Gustschin wrote: > Migration to DM_VIDEO driver is long overdue, configure it in > board config files. To enable the display set stdout like: > > setenv stdout serial,vidconsole > > Signed-off-by: Anatolij Gustschin > --- > This is only build tested. I tested this on top of v2020.07-rc2 and your patch "video: extend stdout video console work-around for 'vga'" Works great. However, some comments below. > > configs/tbs2910_defconfig | 7 ++++++- > include/configs/tbs2910.h | 2 -- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig > index 2ff0e160f7..b40641c17b 100644 > --- a/configs/tbs2910_defconfig > +++ b/configs/tbs2910_defconfig > @@ -1,6 +1,7 @@ > CONFIG_ARM=y > CONFIG_ARCH_MX6=y > CONFIG_SYS_TEXT_BASE=0x17800000 > +CONFIG_SYS_MALLOC_F_LEN=0x4000 This is not necessary. The default 0x2000 also works fine. > CONFIG_ENV_SIZE=0x2000 > CONFIG_ENV_OFFSET=0x60000 > CONFIG_TARGET_TBS2910=y > @@ -84,7 +85,11 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > CONFIG_CI_UDC=y > CONFIG_USB_GADGET_DOWNLOAD=y > CONFIG_I2C_EDID=y > +CONFIG_DM_VIDEO=y > +# CONFIG_VIDEO_BPP8 is not set > +# CONFIG_VIDEO_BPP32 is not set > +# CONFIG_VIDEO_ANSI is not set > CONFIG_VIDEO_IPUV3=y > -CONFIG_VIDEO=y > +CONFIG_SYS_WHITE_ON_BLACK=y > CONFIG_OF_LIBFDT_ASSUME_MASK=0xff > # CONFIG_EFI_LOADER is not set > diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h > index 7376b91f55..8ab3fcfe3e 100644 > --- a/include/configs/tbs2910.h > +++ b/include/configs/tbs2910.h > @@ -37,11 +37,9 @@ > #define CONFIG_MXC_UART_BASE UART1_BASE /* select UART1/UART2 */ > > /* Framebuffer */ > -#ifdef CONFIG_VIDEO > #define CONFIG_VIDEO_BMP_RLE8 > #define CONFIG_IMX_HDMI > #define CONFIG_IMX_VIDEO_SKIP > -#endif > > /* PCI */ > #ifdef CONFIG_CMD_PCI Since DM_VIDEO requires vidconsole as output device, please also add ---8<--- diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h index 8ab3fcfe3e..82165a9ffe 100644 --- a/include/configs/tbs2910.h +++ b/include/configs/tbs2910.h @@ -92,11 +92,11 @@ ??????? "fan=gpio set 92\0" \ ??????? "set_con_serial=setenv stdout serial; " \ ??????????????????????? "setenv stderr serial\0" \ -?????? "set_con_hdmi=setenv stdout serial,vga; " \ -?????????????????????? "setenv stderr serial,vga\0" \ -?????? "stderr=serial,vga\0" \ +?????? "set_con_hdmi=setenv stdout serial,vidconsole; " \ +?????????????????????? "setenv stderr serial,vidconsole\0" \ +?????? "stderr=serial,vidconsole\0" \ ??????? "stdin=serial,usbkbd\0" \ -?????? "stdout=serial,vga\0" +?????? "stdout=serial,vidconsole\0" ? ?#define CONFIG_BOOTCOMMAND \ ??????? "mmc rescan; " \ ---8<--- to avoid warnings for users with default environment.(not sure if whitespace is still correct in this snippet) With this DM_VIDEO conversion the board comes very close to the size limit. While it works with my toolchain, there might be problems with others. So maybe not a good idea to merge this as fix immediately. Since this depends on your above mentioned patch, do you plan to merge this via u-boot-video, or should this go as usual through the imx tree? Thank you very much for finishing this DM_VIDEO migration, Soeren