From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A69C43381 for ; Wed, 27 Mar 2019 13:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EDF92146F for ; Wed, 27 Mar 2019 13:25:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="QuCsf3AC"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="g/8mTcIC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729701AbfC0NZc (ORCPT ); Wed, 27 Mar 2019 09:25:32 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55152 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfC0NZc (ORCPT ); Wed, 27 Mar 2019 09:25:32 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2D4B760F3F; Wed, 27 Mar 2019 13:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553693131; bh=mUl4z+Wv1PPRl7E5dal1fpy/eVC8v7Uf33IRSjlErlw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QuCsf3ACRw3McaVaANjG0QK2TnrvbhT5x227CmXzttGrI+KpMDz1X0qeUjsqASCFr Dvx4h3k380NJjjfgfAf/B9SobhI8ST9scm+z0NwGrtC8d8DJocM8xZ5YCCbLk7nhc0 QBOmYyp5sxGL2jFVfDDA7ZKhaumeoIodYAix/ylo= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 58AD76081E; Wed, 27 Mar 2019 13:25:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553693129; bh=mUl4z+Wv1PPRl7E5dal1fpy/eVC8v7Uf33IRSjlErlw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g/8mTcICU7DIfpX7gPR1SfBCYpERXbZhnpRzpytommq8ZcH/lX/HUEE7RqZR0SDm7 8XPyptfMgsXpJ90WnupKPQTsj1pCn2mVojijcAo61kmvEo4v4eIzGfEWInuQbEZ7a9 kaWUIcz7pkXMY4QywH+SpFjrgla6nEYlxOJFlviA= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 27 Mar 2019 18:55:28 +0530 From: Sibi Sankar To: Rajendra Nayak Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, andy.gross@linaro.org, david.brown@linaro.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH v2 4/9] dt-bindings: power: Add rpm power domain bindings for qcs404 In-Reply-To: <6989da8a-d295-0079-ed32-b31fb1272c63@codeaurora.org> References: <20190324175007.29040-1-sibis@codeaurora.org> <20190324175007.29040-5-sibis@codeaurora.org> <6989da8a-d295-0079-ed32-b31fb1272c63@codeaurora.org> Message-ID: X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-03-25 09:51, Rajendra Nayak wrote: > On 3/24/2019 11:20 PM, Sibi Sankar wrote: >> From: Bjorn Andersson >> >> Add RPM Power domain bindings for the qcs404 family of SoC >> >> [sibis: Add supported rpmpd states for qcs404] >> Signed-off-by: Sibi Sankar > > SoB ordering seems wrong. will re-order them in v3 > >> Signed-off-by: Bjorn Andersson >> --- >> .../devicetree/bindings/power/qcom,rpmpd.txt | 1 + >> include/dt-bindings/power/qcom-rpmpd.h | 22 >> +++++++++++++++++++ >> 2 files changed, 23 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt >> b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt >> index 980e5413d18f..172ccf940c5c 100644 >> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt >> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt >> @@ -6,6 +6,7 @@ which then translates it into a corresponding voltage >> on a rail >> Required Properties: >> - compatible: Should be one of the following >> * qcom,msm8996-rpmpd: RPM Power domain for the msm8996 family of >> SoC >> + * qcom,qcs404-rpmpd: RPM Power domain for the qcs404 family of SoC >> * qcom,sdm845-rpmhpd: RPMh Power domain for the sdm845 family of >> SoC >> - #power-domain-cells: number of cells in Power domain specifier >> must be 1. >> diff --git a/include/dt-bindings/power/qcom-rpmpd.h >> b/include/dt-bindings/power/qcom-rpmpd.h >> index 87d9c6611682..450378662944 100644 >> --- a/include/dt-bindings/power/qcom-rpmpd.h >> +++ b/include/dt-bindings/power/qcom-rpmpd.h >> @@ -36,4 +36,26 @@ >> #define MSM8996_VDDSSCX 5 >> #define MSM8996_VDDSSCX_VFC 6 >> +/* QCS404 Power Domains */ >> +#define QCS404_VDDMX 0 >> +#define QCS404_VDDMX_AO 1 >> +#define QCS404_VDDMX_VFL 2 >> +#define QCS404_LPICX 3 >> +#define QCS404_LPICX_VFL 4 >> +#define QCS404_LPIMX 5 >> +#define QCS404_LPIMX_VFL 6 >> + >> +/* RPM SMD Power Domain performance levels */ > > so unlike in the sdm845 case where we map these levels to > (contiguous) corners before passing it over to rpm, we seem > to pass these as-is to rpm, right? > > Does this work if the user passes some value which does not > really map to a level defined here? > For instance if value passed is 17 for instance do we fall back to > 16? The rpm firmware will ensure that a ceil operation is performed on any requested level which does not map to a pre-defined level. I did try to do the same in kernel however since the opp-levels are not inserted in ascending order while populating the opp-table for rpmpd, it becomes difficult to get ceil/floor levels from the opp-table with minimal changes. > >> +#define RPM_SMD_LEVEL_RETENTION 16 >> +#define RPM_SMD_LEVEL_RETENTION_PLUS 32 >> +#define RPM_SMD_LEVEL_MIN_SVS 48 >> +#define RPM_SMD_LEVEL_LOW_SVS 64 >> +#define RPM_SMD_LEVEL_SVS 128 >> +#define RPM_SMD_LEVEL_SVS_PLUS 192 >> +#define RPM_SMD_LEVEL_NOM 256 >> +#define RPM_SMD_LEVEL_NOM_PLUS 320 >> +#define RPM_SMD_LEVEL_TURBO 384 >> +#define RPM_SMD_LEVEL_TURBO_NO_CPR 416 >> +#define RPM_SMD_LEVEL_BINNING 512 >> + >> #endif >> -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.