From: David Hildenbrand <david@redhat.com>
To: Li Qiang <liq3ea@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Li Qiang <liq3ea@163.com>,
Qemu Developers <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] hw: virtio-mem: detach the element fromt the virtqueue when error occurs
Date: Sun, 16 Aug 2020 14:10:31 +0200 [thread overview]
Message-ID: <eb5da5eb-6bd9-0325-90e1-5172f930b981@redhat.com> (raw)
In-Reply-To: <CAKXe6S+ZqV7XMx7e_3ZAW2zk8EQEayUeKBNA1x3PrsdhH_rZyg@mail.gmail.com>
On 14.08.20 03:01, Li Qiang wrote:
> David Hildenbrand <david@redhat.com> 于2020年8月14日周五 上午1:15写道：
>>
>> On 13.08.20 18:46, Li Qiang wrote:
>>
>> For now we use "virtio-mem:" for the subject, without the "hw: "part.
>>
>>> If error occurs while processing the virtio request we should call
>>> 'virtqueue_detach_element' to detach the element from the virtqueue
>>> before free the elem.
>>
>> What's the effect of this? In all cases we trigger a virtio_error(), so
>> do we really have to bother?
>>
>
> Though the 'in_use' will be reset to 0 while reseting the virtio device.
> The mapped sglist will not be unammped.
> There maybe some undesired behavior. CC Paolo to make a confirmation.
Looking at hw/virtio/virtio-crypto.c, this seems to be the right thing
to do.
Can you please respin, avoiding adding the label, only inserting the 3
separate virtqueue_detach_element() calls?
Thanks!
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-08-16 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 16:46 [PATCH] hw: virtio-mem: detach the element fromt the virtqueue when error occurs Li Qiang
2020-08-13 17:15 ` David Hildenbrand
2020-08-14 1:01 ` Li Qiang
2020-08-16 12:10 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5da5eb-6bd9-0325-90e1-5172f930b981@redhat.com \
--to=david@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.