From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62D8C433EF for ; Tue, 12 Oct 2021 08:44:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD84761050 for ; Tue, 12 Oct 2021 08:44:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234998AbhJLIqY (ORCPT ); Tue, 12 Oct 2021 04:46:24 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59544 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232666AbhJLIqY (ORCPT ); Tue, 12 Oct 2021 04:46:24 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19C86wHS027272; Tue, 12 Oct 2021 04:44:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=+cQxyTBJX7uHvJ9ZAgXcIBphBtShWT46WBQIxN9j834=; b=Qtygw993qlM7WC3YRp6jFJo6S8W3S5kWu5yFWzVn1PHbV2y1eWjPeGGuep62/f4Y2nQc p3xpi+Gmeq96TkA58ea3pNW2MPqycHQGvjNLX1073+vr6puIlJfHhCNjaTvpCTGnDD0l XYcvC8mpE+z87ZR+QmzTo6v1mn1TSbxlzK6HBOGbcnFok+WcGH2P2E1p6Nu2lrv1qYH7 Y62XOdOw18q/0RkVOWtTA7MD1NEO9Rmks2dAjdr2FvD6OrXJXElGqDMwcjEPTLjgHExV dx/kLOvtwY8QsNTs34pTkz0VB8ulprs7L0NPInSLJIdMufR2+fWV3WgLGjhjnlZplh7I Bg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bn49ykp2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Oct 2021 04:44:22 -0400 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 19C8Vml6025339; Tue, 12 Oct 2021 04:44:22 -0400 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bn49ykp1w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Oct 2021 04:44:22 -0400 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19C8hPpI001516; Tue, 12 Oct 2021 08:44:19 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma06fra.de.ibm.com with ESMTP id 3bk2bjcr8e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Oct 2021 08:44:19 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19C8iFHF42991968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Oct 2021 08:44:15 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D1B734C046; Tue, 12 Oct 2021 08:44:15 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 036694C04E; Tue, 12 Oct 2021 08:44:15 +0000 (GMT) Received: from li-43c5434c-23b8-11b2-a85c-c4958fb47a68.ibm.com (unknown [9.171.4.239]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 12 Oct 2021 08:44:14 +0000 (GMT) Subject: Re: [RFC PATCH v1 6/6] KVM: s390: Add a routine for setting userspace CPU state To: Eric Farman , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Jason Herne Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <20211008203112.1979843-1-farman@linux.ibm.com> <20211008203112.1979843-7-farman@linux.ibm.com> From: Christian Borntraeger Message-ID: Date: Tue, 12 Oct 2021 10:44:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211008203112.1979843-7-farman@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: LRgDgLdxO4I_Esj6Axw9DEvi7BW-UM3q X-Proofpoint-GUID: tosAPkGgZcFHorGiGumQ50ZHl6RNgB1t X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-12_02,2021-10-11_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110120047 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org Am 08.10.21 um 22:31 schrieb Eric Farman: > This capability exists, but we don't record anything when userspace > enables it. Let's refactor that code so that a note can be made in > the debug logs that it was enabled. > > Signed-off-by: Eric Farman I also applied this one. Thanks. > --- > arch/s390/kvm/kvm-s390.c | 6 +++--- > arch/s390/kvm/kvm-s390.h | 9 +++++++++ > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index 33d71fa42d68..48ac0bd05bee 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -2487,8 +2487,8 @@ long kvm_arch_vm_ioctl(struct file *filp, > case KVM_S390_PV_COMMAND: { > struct kvm_pv_cmd args; > > - /* protvirt means user sigp */ > - kvm->arch.user_cpu_state_ctrl = 1; > + /* protvirt means user cpu state */ > + kvm_s390_set_user_cpu_state_ctrl(kvm); > r = 0; > if (!is_prot_virt_host()) { > r = -EINVAL; > @@ -3801,7 +3801,7 @@ int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu, > vcpu_load(vcpu); > > /* user space knows about this interface - let it control the state */ > - vcpu->kvm->arch.user_cpu_state_ctrl = 1; > + kvm_s390_set_user_cpu_state_ctrl(vcpu->kvm); > > switch (mp_state->mp_state) { > case KVM_MP_STATE_STOPPED: > diff --git a/arch/s390/kvm/kvm-s390.h b/arch/s390/kvm/kvm-s390.h > index 57c5e9369d65..36f4d585513c 100644 > --- a/arch/s390/kvm/kvm-s390.h > +++ b/arch/s390/kvm/kvm-s390.h > @@ -208,6 +208,15 @@ static inline int kvm_s390_user_cpu_state_ctrl(struct kvm *kvm) > return kvm->arch.user_cpu_state_ctrl != 0; > } > > +static inline void kvm_s390_set_user_cpu_state_ctrl(struct kvm *kvm) > +{ > + if (kvm->arch.user_cpu_state_ctrl) > + return; > + > + VM_EVENT(kvm, 3, "%s", "ENABLE: Userspace CPU state control"); > + kvm->arch.user_cpu_state_ctrl = 1; > +} > + > /* implemented in pv.c */ > int kvm_s390_pv_destroy_cpu(struct kvm_vcpu *vcpu, u16 *rc, u16 *rrc); > int kvm_s390_pv_create_cpu(struct kvm_vcpu *vcpu, u16 *rc, u16 *rrc); >